public inbox for [email protected]  
help / color / mirror / Atom feed
From: Zhijie Hou (Fujitsu) <[email protected]>
To: vignesh C <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: RE: Memory leak in pg_logical_slot_{get,peek}_changes
Date: Fri, 27 Dec 2024 08:13:53 +0000
Message-ID: <OS0PR01MB57160B4CAF3BB995155705C8940E2@OS0PR01MB5716.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <CALDaNm0f05TAqs-KiQQVQo-VtVEjZL_ANev22kP3_Fkj_kEKGw@mail.gmail.com>
References: <CALDaNm1hewNAsZ_e6FF52a=9drmkRJxtEPrzCB6-9mkJyeBBqA@mail.gmail.com>
	<OS0PR01MB5716AD5128F16AA1A02B6D29943E2@OS0PR01MB5716.jpnprd01.prod.outlook.com>
	<CALDaNm1kAHWeBEVKBqp=EnCwOS3qB_OjcKF8zz5J8EpXUcAi+A@mail.gmail.com>
	<CALDaNm0f05TAqs-KiQQVQo-VtVEjZL_ANev22kP3_Fkj_kEKGw@mail.gmail.com>

On Thursday, December 26, 2024 8:01 PM vignesh C <[email protected]> wrote:
> 
> Here is an updated version which includes registers to reset the memory
> context that is in-line with a recently committed patch at [1].

Thanks for updating patches ! They look good to me.

Just to confirm, would the other stuff (streamed_txns) that allocated under
CacheMemoryContext also leaks memory ? I think it's OK to change them
separately if it does but just would like to confirm if there is a risk.

> [1] -
> https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=cfd6cbc
> f9be078fbdf9587014231a5772039b386

Best Regards,
Hou zj


view thread (9+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: RE: Memory leak in pg_logical_slot_{get,peek}_changes
  In-Reply-To: <OS0PR01MB57160B4CAF3BB995155705C8940E2@OS0PR01MB5716.jpnprd01.prod.outlook.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox