Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n2pC1-0002oZ-Fm for pgsql-hackers@arkaria.postgresql.org; Thu, 30 Dec 2021 06:45:41 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1n2pC0-0000by-9X for pgsql-hackers@arkaria.postgresql.org; Thu, 30 Dec 2021 06:45:40 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n2pBz-0000bp-E3 for pgsql-hackers@lists.postgresql.org; Thu, 30 Dec 2021 06:45:40 +0000 Received: from esa18.fujitsucc.c3s2.iphmx.com ([216.71.158.38]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n2pBw-00067B-9j for pgsql-hackers@lists.postgresql.org; Thu, 30 Dec 2021 06:45:39 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=fujitsu.com; i=@fujitsu.com; q=dns/txt; s=fj1; t=1640846737; x=1672382737; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=fcREY9NKeSp0UJsaF4G4sLYTQWpXDJmIft5w7QLmA9Y=; b=UDR49dockxNlSx9HDKYRuk0ze5BTfFjPxfHIddk4uj7bN/QQFDRzlJ4e XZngjWKDgTylN+HMUHZh0Gw1pAOuBtthOlLji5vuTc2AwBBYY1cSzH2+J M7LndLf/Qai3iVLJSBKLXNFpqUSsElxktzICCxy1L83wW4d8InurHWuVP kbQF9PZpupNzDZ4z4JpbpkA5EfLq9Xc5O7Wy1v+FjtyiXrmKcS+JRkLpj k0LiifPFrNLJdRklo/siq2MRhB7rwj9gbK/1bAwHFEgNZhJB8z0C4ja5e Z4cCKzXqlMIt89b7d9JCmgx6yMzPyzFdMlghhluR3L8npWBwZnd92vr/B Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10212"; a="47756202" X-IronPort-AV: E=Sophos;i="5.88,247,1635174000"; d="scan'208";a="47756202" Received: from mail-os0jpn01lp2110.outbound.protection.outlook.com (HELO JPN01-OS0-obe.outbound.protection.outlook.com) ([104.47.23.110]) by ob1.fujitsucc.c3s2.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Dec 2021 15:45:34 +0900 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JX7v+kjXWYVVLkVIs9CzmEStib/4NcEvz/ZSXcgkCQiIZx3pVWSfnVgvaXZhIwwxEoKlkUwfRxg5PoRjZz+b8TIkMWMhisdDb2+SmbosoX9SGSz2FdlhWfxJ7lsDz8ryWcy8aNPetJbH6zxih9AeSkQYJtGb5QRX1SjziU6midBLNTQXo2wQn2yz13bUQkHu67s3g2LlsMVQoL1X5Ze5brh1ATJgv4MxdGNw1UK0BKOfFu539YkTPj97ZbIrHvniiaf/6v6Y/CoZgsBTyzIpDioFCoElPzJYu8GX5+jQb49U6XxFOYk+t36lf5ozUPgqa8X4uCJqDh1//xA24KMc3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=j4FaHNJ4u7jjuBNlsfWEyBJaJuBYUwo1UGmuKUJj/FM=; b=KP1mZ+HLhlegKrILtLj5xSlTmtvIvtImr5/r/oEPjiTeKdUVaXsYPNHfkY+jtoUCuWtJrqSdXMupuPWgEOQvasGKIhQdUTIwv3uWAIs8qTl+W623e0Ux/J+xUKg2JmRRG+dAZXgYEmfM4xhUudq9/8PJEdmTti9l3TNnzd/MQmB9gMKPTGmeD4crLL2lWEGpfJ0wqD5ID5axhl3GIz+2FCCyuTXU0KdCcfnf0rUaNQOLrb1toxA8Q7K/UCzJ9zElTpfMl/imOYUPbXZciMf9nvL+iGbB5o4GndKc+Q+di8Ksfk/ur/jnsMmLz8rMgYE59OptaeWxv8ISSTDF2qHYDQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=fujitsu.com; dmarc=pass action=none header.from=fujitsu.com; dkim=pass header.d=fujitsu.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fujitsu.onmicrosoft.com; s=selector2-fujitsu-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=j4FaHNJ4u7jjuBNlsfWEyBJaJuBYUwo1UGmuKUJj/FM=; b=awQ9bbJXpCwRzbzTWkOl+X7fDqGVCRAmEMOMRvo3RJVZx9sXMX/iz9M/PxdSzu50CWkeJ3AvxUoxcmSK2l00C1wCnyIjoO2IxBWatGSZ7IPx2pGtVjVL6q9m1t5XSMP0c/WVtDqucp5Gd5Xw8JAWUbARGx0wmO1OAx0SmMAbYow= Received: from OS0PR01MB5716.jpnprd01.prod.outlook.com (2603:1096:604:bb::12) by OSBPR01MB3784.jpnprd01.prod.outlook.com (2603:1096:604:47::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4823.21; Thu, 30 Dec 2021 06:45:30 +0000 Received: from OS0PR01MB5716.jpnprd01.prod.outlook.com ([fe80::31d5:658f:efdd:577a]) by OS0PR01MB5716.jpnprd01.prod.outlook.com ([fe80::31d5:658f:efdd:577a%5]) with mapi id 15.20.4844.014; Thu, 30 Dec 2021 06:45:30 +0000 From: "houzj.fnst@fujitsu.com" To: Michael Paquier , Euler Taveira CC: "wangw.fnst@fujitsu.com" , Ashutosh Bapat , "pgsql-hackers@lists.postgresql.org" Subject: RE: Confused comment about drop replica identity index Thread-Topic: Confused comment about drop replica identity index Thread-Index: Adfw525FJW2P08QbQM2Ttivu6VuGugACMX6AABzGiYAADEddEAAcEDAAAAfJfYAAyxaeoAAQho8AAAfoxQAAFJLRgAHQ1fFw Date: Thu, 30 Dec 2021 06:45:30 +0000 Message-ID: References: <53e4a0d4-4b7b-4001-99c3-576bc03f73ef@www.fastmail.com> In-Reply-To: Accept-Language: ja-JP, en-US Content-Language: ja-JP X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=fujitsu.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5761fb89-9e00-46ee-a830-08d9cb5ff8ba x-ms-traffictypediagnostic: OSBPR01MB3784:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: lq9f9S4GxMwGTqPgoo5Ya4YShmFpTepAPurY5/hWCzh2EEX1Vp7KFF2qkSAzPemqkCjKQySc+nCKdhL7Xzz5Nt+SWC4r6qFy+TWo1gH3QtpMhvaIbkW6fPqUEj65XyCeileHuwFdpc2XS2aSvm9d7+lflaRjlggaREwkOmcLfo6dzJUvaaegRunyowSUxBdUNCjEJKELZVcIyPQOgXFqmoJiMiErZpXj1HVRsvcReavCJ1uXdwkNG7xheLa+N0KB88ggmBB5Svaw8OB0NyetpS/pkcrAeNYSxooV2lmupLNTyycFHinc3VWGguS2KyinhlCIk8LpdCYXUznt3T6RXODZQ8dTMCRnGccgRlK1WzPWZCRL1RfqDY9d6S1qSscTzGyYs9kbCDzVlTcfMOfc9x76/bs0tnSK0f2AIK+8GLrtbNElMpj5KxSqshuA77q7ZSnXkCiO5TN9Beo7wT1LjOnr12/HJYgtNECFPPgon/1x2Cye5WeINt/yE1Xd5pPakMNe71OV/eaYja6iGMpGIWw1t9zz5Om/IzpqwJ6tNExtHCA2V1CCsS1WXRi4TURBIMywkoyw3lFJIJs/G785+xgpZXkuvKN5y7shkztPUG97KOE0RujNRusdK3slchUPVzoF94eZhCPriRfAiqghL3sfDdD5mG67+Qoci3JPhDDjVc77c5w8PLLya2O2kEKmD92YElfitT4APrY/spx2x0PvYJQDneNCeJa9zM/fRmg= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:OS0PR01MB5716.jpnprd01.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(8936002)(85182001)(8676002)(64756008)(66556008)(4326008)(82960400001)(4744005)(71200400001)(55016003)(186003)(38100700002)(38070700005)(7696005)(2906002)(83380400001)(9686003)(86362001)(110136005)(508600001)(122000001)(52536014)(33656002)(54906003)(316002)(26005)(5660300002)(76116006)(6506007)(66476007)(66446008)(66946007)(366874004);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-2022-jp?B?UnU1MmFpK2VaUytBdEFSWEdNb0dpOEFQcXRZZ2xxS00wTy8xR1hLL3p5?= =?iso-2022-jp?B?VjRib3FOcDYzUXNhMEFDTjd0aEFyYUV2VjhCRmtYUURrUHUweGJqWi8v?= =?iso-2022-jp?B?Y1JicTRrbEtYcEIxYWJQWklzdXpJWDRBNG9oL2o0RlVqaEpyR0pHYXYv?= =?iso-2022-jp?B?RWFWdGlHclNBRllURnpxVUdNbGtXcDhyQ3l3ZDNrTXlWeDFVb0FhMDY3?= =?iso-2022-jp?B?cEUyUG4zQzBpQWJaTU9xbGZMOERacitENmtNQjU5a0pUSXBPTklweG9Q?= =?iso-2022-jp?B?QmJ3V0Z4clZhR1J4V3U1TFBsT0N1V0NpeFk4RWJ0WVBLVllEc1dkVktr?= =?iso-2022-jp?B?UkpyWDdVenZCajdDaVhUVk5tbXNlNzVVNEQzVThtQ2lOT21yQW5ES0Zr?= =?iso-2022-jp?B?OWxTcHZNVWltOTdUaEMrcVNqNC8zSGhoVWZVWWJ0elpIY0Z6UnVpaHdO?= =?iso-2022-jp?B?TVZCYWxTby9MNVplSTNqK3Q1QjdPUVNhOGgxWm5aeld5UlMyOUYzK0Vt?= =?iso-2022-jp?B?SnovR0c5WWMrcWFyR1N2aU1hNExoODBySVZjUWxKZzFOWEFPb2RpMUhL?= =?iso-2022-jp?B?NnNUOUVXWEZjaXZib2tEejFoY3RneHNMdjJuczNiaXVWL1hOekxZSy9Z?= =?iso-2022-jp?B?T2pwQXYxVXltM2lJMUFKNzhOekdlMkgrWjN2SGx6dklkaEQ2YzJGNXZk?= =?iso-2022-jp?B?ZGNLaHdNMmNxMHFkVDVVZXVnanVXeHB5TEpLRis3RE5mSThYL2tUbk1F?= =?iso-2022-jp?B?RWNNemhKTkc1NExRcFlZSzVOQm9KRDd2SHRLZVU4UVRaQUJzWHlXMjRo?= =?iso-2022-jp?B?NTFqT3Q4QU5wSTdraTRsTXZSeGRuOGd6MjZYbVR2enBTVkYxcitZQVQ0?= =?iso-2022-jp?B?SUl6c0l5SU94Y2FMcEJaWVZaL3F2L2xiYWs2VFp4b1F4ZmVhbmVYM2lm?= =?iso-2022-jp?B?Y2NrdDVNeEhPZGdUSldCM2tGMXZUcXlPUGRNY2dBRS80M0sxUlBWMlRB?= =?iso-2022-jp?B?SHdrNTdHT3NHN2JJclNZMUZEbUQycldZdUkvak1UR2svSW1RRE9QSWNh?= =?iso-2022-jp?B?WmpzazN0M3g0UnhwR2JnTVhTSlhucFlmcm50Ym9XYWVxNWIzT21Td1ZX?= =?iso-2022-jp?B?T3UxdzdqSWo1L2VjdzRGb01CaUk2MmFuSzJlREt5bENZZWxWYTlIWDRt?= =?iso-2022-jp?B?dEhLWnVyTDNSRFh4TXJDQ3pOSGxwcTgvR0k2NDN2dW9XVzA2c0cvOFJ2?= =?iso-2022-jp?B?M3pTYmJyWXUzWDRHTEdrbUYzejdjOWxQbUYyZHFvdU43VndtSkhKblNt?= =?iso-2022-jp?B?SmNqSTJDNURoaEo0d2RveGt0a0xUcjMzQ1FmM1hwUzc4TTVMVDhwdTR1?= =?iso-2022-jp?B?UnZIcGhudUhxOVBEVHJ2RndnUldad3Q1ZmdnbzJrVXJFVmNpYVUweXBy?= =?iso-2022-jp?B?bVhZTnpLRlJQQm80djhzMnQ0NFRIY2h6VStXTzYwOC9GVmwxc3Ryc0lr?= =?iso-2022-jp?B?VkE5dmR0bjdpWDQwR21VSGsvMFhNbWpDZk42Q3R6UENXcmhDak91WlBP?= =?iso-2022-jp?B?QTJOckVyVjFwQkZmaHZrY0NCWCt6QXRBMDYzaTd6WUx3ZTZESDA3RkpZ?= =?iso-2022-jp?B?T3U4YWtleE5lbmgwcktwUDdGWU85cHR6SlpDaTE2bHZuMmI2YWVHT2Zj?= =?iso-2022-jp?B?TjJ2L1BsMEN1cGZmVGZZVjJ1enZVVVR5RktvZ0R4WVBBQVRBdVJjcnFZ?= =?iso-2022-jp?B?ZHMycU5UbjVFUC9GM1ZZQnZpZTJuQWRoYUlXUGF6elVIcktoeE5HeGFC?= =?iso-2022-jp?B?QXdEMTFmTFJvckZjM2x0eFFvUXYrcWkySjhpUnRaMlo2S0p6c2haVm1o?= =?iso-2022-jp?B?YVNpTEhPaXVVRE1JaHo3a1VjQUZsZGh6YzdMQ0VacTJ0SjF3TnZUQXcv?= =?iso-2022-jp?B?UnF0RTQzN1F4Y01oNkVhYzdPRk5SZTd3MktwcGs4ejBxcDRYSnd2Nkhs?= =?iso-2022-jp?B?TEplZ1NwSXFLV1RKdlNpZk5HS0E2bGhoYm5sM0lDV0x2bklYTXZEVGFP?= =?iso-2022-jp?B?U3JrMFdTOGNiSmtiNnM5dUtYSGtveE1TSDJmU0lNSlQremdIYTc1dXRG?= =?iso-2022-jp?B?Z0xsWGRLVlQxR09YV3lLZ3RWTGhpYUtNR1RQektFWTdnQVZaWmVqMmlT?= =?iso-2022-jp?B?V0VtUFNlcG5jSkk1dkFWR0ZuUWdyd2tVd2xJWFZ4a29xOEhDRnRmcjJl?= =?iso-2022-jp?B?dzluWDJNd3g0TENWWlB0N1BvUkd4MVJQcWx1d1NLOUZGcG5xYmtXUWdX?= =?iso-2022-jp?B?R1A3blk5L2FvbHdvODl5M1FwZmtwNCtnMnMzb0RXNWRRR1hiTG50ZXZM?= =?iso-2022-jp?B?L04vUUk9?= Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: fujitsu.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: OS0PR01MB5716.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5761fb89-9e00-46ee-a830-08d9cb5ff8ba X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Dec 2021 06:45:30.4481 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a19f121d-81e1-4858-a9d8-736e267fd4c7 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GQo01uncWU0gfr6Z6F7BfwIwPcJTuSWl18dfjLEgRUVwoR4iBihd5NTRl2CkAIpqxHlBe98TDdSA2zNdMo9AJQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSBPR01MB3784 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Tues, Dec 21, 2021 8:47 AM Michael Paquier wrote: > On Mon, Dec 20, 2021 at 11:57:32AM -0300, Euler Taveira wrote: > > What do you think about the attached patch? It forbids the DROP INDEX. > > We might add a detail message but I didn't in this patch. >=20 > Yeah. I'd agree about doing something like that on HEAD, and that would = help > with some of the logirep-related patch currently being worked on, as far = as I > understood. Hi, I think forbids DROP INDEX might not completely solve this problem. Because user could still use other command to delete the index, for example: ALTER TABLE DROP COLUMN. After dropping the column, the index on it will also be dropped. Besides, user can also ALTER REPLICA IDENTITY USING INDEX "primary key", an= d in this case, when they ALTER TABLE DROP CONSTR "PRIMARY KEY", the replica identity index will also be dropped. Best regards, Hou zj