public inbox for [email protected]  

help / color / mirror / Atom feed
From: [email protected] <[email protected]>
To: Dilip Kumar <[email protected]>
Cc: pgsql-hackers <[email protected]>
Subject: RE: [BUG]Update Toast data failure in logical replication
Date: Mon, 31 May 2021 10:03:54 +0000
Message-ID: <OS0PR01MB61137DE0A63EC2AD65CFB35AFB3F9@OS0PR01MB6113.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <CAFiTN-tir1MJUBaUSdspOJZZZXbZgzufwr8rpaXR2KZ0HBe8OA@mail.gmail.com>
References: <OS0PR01MB611342D0A92D4F4BF26C0F47FB229@OS0PR01MB6113.jpnprd01.prod.outlook.com>
	<OS0PR01MB61131DF0574EEFFECC157555FB229@OS0PR01MB6113.jpnprd01.prod.outlook.com>
	<OS0PR01MB6113D49D3AE7F0CA59679DA4FB229@OS0PR01MB6113.jpnprd01.prod.outlook.com>
	<CAFiTN-ve8w3NY89vYi9ck8HMMXjLc=2YTU+ZCoQZ_f2C-7oXhg@mail.gmail.com>
	<OS0PR01MB6113F5E14AFD98EF6B3B85CCFB3F9@OS0PR01MB6113.jpnprd01.prod.outlook.com>
	<CAFiTN-v-LSyGqu5AfJDjfGZup_Gp37dgzukPEhUUsAqy9RT7_A@mail.gmail.com>
	<CAFiTN-tir1MJUBaUSdspOJZZZXbZgzufwr8rpaXR2KZ0HBe8OA@mail.gmail.com>

On Mon, May 31, 2021 5:12 PM Dilip Kumar <[email protected]> wrote:
> 
> The problem is if the key attribute is not changed we don't log it as
> it should get logged along with the updated tuple, but if it is
> externally stored then the complete key will never be logged because
> there is no log from the toast table.  For fixing this if the key is
> externally stored then always log that.
> 
> Please test with the attached patch.

Thanks for your patch. I tested it and the bug was fixed.
I'm still trying to understand your fix, please allow me to ask more(maybe silly) questions if I found any.

+	 * if the key hasn't changedand we're only logging the key, we're done.

I think "changedand" should be "changed and".

Regards
Tang


view thread (31+ messages)  latest in thread

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: RE: [BUG]Update Toast data failure in logical replication
  In-Reply-To: <OS0PR01MB61137DE0A63EC2AD65CFB35AFB3F9@OS0PR01MB6113.jpnprd01.prod.outlook.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox