public inbox for [email protected]
help / color / mirror / Atom feedFrom: [email protected] <[email protected]>
To: Hayato Kuroda (Fujitsu) <[email protected]>
To: Amit Kapila <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: vignesh C <[email protected]>
Cc: Peter Smith <[email protected]>
Cc: Takamichi Osumi (Fujitsu) <[email protected]>
Cc: [email protected] <[email protected]>
Cc: [email protected] <[email protected]>
Cc: Amit Langote <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Cc: [email protected] <[email protected]>
Cc: Dilip Kumar <[email protected]>
Cc: Greg Nancarrow <[email protected]>
Subject: RE: Data is copied twice when specifying both child and parent table in publication
Date: Tue, 21 Mar 2023 07:42:11 +0000
Message-ID: <OS3PR01MB6275C00A0D4B55DDF1552AEF9E819@OS3PR01MB6275.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <TYAPR01MB5866CF4AB36AE9E0ABED126AF5809@TYAPR01MB5866.jpnprd01.prod.outlook.com>
References: <OS3PR01MB62751414E4DABF144F5E481C9E529@OS3PR01MB6275.jpnprd01.prod.outlook.com>
<CAHut+PtTN1Udug3x1eZnDdh8Z6PL5VN=xz1b44VbB9T1z_PtcQ@mail.gmail.com>
<OS3PR01MB6275A9B8C65C381C6828DF9D9E549@OS3PR01MB6275.jpnprd01.prod.outlook.com>
<CAHut+PvaSDuZ7PhzZOm4c2u-sbN4DUsZr22qyYQ8dncUpqMpXg@mail.gmail.com>
<OS3PR01MB6275843B2BBE92870F7881C19E299@OS3PR01MB6275.jpnprd01.prod.outlook.com>
<CAHut+Pt+1PNx6VsZ-xKzAU-18HmNXhjCC1TGakKX46Wg7YNT1Q@mail.gmail.com>
<OS3PR01MB6275FB5397C6A647F262A3A69E009@OS3PR01MB6275.jpnprd01.prod.outlook.com>
<CALDaNm3ZzNJ6Y1iX=PBYCcCU+EPm4=9LVXFin5gvQ9XkEzc8UQ@mail.gmail.com>
<OS3PR01MB6275C62FF1D1CDE4FCBF61339E079@OS3PR01MB6275.jpnprd01.prod.outlook.com>
<[email protected]>
<OS3PR01MB62758DFA4FE5BFA7CA0815329ED89@OS3PR01MB6275.jpnprd01.prod.outlook.com>
<CAA4eK1LCzvPLVHHXn+VcGmFHApKtbpaNF1UFed3qE8=GhPzPGw@mail.gmail.com>
<OSZPR01MB62783EDCE9DDC21D35B789209EBD9@OSZPR01MB6278.jpnprd01.prod.outlook.com>
<CAA4eK1+B=TC9Aty+QafCu=icBb2=cRCfiqep8fTFqE2f_oH99A@mail.gmail.com>
<OS3PR01MB6275298569C91BB39740C7429E809@OS3PR01MB6275.jpnprd01.prod.outlook.com>
<TYAPR01MB5866CF4AB36AE9E0ABED126AF5809@TYAPR01MB5866.jpnprd01.prod.outlook.com>
On Mon, Mar 20, 2023 at 21:18 PM Kuroda, Hayato/黒田 隼人 <[email protected]> wrote:
> Dear Wang,
>
> I have tested about multilevel partitions, and it worked well.
> Followings are my comments for v18-0001.
Thanks for your comments and testing.
> 01. pg_get_publication_tables
>
> ```
> + ListCell *lc;
> ```
>
> This definition can be inside of the "for (i = 0; i < nelems; i++)".
Changed.
> 02. pg_get_publication_tables
>
> ```
> - * If the publication publishes partition changes via their
> - * respective root partitioned tables, we must exclude partitions
> - * in favor of including the root partitioned tables. Otherwise,
> - * the function could return both the child and parent tables
> - * which could cause data of the child table to be
> - * double-published on the subscriber side.
> + * Publications support partitioned tables. If
> + * publish_via_partition_root is false, all changes are replicated
> + * using leaf partition identity and schema, so we only need those.
> + * Otherwise, get the partitioned table itself.
> ```
>
> The comments can be inside of the "else".
Since I think there are related operations in the function
GetAllTablesPublicationRelations, it might be better to write it above the
if-statement.
> 03. pg_get_publication_tables
>
> ```
> + pfree(elems);
> ```
>
> Only elems is pfree()'d here, but how about other variable like pub_elem and
> pub_elem_tables?
Added releases to these two variables.
Regards,
Wang Wei
view thread (23+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: RE: Data is copied twice when specifying both child and parent table in publication
In-Reply-To: <OS3PR01MB6275C00A0D4B55DDF1552AEF9E819@OS3PR01MB6275.jpnprd01.prod.outlook.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox