public inbox for [email protected]  

help / color / mirror / Atom feed

From: Hayato Kuroda (Fujitsu) <[email protected]>
To: 'Nazir Bilal Yavuz' <[email protected]>
To: Peter Eisentraut <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Cc: Andrew Dunstan <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: Álvaro Herrera <[email protected]>
Cc: Bruce Momjian <[email protected]>
Subject: RE: Improve docs syntax checking and enable it in the meson build
Date: Mon, 16 Feb 2026 00:47:55 +0000
Message-ID: <OS9PR01MB121494161EC790951B3B4CFBAF56CA@OS9PR01MB12149.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <CAN55FZ3re9Z1pefDQBcixZXxdXLQrnD8qW0zTdF+7HiadkXHDQ@mail.gmail.com>
References: <CAN55FZ1qzoDcaKqsR3DwE=X6FL+wpm+=KLvH6ahrRXNhjU53DQ@mail.gmail.com>
	<[email protected]>
	<CAN55FZ0=9PzKud+QrTLEF2j28Cn7Aphx3EEHZhgHYtuCkKMFug@mail.gmail.com>
	<[email protected]>
	<CAN55FZ3re9Z1pefDQBcixZXxdXLQrnD8qW0zTdF+7HiadkXHDQ@mail.gmail.com>

Dear Nazir,

I created a similar patch with yours because I did not recognize this thread.
Not sure you are still interested in, but here are my comments based on my
experience.

00.
Needs rebase.

01.
I found that postgres core was built when I ran `meson test --suite doc`
command, but ideally it's not needed. Per my experiment, we must clarify
dependencies for the test, something like below.

```
--- a/doc/src/sgml/meson.build
+++ b/doc/src/sgml/meson.build
@@ -337,7 +337,8 @@ test(
   'doc' / 'sgml_syntax_check',
   meson_bin,
   args: ['compile', postgres_full_xml_target],
-  suite: 'doc'
+  suite: 'doc',
+  depends: doc_generated,
 )
```

02.
Missing update of copyright.

03.
I found that for the autoconf build system, syntax checking cannot work again
if nothing is changed. This behavior is different from the HEAD. Per my
experiment, below can fix the issue.

```
--- a/doc/src/sgml/Makefile
+++ b/doc/src/sgml/Makefile
@@ -201,6 +201,7 @@ MAKEINFO = makeinfo
 ##

 # Quick syntax check without style processing
+.PHONY: postgres-full.xml
 check: postgres-full.xml
```

04.
`make check` is slightly slower than HEAD. I think it is OK but others can also
confirm and can test on their env.

HEAD:
```
$ time make check
...

real    0m0.592s
user    0m0.507s
sys     0m0.084s
```

patched:
```
$ time make check
...

real    0m1.217s
user    0m0.973s
sys     0m0.237s
```

Best regards,
Hayato Kuroda
FUJITSU LIMITED

view thread (3+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: RE: Improve docs syntax checking and enable it in the meson build
  In-Reply-To: <OS9PR01MB121494161EC790951B3B4CFBAF56CA@OS9PR01MB12149.jpnprd01.prod.outlook.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox