Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rwdyk-0039l7-PT for pgsql-hackers@arkaria.postgresql.org; Tue, 16 Apr 2024 08:15:46 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rwdyj-001yvS-7g for pgsql-hackers@arkaria.postgresql.org; Tue, 16 Apr 2024 08:15:45 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rwdyi-001yvK-Rh for pgsql-hackers@lists.postgresql.org; Tue, 16 Apr 2024 08:15:44 +0000 Received: from esa5.fujitsucc.c3s2.iphmx.com ([68.232.159.76]) by magus.postgresql.org with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rwdyd-001EMo-3G for pgsql-hackers@postgresql.org; Tue, 16 Apr 2024 08:15:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=fujitsu.com; i=@fujitsu.com; q=dns/txt; s=fj1; t=1713255339; x=1744791339; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=5wlyKl0+TOdU4RVmuI0rnzrjU60dwtwJz1zW06vtjLA=; b=WURUC2zGbfluLu5z3VDXCO5LR4hHfFJR5ZqlqvDo/qJkL1TbBk2iTxdl LPPrA+CHfviBjJrILAjs88+70PN2KnujPu3iapflX3d9mfupYE42VPUeP ZRzsHMRDeGRqoPhCbIPpWL0HX3wtQVqkn3ueJrB5Y83IJrCzGXZbPtM/U yC3nz3LTUXhW5bA085u7O9UV7eKmvC4p4kQLfJ74Lp5y7Nf6VEV7rtDMX 3W+RtUTqbtDMsVMlvzatmuewEZY8dij2HOk/e3mU6Wu1UB+8OS8U2JwmR 25Vx1R4BJEy0rcumOTXPYIGweHzSknAXpN4aSqpSvAusSq+IYJjAJuWlt A==; X-IronPort-AV: E=McAfee;i="6600,9927,11045"; a="117303291" X-IronPort-AV: E=Sophos;i="6.07,205,1708354800"; d="scan'208";a="117303291" Received: from mail-tycjpn01lp2168.outbound.protection.outlook.com (HELO JPN01-TYC-obe.outbound.protection.outlook.com) ([104.47.23.168]) by ob1.fujitsucc.c3s2.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Apr 2024 17:15:37 +0900 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KMAbhzoihVS/DAjRVMpGzdvzt4364W+X01+Xcx/1ZWjl0GdB0Vv2Vp+5qHGyPrMvvRlq3nSqF2bwz68SGAxW//5nDdcNkmmm5Xf3W7p2wxXMsmwP1WyZ6MyOoXbrRI0rgd7F2p6y3TxCP8Cz6fa3yjbgq0/y/7RO/j2d3nSyPQ8rocN3zBSSzOY8sjy5W2Ltd8mmYy2RUR6iaZ4+3oRuxqdpIZaZ6Cm/zxHZwXcu3EevOZ0Xrouxqmer3eDZO+fFKHwRZXzR1F3HcT/uDJLlZI11gLXPJzsTTmd8cjYEYHgBipp9vyoIHaFwMT+0ut1ydbbOL2vHYmNbSvhnh8jHbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5wlyKl0+TOdU4RVmuI0rnzrjU60dwtwJz1zW06vtjLA=; b=E837xzPCeUeEFE9H3mj94XjLjPDxwtZNwC6xO/86pGPabqqzfr/5BjF6kWua62wIGn+VVU6VQDjvCaN2PSdoB86KdVp7Sq0K53Iv35IF4603RvVC275IxsCTXSqs7DDfmePK1JCJXs/tfeaFgjGR6shlxrpqBcqsP5ZZPHpANxivXHrHc1K7bzAxV5S7JDdHKxkHQH8Adgm/Z5zW2CyGg5kl5HiFbpyGdUae2xsMx4QzZb4SBI0LOGQYZzMxqAi2AiwkOVHWYp2wzRv3nP2poc32vr0VGUPVzQ493TBbb/UiXKaqNdhriGn/0dkatWp1R6xm+1cqzsfOMTkwUz8JBQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=fujitsu.com; dmarc=pass action=none header.from=fujitsu.com; dkim=pass header.d=fujitsu.com; arc=none Received: from OSBPR01MB2552.jpnprd01.prod.outlook.com (2603:1096:604:18::11) by TYAPR01MB6092.jpnprd01.prod.outlook.com (2603:1096:402:36::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.50; Tue, 16 Apr 2024 08:15:33 +0000 Received: from OSBPR01MB2552.jpnprd01.prod.outlook.com ([fe80::67b6:c904:2de8:328b]) by OSBPR01MB2552.jpnprd01.prod.outlook.com ([fe80::67b6:c904:2de8:328b%4]) with mapi id 15.20.7452.049; Tue, 16 Apr 2024 08:15:33 +0000 From: "Hayato Kuroda (Fujitsu)" To: "Zhijie Hou (Fujitsu)" CC: Amit Kapila , pgsql-hackers Subject: RE: Disallow changing slot's failover option in transaction block Thread-Topic: Disallow changing slot's failover option in transaction block Thread-Index: AdqPx27t2k962OukSWqc74tUiYu9KQADoQAQ Date: Tue, 16 Apr 2024 08:15:33 +0000 Message-ID: References: In-Reply-To: Accept-Language: ja-JP, en-US Content-Language: ja-JP X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_ActionId=77da4422-2edf-457a-b16c-a6679809b3bd;MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_ContentBits=0;MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_Enabled=true;MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_Method=Standard;MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_Name=FUJITSU-RESTRICTED?;MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_SetDate=2024-04-16T06:20:11Z;MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_SiteId=a19f121d-81e1-4858-a9d8-736e267fd4c7; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=fujitsu.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: OSBPR01MB2552:EE_|TYAPR01MB6092:EE_ x-ms-office365-filtering-correlation-id: 6c18ef8d-e384-4a3d-bcc4-08dc5ded638f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Sn/lsVJ4l2b5zUqnMVmzugN+0BTm3w3iPbV+Xa0RW+vf/in2Wsx2krUkHLwK6T0tfolyN45QCuKISr7HsXtvNYAifzVjMk7E29+kU2awrYod5lMSpBV/MUzFcPcWB4jBwDVNzgJ8SvkJ3m/Z7xRkBf/btRM9AQgn2SaJJ6Ro9oxZpneLuyReicJOSinPo1HYhtT92DnTDg6D6KA0X/EiVcoL8xxv4/cK2hj290jKuw9asiJ+FJ6J9c6XtFkEmhwrRKnu7ZYTxByQycYUcMs42umEApB9IfSjGWC43S/IjzMpJhbw5puMx0ajSXcz641A35Idb6W80+ARw1eUvxkrqxeqF4NhWpMgmWdiMm5pJecul59Vydfr5VWJvh7Fru0ct7biIfjGOWEanTLF6dPuyxccFxLtuqHsPIMyZKtVmKYwaLm2h6IvIyhUZ3HKp+QEgINOHV6rsEq3+mz5FEOdJP8E7cyEuv6HcvMh5G64+BD+BK7OTaUL3uK+vG5owWchUbTMi0E0CSQFg/iIAyGXIe8Gt818zBhlIy02HTNgP+cghO8ryAbQ0D8JCmKMj329RZX8utwNsQ0wCkKPQLN1IMbZSnISOroQWKgtAp7iz1ojrGi7teLSjTgdvZQrFWUJhMbgHTgGI4887mQN79oAO44+qCWpjWaAYZpPW769wvl2nKJtyajQudKVTGVY4gHFrs7T+7RW8/piBIRW8HvWHw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:ja;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:OSBPR01MB2552.jpnprd01.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(366007)(1800799015)(1580799018)(38070700009);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-2022-jp?B?SHdoRHVONEczYmU2VWNwMUNBaDFkeFZEM0VRaUdLaWdsVlhub2lQR1RU?= =?iso-2022-jp?B?eC9yOU4vdmQ2N2cyLzdDeG5Qa3JvU0wrS1d3VVovWFlvZnRMTk5DL2JX?= =?iso-2022-jp?B?TVFsL1pPU0pzS1Z2b01DRUhkNDFHclVYUXF2eDZsS1A2RHVEbldmZ2M5?= =?iso-2022-jp?B?dGR0ZG9CTDRVMDQzTURXUGVoN08rMmNmcXBaTE1WMVRnMmhRVGprY0d1?= =?iso-2022-jp?B?elQ4KzJCTktNcE5LdjBoS0tMVEgvWUZGVUNPcVB5UURDNTBxaSsvc0RI?= =?iso-2022-jp?B?Wnk0OUdVaXU4RUZ2dGhhdkdsY3R0R2VWemFvOVJGSDA1WStmQ0JFVjM1?= =?iso-2022-jp?B?eHRFNytsUTVadHI5dGp6Qm83c0FKN3Y0KzNxUGtSNEdZQzY5OGI3TFhD?= =?iso-2022-jp?B?RjVuTEY5UmZkcHZTUHh2c21JZmpzOGtWcm0reG9saFNRTGIzeEthQzda?= =?iso-2022-jp?B?V2tJNzk4dVJKcDlCYTVwM1JMTWxBSks5c3hHclNsV1RTcGdUMWppYjJW?= =?iso-2022-jp?B?aURZMnlITTAvSkZFRjRhdTBDUDBMUEoxelJvbVVMRXczWkdaOUY2blAw?= =?iso-2022-jp?B?TDdSWFpIeHVFQzFSc21oVmF0d2dBaXRRNGFFV1F3Sk92ay9CbmhzdUlz?= =?iso-2022-jp?B?a1NtWnZ5WGRqcVpTZ3FQZkZWa1FwN0IrRW9qSnpXYWJZa2l1cUpRQlQ3?= =?iso-2022-jp?B?dGNyUjZQYk5SVWRKUTdkd2tueEZZYU1NYjlYZjVsYzloM1B6UndxWEJm?= =?iso-2022-jp?B?VWVtQ0Z4SEo2ZDE0Mll3azNCVE56RDE5dGZoUjRTaUdHWSt2MjRYUVVT?= =?iso-2022-jp?B?WGluZjA1MktXTXNIK0pCWHhmYXovaTdabUpmK293WlFxUlRaTDVpR2k1?= =?iso-2022-jp?B?cEtlV3g3b2dZTUNZdnp6djFSVW9ldVNJSllYemZMaW11eGJwbitZK1dB?= =?iso-2022-jp?B?cmVsVm40a1pNN0tIWUNaTTdxaE1ITWUySUoydXg4cHJhZWlQWXJVY204?= =?iso-2022-jp?B?TERYcUFmdy93eC9zSWpOMHcrai9CWSs5bzBhSzRBYXhLUXgrVll5MGRS?= =?iso-2022-jp?B?eHhHMlZ6TFcvanFoUUkzUEFsUEZ6aFBhdzgyQ1lsQW9wcmFvZDIvVEx5?= =?iso-2022-jp?B?TzZkbGdVeXRwSlJhMlZRbTIrbFpDQm8yQzZwVDN1dy8wRG5XendaRmlx?= =?iso-2022-jp?B?N1Z4MEZHTW5hTHNCNHZoN1NmSlRrdVM5eUpzWXp4Z3dyUWwwRHBRRGZV?= =?iso-2022-jp?B?b3B4bWFnbGFsa2h5VjQzR1lWZmJsRkFFZE5wNVFWc0NWbjFXKzFXZFdt?= =?iso-2022-jp?B?WVlVS0k2MktuT3o3L1Y0dkNKQnRacmtjZ2d5WEFrTEh3S3BiMXZLWVI5?= =?iso-2022-jp?B?aGUyKzNCTHBUYnZ1SnVQM2ZpaEdsSkhGWWZ0WkpEcWwxR1VUczFDNUN0?= =?iso-2022-jp?B?NUtsTHBpR2d1bWdwUzFlSjJrZXBoZUVEK0M2VlFCY1RsMDNkaVU3ZzRk?= =?iso-2022-jp?B?VjVXZUNWWkxpM1phWTR1bC9jMzhoRG5WM1Q4emdaRTFmeEptZk9Ua201?= =?iso-2022-jp?B?dGhNdVFYbDQ2S1J1L3dybE5EdDRVMzFNYVNtT2x5RC9aMzNkc3NIOTY2?= =?iso-2022-jp?B?Wi9ueWI4TmtVb011SS8rTURPM3dTMnFTcXBiV1J5cW9hQktydHdMdW5K?= =?iso-2022-jp?B?bUg3dFpOMXhoNzZpWTc3MWQ3ODhkbWVmdDc0b1lmTFQ5L0NVMjhWNE5m?= =?iso-2022-jp?B?djdaUFFvRjltZkxabzFOR2s1WmtFT0Frbm8zbE1zODAvYmcwT3QwWGlU?= =?iso-2022-jp?B?VlVZbXNCVU1lRVlCRTBIb1dHUExQNCtwY1VXWFV2Tm1ubGRmT1NqNVRV?= =?iso-2022-jp?B?U0pJY2d2NVErcTBtTGx3ZEo3OS9jRGRyMzRjUnp6SnR2WHhMdUVlanpY?= =?iso-2022-jp?B?a1hPcDJOUFZRcXBYNWN1OTlUMW4rWkcyUlQ0MDhCOGtTQ2Z0WXMvWWtK?= =?iso-2022-jp?B?S0tuVEJsU3hmTW0zNDYzemVSamdNNHZIR3REbmpaaDA3Zkt4aWFkWTMx?= =?iso-2022-jp?B?dnlydmtFTkEvaENtTENvbzlCM0pGTlFBNFNXeUJOSmJYWXI4ZlVaeWxJ?= =?iso-2022-jp?B?TWdZa2dsMXovOXpXdm01MnFWaVg4UUI0YTZTRFEzcHNNNHRBZCt5S0E5?= =?iso-2022-jp?B?MHZIYzVxeEswZlRGV2hpS203cEhPTmhJYzYzZGNLLzR4TjYxTFlLVCtu?= =?iso-2022-jp?B?TjAyOFlOcTVpaFhMNzBZd3pRdXlXc1orNDExYXErUm0rMm5ZUXNhZStW?= =?iso-2022-jp?B?aWQ1OEgrc0ZBVWdaajR0OHdRL0FNdnJGRFE9PQ==?= Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: mHq6qvCvx/u2qIfOtelCSaB98I0AM5GtZ3wlBAdw4J6fLyAlnt4RWlNp12gj2l0W601YwxSQDvg/+BhIUIoJZINlgIkunxYr0ZTDrRBEaSruPBKrMTx1PRIgVC9myiDGiWyPPWlURrzpBUFP8yZBxTDXBuTL+1lVIxAwB76pD8qwxVP4LEvKQ0D57NTS0wYn7YmrpaVoIVrUbb+8TtcyqbRO2cdj5u1CjQMaEUf/5ZfyylII1aYyj44K/6VlfYHOHoGDqiDToCkXa2WvVjRDAgo9OuiMScRJ/Xdc5Jyf3QG9mL8vyynXqQi3iyk5MoT+GVh+6NzcHRyrsoGTEn/vyZwtV5o0SOfibHLhuLbX3wm9L4lcZpoUdNRgdGu5Nn8VqFNmS+FNnnXNjiSGNVVgDitT9KgPnImrjMINvf1X2RKz/Ogc3JO5B+QCalY+w3UVnk2cXAWn6s3bSnpZnmGxsNgdDwZDqyRj4RNqAEnj+JOQ9aCaCmYhSgso52UIyqK4oALYzYpWqRXl9GYY5vwy7bkG7qrp9oga8WipdTiSx54C70lNrzKfmr0BV1XkToARxF8mDGlWo1/MGi9XrDTZ1rpvI1y/gzCyE3q/YgwCBglUAxwOiUn/Q1esy/Z+hyg6 X-OriginatorOrg: fujitsu.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: OSBPR01MB2552.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6c18ef8d-e384-4a3d-bcc4-08dc5ded638f X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Apr 2024 08:15:33.8561 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a19f121d-81e1-4858-a9d8-736e267fd4c7 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dmkjzgNWVLRLdsv4PpvaFHOYkKDk0W/dcuXsFTO4uJcPuTTtCRhOPBtvR7+whTbkl7BEYkNi7OxLnYunV/CgfxfDNuzB7hemuF4l2BTFmoM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYAPR01MB6092 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Dear Hou, > Kuroda-San reported an issue off-list that: >=20 > If user execute ALTER SUBSCRIPTION SET (failover) command inside a txn bl= ock > and rollback, only the subscription option change can be rolled back, whi= le the > replication slot's failover change is preserved. >=20 > This is because ALTER SUBSCRIPTION SET (failover) command internally > executes > the replication command ALTER_REPLICATION_SLOT to change the replication > slot's > failover property, but this replication command execution cannot be > rollback. >=20 > To fix it, I think we can prevent user from executing ALTER SUBSCRIPTION = set > (failover) inside a txn block, which is also consistent to the ALTER > SUBSCRIPTION REFRESH/DROP SUBSCRIPTION command. Attach a small > patch to address this. Thanks for posting the patch, the fix is same as my expectation. Also, should we add the restriction to the doc? I feel [1] can be updated. [1]:https://www.postgresql.org/docs/devel/sql-altersubscription.html#SQL-AL= TERSUBSCRIPTION-PARAMS-SET Best Regards, Hayato Kuroda FUJITSU LIMITED https://www.fujitsu.com/=20