public inbox for [email protected]
help / color / mirror / Atom feedFrom: Hayato Kuroda (Fujitsu) <[email protected]>
To: 'Alexander Korotkov' <[email protected]>
Cc: Dilip Kumar <[email protected]>
Cc: Zhijie Hou (Fujitsu) <[email protected]>
Cc: Amit Kapila <[email protected]>
Cc: Vitaly Davydov <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: Alexander Lakhin <[email protected]>
Cc: pgsql-hackers <[email protected]>
Cc: Masahiko Sawada <[email protected]>
Cc: [email protected] <[email protected]>
Cc: vignesh C <[email protected]>
Subject: RE: Slot's restart_lsn may point to removed WAL segment after hard restart unexpectedly
Date: Fri, 27 Jun 2025 02:22:27 +0000
Message-ID: <OSCPR01MB149666CB55DBC2170B1BA9F12F545A@OSCPR01MB14966.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <CAPpHfdvW1Cbo65UfWcO2uUCXnWosavL9f_UbNRAecTQH4o_RDA@mail.gmail.com>
References: <OS0PR01MB5716BB506AF934376FF3A8BB947BA@OS0PR01MB5716.jpnprd01.prod.outlook.com>
<CAFiTN-uGkrCDi9kqXJqLB+3ATn_ZULmRER73VhkLSDSAnO8SNg@mail.gmail.com>
<OSCPR01MB149660EB8A874AC3AE777C658F57BA@OSCPR01MB14966.jpnprd01.prod.outlook.com>
<CAFiTN-uiVOGwPNmDBPmLnC-86hX9-pKEYH2D_OKUmJd5RAUv=g@mail.gmail.com>
<CAPpHfdsbjXd_iXQwOTS3iioyEmuNz3HdQG8E8tHB0LodN=RXLQ@mail.gmail.com>
<OSCPR01MB14966C00587EEA20AA28718F1F57AA@OSCPR01MB14966.jpnprd01.prod.outlook.com>
<CAPpHfdvW1Cbo65UfWcO2uUCXnWosavL9f_UbNRAecTQH4o_RDA@mail.gmail.com>
Dear Alexander,
> Regarding last_saved_restart_lsn_updated, I think the opposite. I
> think we should check if last_saved_restart_lsn_updated is set already
> only if it could promise us some economy of resources. In our case
> the main check only compares two fields of slot. And that fields are
> to be accessed anyway. So, we are not going to save any RAM accesses.
> Therefore, checking for last_saved_restart_lsn_updated seems like
> unnecessary code complication (and I don't see we're doing that in
> other places). So, I'm going to push this patch "as is".
To clarify: I have no objections. Thanks for giving the knowledge.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
view thread (73+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: RE: Slot's restart_lsn may point to removed WAL segment after hard restart unexpectedly
In-Reply-To: <OSCPR01MB149666CB55DBC2170B1BA9F12F545A@OSCPR01MB14966.jpnprd01.prod.outlook.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox