From: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>
To: 'Michael Paquier' <michael@paquier.xyz>
CC: "'pgsql-hackers@lists.postgresql.org'"
	<pgsql-hackers@lists.postgresql.org>
Subject: RE: ReplicationSlotRelease() crashes when the instance is in the
 single user mode
Thread-Topic: ReplicationSlotRelease() crashes when the instance is in the
 single user mode
Thread-Index: AduBxJdn64KPa5CETf+apI8CWWnvvAAB/XMAAAIqX/A=
Date: Tue, 18 Feb 2025 07:29:51 +0000
Message-ID:
 <OSCPR01MB149669EF7D087A588773B7E04F5FA2@OSCPR01MB14966.jpnprd01.prod.outlook.com>
References:
 <OSCPR01MB14966ED588A0328DAEBE8CB25F5FA2@OSCPR01MB14966.jpnprd01.prod.outlook.com>
 <Z7QllLMq7UbyXHAD@paquier.xyz>
In-Reply-To: <Z7QllLMq7UbyXHAD@paquier.xyz>
Accept-Language: ja-JP, en-US
Content-Language: ja-JP
msip_labels:
 MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_ActionId=adb30552-e8a2-4863-bf93-3bca2f310de2;MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_ContentBits=0;MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_Enabled=true;MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_Method=Standard;MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_Name=FUJITSU-RESTRICTED?;MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_SetDate=2025-02-18T07:17:48Z;MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_SiteId=a19f121d-81e1-4858-a9d8-736e267fd4c7;
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=fujitsu.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: OSCPR01MB14966:EE_|OS7PR01MB14940:EE_
x-ms-office365-filtering-correlation-id: a44c83cb-4146-498c-061d-08dd4fee085f
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam:
 BCL:0;ARA:13230040|366016|376014|1800799024|1580799027|38070700018;
x-microsoft-antispam-message-info:
 =?iso-2022-jp?B?MEJyRFJVQ2VpV2d4N1Rja1NqQVFrK284QngyMng0MDdEQ2N3ZzNtSjY0?=
 =?iso-2022-jp?B?b0h4RkpIaWo4NnJSaTBJbVF4bTFLODgranJFVFlxZmZXak03WDM4bEtQ?=
 =?iso-2022-jp?B?SnA5eHFFb2xSVXpXY1VYZ0NwVG85a2lOM1Jodno4a3hkTHJzYTczNlhV?=
 =?iso-2022-jp?B?KzJZOWNxZVFXVnJxQnF3SkI4eGQxWUZEbjRaRFhNQmFyMWllZmcxbmRG?=
 =?iso-2022-jp?B?blRBSlZ1RmtQdjlwK2NUbFlJdHY1bCtwdGtVK0xXZ1BSK3FJbW91bFl5?=
 =?iso-2022-jp?B?WTArMVdmYVk5TVlGK1ZHMUtiYzUwVElvd2ttb3RFS00wYmh0Wk93b3Z6?=
 =?iso-2022-jp?B?ZjVkalZpQ1kvQWFINGNvMmZSMlpJSGpJRlFRbVFtelgzaVY3VExuUUc2?=
 =?iso-2022-jp?B?cXNWRkZ3dEQ0K2JtelEwZDhBdno0OTBxalB4YnJNbU80MkhzZGVNeGxt?=
 =?iso-2022-jp?B?VnowN0NtMGhveGEvVmtaZW9QVmJQR1p4a3YrNDVCQjJtZlVOb0FHVFox?=
 =?iso-2022-jp?B?cFhJUmRILzVkSHFNdnE3QVdVRVZHaCt2cU94U2g2TUVBWjJUTmoyMHJ5?=
 =?iso-2022-jp?B?Y09LWmdoVU51NnBYcGN4SERUS1lici9JNGI2VjVDdGRQcmhUV1pseC9j?=
 =?iso-2022-jp?B?Nm5hSWh1S2VONXJtWXJkb21rc1lyTEY3ZFdCaGE0RU5ZU0pvcXZ4ZXVo?=
 =?iso-2022-jp?B?YVZnMm4zSFRXeE82OTMyazNWZXlpMUdNSGhtSFUvUnloQmlwOGdhc29X?=
 =?iso-2022-jp?B?VGMrenpVM0MyUkpkemZHQkpoVWJvWUpvRUxoc254bW1oZWFzK0ltK2w2?=
 =?iso-2022-jp?B?QjZhdHRIQVp6dkN2a2k2MnJGTi9SaVcvMkV4ekVPVVAwSEx3WXM3Nm5Y?=
 =?iso-2022-jp?B?d2RNRDJDQkhqQWhDSVFnbktpcTk1MFZoTEVvaU9udGpEaTdQWGNtV3pX?=
 =?iso-2022-jp?B?blVlKyt3b1Y4WXY2WmFSakdPUVUvVURTTFRsdXBpcVJYMURMcVNoeWls?=
 =?iso-2022-jp?B?TUZyZ2xreEJZTUpzN0dNYTcyY0l3aEVoOE1nTGhUOUtaSzEzc2h1OHo0?=
 =?iso-2022-jp?B?U3IxWHUyUTNqeUFZZnBTUmxYZ1pKRTlDSW5VWVNIV0NRbStESCt1akVF?=
 =?iso-2022-jp?B?WTFOcThNbmVzMjBxZ3d6bFdCUzJoQ3FXYWpxQkpjSHpGOVA5ODZDUHU1?=
 =?iso-2022-jp?B?VStvOTBUOU1WYjU0VEVKNzhVdnNDVWpmeWJnWFduNlhuQTJrdnh2TzhU?=
 =?iso-2022-jp?B?RjJlK05ZanM1WFdIeGdHTnRwcS85M3pUV3J1bkM1VWJqaTh4cm1Xc1du?=
 =?iso-2022-jp?B?c2c4ai94S25BVS9LQVB4WmRFOExPUC8wTVZCbktwRStQa1Z1bldLcVRa?=
 =?iso-2022-jp?B?N1IrWVIyL0VuK1N5aWRobWtkclhFMWJqdFRYYk1EaFR4ajhhdXg4MU1Q?=
 =?iso-2022-jp?B?WGdyTU1wVjdMY0dCU3I5RWFvUXEvQndub2ozaS9aNXJlcU5WZ29ibUNC?=
 =?iso-2022-jp?B?dFYzRE9yWTJFSC9CVjZ6eW8vb25sUHArT1lHZmtqMjZNWUw1UWU2Z1Ra?=
 =?iso-2022-jp?B?OVRObkhlM1UvclJ2OG16S0NiaGFreWxJWWtHNzAwTHdEVi9JL3BKbyts?=
 =?iso-2022-jp?B?M2ZtVFhCbE9sTjh2TEVhYVVOZzBzZTU1RHBOTTNWVDVHYkYrbDYwWWFa?=
 =?iso-2022-jp?B?L1FGWjA3dE5BeGk3U2c1dVd3RlhDMFkwenJxZUp4S2RpOS9wc0lrdlQw?=
 =?iso-2022-jp?B?ODZrMHIyNzZhNm1SSi8xOFJXY3BtTmtyM1g4cmFZcDhod0d1NTYwZlNY?=
 =?iso-2022-jp?B?ZHBYMFV5LzdhOXRoMG5qdUJRejk2cEpTeWtCNDA1RGF6aWVOOW1kK20r?=
 =?iso-2022-jp?B?RDhKZjFyaDNsMHI5TEM0ZFFRYm1vdFE0aUlRQkN6cG9KQTRTdGlwV2E1?=
 =?iso-2022-jp?B?ZGZpZjNrVVJYOTk2Vk8vWVNheDZwMCtsY3JONHE1Y2EwMWliUkFDVXUy?=
 =?iso-2022-jp?B?QW5TbHFtYUtGUTR2QmFNdkNkVEorbGorYWhvREV0ei9LR3JSVEN0QTVS?=
 =?iso-2022-jp?B?MlE9PQ==?=
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:ja;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:OSCPR01MB14966.jpnprd01.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024)(1580799027)(38070700018);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?iso-2022-jp?B?Q0VONnBIUzJ4SS9RR2wxVlVyenc2cm00UWhVNDNTSHJDckEwWWZZaWZF?=
 =?iso-2022-jp?B?REVvV1VHS0lKZjZ1MXJBT3hoUmpXeTRnNkgzSzlIUEFNOHZpZDBJUUp2?=
 =?iso-2022-jp?B?cnhxc1FiM0dId1I4VHFyakNRNHNOT1I4L0c2Tjd2aHdtbVQ5M3dyZVox?=
 =?iso-2022-jp?B?anY4YVpaMFBsNG9wdHlNelNqNEJqYzVlcVZyZW9BV0dUTFhlbjRHM1Mr?=
 =?iso-2022-jp?B?aWYwVGRBWk1RZUlKK081WVhUb2JZbGU4U1dzQTMvUDJhOS8zam42M2F4?=
 =?iso-2022-jp?B?a09jd213eENqVnA1NVozL3dFa3F1ZUdvM01vcWU2a3h5WmlETSs5bHVN?=
 =?iso-2022-jp?B?R2J1UXdXK2Npd05RbTJLbXoyL0NoSEczaUFyWEdGUVUvZnlXQVFWcTh6?=
 =?iso-2022-jp?B?LzhQOWlPaDRFbkR1dWhTWnUvSU5zY2RVWTVBNnVCZjlIbnorZmRRUFJz?=
 =?iso-2022-jp?B?NDFuMnhJTis3WnhaVHhJcERJd0k2aXdqOFVHK2VXeVZBbEZkY0pIblhK?=
 =?iso-2022-jp?B?Z2RNd0VEN040U3VtU0h3S0VyRGNWUWI3Vzh5c3V0Si9HMW9xOUNiTTZH?=
 =?iso-2022-jp?B?SlNLZjkwdStTWHRDbHExb25RbUhNL2hFOTBwUHRyYktoYkxiVTgrTFdr?=
 =?iso-2022-jp?B?cGwyd2Q2ZmZyZzFDK0FYS3U5enBvZStCUS82VnBWOFE5bDNzRnJ3QVF4?=
 =?iso-2022-jp?B?Rkt3ZXRjTVQxY1U5R1V0SkNmU0c3SndrTEFqKzV0ZWZqNFU0RjhFbFkv?=
 =?iso-2022-jp?B?Y1hLeFJRQ2dxS2dwOTEzWFBuUGdwU21UVHVOaDRaclJXdU9iQXVKbG8y?=
 =?iso-2022-jp?B?UFB0Mi8xdFVQRnVOUVNFUTN2clZCdkRZWmlaeGpPbkgyaHJ0ZWpEak40?=
 =?iso-2022-jp?B?Rk5KemhIOG9DOUpJWTRVd1pLNHFmWThIWWZLcEgxZlA4eFRSR0FZcmlt?=
 =?iso-2022-jp?B?WGFMcm5FUHVVd28vTVdJWVU1cHVuS1lyWlRKMVNQTjRHOVloaWY3ZHJm?=
 =?iso-2022-jp?B?NmtNZFcvRTdkM2h5SU5BMHBlaHdYU25wZVI5OHdNNTM5NWpTK0ZEcnhz?=
 =?iso-2022-jp?B?dUtrd0NVQjgvSThhZEl2SFJ1M3Y4OG5ZcUNjZ2t5WHMxaVY1ZGUwMFpy?=
 =?iso-2022-jp?B?QStMY3RudDN4ejYzalQvSCtDdVJrY1dZOXFpampDNWFQQTdTQnZWdlRZ?=
 =?iso-2022-jp?B?aXVQdTZaSTdXYjNIT2J3dWliVWNqdWRHcldjYkF1RE83M0tSYUlsMEly?=
 =?iso-2022-jp?B?dGV3RVgxQlAvVHAxaUZnZWZnWHhucHlJNmpQeW9CakUvd2xqMU93LzdW?=
 =?iso-2022-jp?B?L2NTdmliWS9JUVAvRGtqcW5oQllZRGpQc21rd2VHUGMwUG9mT0gyZWhr?=
 =?iso-2022-jp?B?SEk0WTNOWDc4cS9YdVBVOHFSVmEwRExZajk2eFRSN05wTVhiVkdaa3Qx?=
 =?iso-2022-jp?B?RkM4QmhwelkzSW1tL0ZQQmRZMEcvY1NRcVE1ZzV0S25jN3UxRnhMSEtF?=
 =?iso-2022-jp?B?YTh0MW5DaktNZWV2WWRySzNvMmlWZStMTUcvREZ1QkxrYjRteHJUZjdX?=
 =?iso-2022-jp?B?N1hMc1pKazF0aHN6YU51NW5XdHRUSUJVVzhVL25QREo0N0hUZ092R1FX?=
 =?iso-2022-jp?B?ZjFlVFlPc2llRldCQkYyc3VmNWw1M2NWczV3amhNVW9RamtNOUdPQkp6?=
 =?iso-2022-jp?B?b01tcU9GSmFCODR6UE42QWZUdnQ4R1ZwRGNIZkJSeTdsTHRxNEhnQ1cx?=
 =?iso-2022-jp?B?bjNWRHcxKzN2QmZSVndNalF1TzhORndVRDVNalFUdDMzZ1NNOE41dzZL?=
 =?iso-2022-jp?B?S3NaRXRJVUVtZ2dmcFQ0dEErcWJIRjdMUmJseWpkaWlNaWlVL2oybVRH?=
 =?iso-2022-jp?B?V1puK21SSkNUYUlSOWtnYm9jaWFucjArOU5TYlV3UURaZkFhQk55a1Jj?=
 =?iso-2022-jp?B?N3VScmtCejFON01XK1RldXNoa2xERHdLNEU1MzJMS0lCR3FCV2lXQmln?=
 =?iso-2022-jp?B?Z3FONEZNRFR4amVLL3dlbkNXWUIxVjZlK2xqdFpQS3dwWXZSUmVOM1Yz?=
 =?iso-2022-jp?B?aTA3dFhmR29xZi9BbzY5ZEpManFpa1FlRGljRzJKMjk0WllIQ1NCd2sy?=
 =?iso-2022-jp?B?anI5a0lTZUY1TlpibTZFRHhXV05KZjQyYm1iU05qaG1RY0VtdkwvZkFh?=
 =?iso-2022-jp?B?Z3dqa01UYmVveThoNFd0a1NhY01DOVZwN0cwM3BadGNjSEoxeGJMbjhs?=
 =?iso-2022-jp?B?RC82K0s4T1BUQzg5UTZHdCtQemdyNmpVRldzUEdyS25JUTMralZYdk5P?=
 =?iso-2022-jp?B?ZyszMUIydDBWZEI0YXpzdWJtSmlLVGxsR1E9PQ==?=
Content-Type: text/plain; charset="iso-2022-jp"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0:
	mNXhZNFtbPteu0rY1G6jaBTO8OoDP02F85QZw/qWLmR/M4Vi/4Z0lFirT6sR4STQ9OGTu/jizaR633P6zlmtItUWe95t2Y7MZp+pMTTg+ie98TLMRr/UQwWnoSt8e2SSdC8RhF50MkDcn4kUUKzaUW65Vo0/ofxXE311Dzhb347F4b/wVPVp0+f7m34tUNDgiTMQrzWNNpBQAbYnzxOVurMNnwlHgWgOAGtbiEs4M7jonQQoWg5YiaWWGyIwc1OV+Hib7OQhZkhcMqCU7RANDA5Uz3HyI0ame8Ke4LcywEE5OdSxbo3ZQGskB1YXFi/aY0JQnxVB0meZXJ9qxayOfaJhkcbOP9wUE45R0csHQjDa2kSK7FWuTlSK1VgbGAPjUs6xeOAI1uLmAMdax7yk78NQZVcYyKknJWDgl0lttehxrTy+SXCWITi/ImaX6AXriMbNwgpExd24xZoK7e1AmXHNCACBo/pMWMrdWjg0nABu4yFL4UE9FZE1j7yzYeysYiyCTEd+dST2ftnUDW352ONo8T3sH3Yb6uJz+13J7mwkM/9TZdrTZauXQBxY+79i319QI94mK+h1aY7JcJoxHLvWaeMBPnNRrginvpgUgfxQ5orwNZpjAgz+PqHWhBnS
X-OriginatorOrg: fujitsu.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: OSCPR01MB14966.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a44c83cb-4146-498c-061d-08dd4fee085f
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Feb 2025 07:29:51.7463
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: a19f121d-81e1-4858-a9d8-736e267fd4c7
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 2FvzTCeqz0oUSW7I59xGUASZSOogto9EOfd/YZGJVXLPpUKUSQozBdn4XG4z8KuHvGot7CaWl6yz+X0G4sbCeJoVzHpzThR0sOGGSkavng8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS7PR01MB14940
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/OSCPR01MB149669EF7D087A588773B7E04F5FA2%40OSCPR01MB14966.jpnprd01.prod.outlook.com>
Precedence: bulk

Dear Michael,

> Perhaps a very naive question, but is there any point in authorizing
> manipulations of MyReplicationSlot in single-user mode, to begin with?
> With this remark, I would mean to apply a rule to
> ReplicationSlotAcquire(), so as all its callers would know about that.

According to the original thread [1], there was a wide consensus replicatio=
n-related
operations can be rejected, except the slot removal. I feel this is reasona=
ble.

Currently pg_drop_replication_slot() requires the droping slot can be acqui=
red,
so we cannot reject it in single user mode as-is. Maybe we should revive th=
e 0002
patch in [1] then try to do that. Thought?

[1]: https://www.postgresql.org/message-id/3b2f809f-326c-38dd-7a9e-897f957a=
4eb1%40enterprisedb.com

Best regards,
Hayato Kuroda
FUJITSU LIMITED