public inbox for [email protected]
help / color / mirror / Atom feedFrom: Hayato Kuroda (Fujitsu) <[email protected]>
To: 'Shubham Khanna' <[email protected]>
Cc: Shlok Kyal <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Cc: Peter Smith <[email protected]>
Subject: RE: Adding a '--clean-publisher-objects' option to 'pg_createsubscriber' utility.
Date: Mon, 3 Mar 2025 12:29:15 +0000
Message-ID: <OSCPR01MB14966C184318EA5F21823F9DFF5C92@OSCPR01MB14966.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <CAHv8RjK__mzyo0unKp2-ObxJh_Y43p5tG6p5e1HdNHDV+z=5sw@mail.gmail.com>
References: <CAHv8RjL4OvoYafofTb_U_JD5HuyoNowBoGpMfnEbhDSENA74Kg@mail.gmail.com>
<OSCPR01MB1496664FDC38DA40A441F449FF5EE2@OSCPR01MB14966.jpnprd01.prod.outlook.com>
<CAHv8RjJw2xDyWgagdAL7RBUEEEZtKcVJO_gNjQQHkUj8QrmwuQ@mail.gmail.com>
<CANhcyEUkQybOe=J5KypWQ80deULBLjjsdyP+DF57+BwSni57Vw@mail.gmail.com>
<CAHv8Rj+1v6257anqijp90f3cdZvSOhkm_ZRQRVU1C_0OYq056g@mail.gmail.com>
<OSCPR01MB1496679AD9C3C47DB30542ECBF5F12@OSCPR01MB14966.jpnprd01.prod.outlook.com>
<CAHv8RjJGjA_fwJ_TNrHbyTz7ATA1MXfNxPhoBvJfKRfk1Qf-ng@mail.gmail.com>
<CANhcyEXfn-TGW2L991vXAaGH-UVBCAZuDUSRFTyVTQPbDgamdA@mail.gmail.com>
<CAHv8RjKGywu+3cAv9MPgxi1_TUXBT8yzUsW+f=g5UsgeJ8Uk6g@mail.gmail.com>
<CANhcyEUo7F954LULk859xs6FtwQ5USH6C2tiBbGwpihU2yHmAQ@mail.gmail.com>
<CAHv8Rj+=5k_i=HJBE=615CckH6qi4B1n9jzhseKSH65MMkovNQ@mail.gmail.com>
<CANhcyEWSsx_kSY4o89Yv6UfHkTVB727OiExcB8944ez0EixJGw@mail.gmail.com>
<CAHv8RjJhwr7BqwFhMpcjjgYk9F-=MCx10LCiff9=7=vD-cj4GA@mail.gmail.com>
<CAHut+Pt9AidicguCX8b0etzP8_hy0RmAfgLR2wKC3cxeuz5E=w@mail.gmail.com>
<CAHv8RjLgLCbg-e0_5Ly_-8AojraV1R1g4BuaL-an7+iTLMycLg@mail.gmail.com>
<CAHut+PvwoLheTMkUgu_syf6cUR+-E62ChOZw9Aohq0i5soeaBw@mail.gmail.com>
<CAHv8Rj+zmkwunNubo+_Gp26S_qXbD=p+rMfEnPnjiEE1A6GTXQ@mail.gmail.com>
<OSCPR01MB14966189AEFD119DD04FE6B42F5C32@OSCPR01MB14966.jpnprd01.prod.outlook.com>
<CAHv8RjK__mzyo0unKp2-ObxJh_Y43p5tG6p5e1HdNHDV+z=5sw@mail.gmail.com>
Dear Shubham,
I did a quick check and have a comment in drop_publication().
```
+ /* For cleanup purposes */
+ dbinfos.dbinfo->made_publication = true;
+
```
Please do not modify randomly. Currently, made_publication is set to false when
the command fails. No need to set to true here - Please follow that. Also, please
do not remove comments within the if statement.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
view thread (76+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: RE: Adding a '--clean-publisher-objects' option to 'pg_createsubscriber' utility.
In-Reply-To: <OSCPR01MB14966C184318EA5F21823F9DFF5C92@OSCPR01MB14966.jpnprd01.prod.outlook.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox