public inbox for [email protected]
help / color / mirror / Atom feedFrom: [email protected] <[email protected]>
To: Peter Smith <[email protected]>
To: Amit Kapila <[email protected]>
Cc: vignesh C <[email protected]>
Cc: Alvaro Herrera <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Cc: PostgreSQL-development <[email protected]>
Subject: RE: Column Filtering in Logical Replication
Date: Mon, 5 Sep 2022 03:42:40 +0000
Message-ID: <OSZPR01MB631004818E8E3D397F8B2CD1FD7F9@OSZPR01MB6310.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <CAHut+PtrTTnwdyYUkZiz8UXhV_m_QEYKGWnTG2LN+P0P=29-gQ@mail.gmail.com>
References: <[email protected]>
<[email protected]>
<CAHut+Pt0xG2zPCDAp1MtUAgZ17gy5ODWsFPdJormwNz7qyZJ0w@mail.gmail.com>
<CAA4eK1KSmRSJO9H=gPT1p8NvvVTWaSQXk0CYL5v3WLwNMoSN4g@mail.gmail.com>
<CAHut+PuA3JPmE-Vc=SV7CwkcLYxmMXk-BJgoqNrPZbexaC5=Rg@mail.gmail.com>
<CAHut+PvOuc9=_4TbASc5=VUqh16UWtFO3GzcKQK_5m1hrW3vqg@mail.gmail.com>
<CALDaNm2briFD4+sT-JX_borfHQvbbmyRgTgpgj1m1RFE8p1ieg@mail.gmail.com>
<CAHut+PutfP6BxJxQSA8-VyeErZPT61B1Huuy-wy6c7hNjJRy0A@mail.gmail.com>
<CALDaNm16pVGx4w=cE3WiPVPj9BS267Q4bDZyB602jC1dD_ROvg@mail.gmail.com>
<CAHut+PtHgQbFs9DDeOoqqQLZmMBD8FQPK2WOXJpR1nyDQy8AGA@mail.gmail.com>
<CALDaNm3Q4fzTuJy_+04aHBAPDxerFpqpN7+AQtpy37jA2ScQ8w@mail.gmail.com>
<CAHut+PtJG4+0=WUMfNseUz7e7h3NffiOO8K+8Lv2GLob7vgvKA@mail.gmail.com>
<CAA4eK1Lc0sFXYvf0_kEBSqex=BkOiGkx9OJWZ41yq1ybFJeF0w@mail.gmail.com>
<CAHut+Ps2RgRGbjj90NGK3xuHgHOP5zD_fuRXMhGNVhLW0T_+zA@mail.gmail.com>
<CAA4eK1JuMVWPSCqVmA2-iexH4Rg=4qrMfRANXVgn9Jg3VUUnLw@mail.gmail.com>
<CAHut+PtrTTnwdyYUkZiz8UXhV_m_QEYKGWnTG2LN+P0P=29-gQ@mail.gmail.com>
On Mon, Sep 5, 2022 8:28 AM Peter Smith <[email protected]> wrote:
>
> I have rebased the remaining patch (v6-0001 is the same as v5-0002)
>
Thanks for updating the patch. Here are some comments.
1.
+ the <xref linkend="sql-alterpublication"/> will be successful but later
+ the WalSender on the publisher, or the subscriber may throw an error. In
+ this scenario, the user needs to recreate the subscription after adjusting
Should "WalSender" be changed to "walsender"? I saw "walsender" is used in other
places in the documentation.
2.
+test_pub=# CREATE TABLE t1(id int, a text, b text, c text, d text, e text, PRIMARY KEY(id));
+CREATE TABLE
+test_pub=#
+test_pub=# CREATE PUBLICATION p1 FOR TABLE t1 (id, b, a, d);
+CREATE PUBLICATION
+test_pub=#
I think the redundant "test_pub=#" can be removed.
Besides, I tested the examples in the patch, there's no problem.
Regards,
Shi yu
view thread (167+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: RE: Column Filtering in Logical Replication
In-Reply-To: <OSZPR01MB631004818E8E3D397F8B2CD1FD7F9@OSZPR01MB6310.jpnprd01.prod.outlook.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox