public inbox for [email protected]
help / color / mirror / Atom feedFrom: [email protected] <[email protected]>
To: Amit Kapila <[email protected]>
To: Önder Kalacı <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: RE: Dropped and generated columns might cause wrong data on subs when REPLICA IDENTITY FULL
Date: Thu, 16 Mar 2023 10:38:25 +0000
Message-ID: <OSZPR01MB6310A7627F4587CB5547086AFDBC9@OSZPR01MB6310.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <CAA4eK1+ZXLQLCKOwEzvpCJ2XXapANY66S773zMbqbUL_7LBUiQ@mail.gmail.com>
References: <CACawEhVQC9WoofunvXg12aXtbqKnEgWxoRx3+v8q32AWYsdpGg@mail.gmail.com>
<OSZPR01MB6310CE109F65A9B62A25CE1EFDB99@OSZPR01MB6310.jpnprd01.prod.outlook.com>
<CACawEhUCg-tRGzRqRq+qHaR+kPdZ=N1fP=A4_cCYd0LuNLUgnA@mail.gmail.com>
<CAA4eK1+ZXLQLCKOwEzvpCJ2XXapANY66S773zMbqbUL_7LBUiQ@mail.gmail.com>
On Thu, Mar 16, 2023 5:23 PM Amit Kapila <[email protected]> wrote:
>
> On Mon, Mar 13, 2023 at 6:26 PM Önder Kalacı <[email protected]>
> wrote:
> >
> > Attaching v2
> >
>
> Can we change the comment to: "Ignore dropped and generated columns as
> the publisher doesn't send those."? After your change, att =
> TupleDescAttr(slot1->tts_tupleDescriptor, attrnum); is done twice in
> the same function.
>
> In test cases, let's change the comment to: "The bug was that when the
> REPLICA IDENTITY FULL is used with dropped or generated columns, we
> fail to apply updates and deletes.". Also, I think we don't need to
> provide the email link as anyway commit message will have a link to
> the discussion.
>
> Did you check this in the back branches?
>
I tried to reproduce this bug in backbranch.
Generated column is introduced in PG12, and I reproduced generated column problem
in PG12~PG15.
For dropped column problem, I reproduced it in PG10~PG15. (Logical replication
was introduced in PG10)
So I think we should backpatch the fix for generated column to PG12, and
backpatch the fix for dropped column to PG10.
Regards,
Shi Yu
view thread (9+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: RE: Dropped and generated columns might cause wrong data on subs when REPLICA IDENTITY FULL
In-Reply-To: <OSZPR01MB6310A7627F4587CB5547086AFDBC9@OSZPR01MB6310.jpnprd01.prod.outlook.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox