public inbox for [email protected]
help / color / mirror / Atom feedFrom: Shinoda, Noriyoshi (PN Japan FSIP) <[email protected]>
To: Tomas Vondra <[email protected]>
To: Amit Kapila <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Cc: [email protected] <[email protected]>
Cc: Alvaro Herrera <[email protected]>
Cc: Justin Pryzby <[email protected]>
Cc: Rahila Syed <[email protected]>
Cc: Peter Smith <[email protected]>
Cc: pgsql-hackers <[email protected]>
Cc: [email protected] <[email protected]>
Subject: RE: Column Filtering in Logical Replication
Date: Sat, 26 Mar 2022 04:09:17 +0000
Message-ID: <PH7PR84MB18850A74D275F39762059E6CEE1B9@PH7PR84MB1885.NAMPRD84.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
<CAA4eK1JJ5qgqbjfYQU9F4R1+OABxec-DQechQXus0fanDjaAVg@mail.gmail.com>
<OS0PR01MB571614E4A39DD33669D5AFD6940A9@OS0PR01MB5716.jpnprd01.prod.outlook.com>
<[email protected]>
<[email protected]>
<[email protected]>
<CAA4eK1J9UDnM-xN7viu4eO_DDL_PqMG9F6ZsskqEU7snujXi+A@mail.gmail.com>
<[email protected]>
<CAA4eK1KUpOnFam+2bBuGGX-_pZbmO_ShJV6G=GT-RyM7gQSvWg@mail.gmail.com>
<[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<CAA4eK1LahG9b8zxOjgC-KeMETYMA=aDZM4-Y0GB9M4cUGOgmwA@mail.gmail.com>
<[email protected]>
<[email protected]>
Hello,
The 'prattrs' column has been added to the pg_publication_rel catalog,
but the current commit to catalog.sgml seems to have added it to pg_publication_namespace.
The attached patch fixes this.
Regards,
Noriyoshi Shinoda
-----Original Message-----
From: Tomas Vondra <[email protected]>
Sent: Saturday, March 26, 2022 9:35 AM
To: Amit Kapila <[email protected]>
Cc: Peter Eisentraut <[email protected]>; [email protected]; Alvaro Herrera <[email protected]>; Justin Pryzby <[email protected]>; Rahila Syed <[email protected]>; Peter Smith <[email protected]>; pgsql-hackers <[email protected]>; [email protected]
Subject: Re: Column Filtering in Logical Replication
On 3/26/22 01:18, Tomas Vondra wrote:
>
> ...
>
> I went over the patch again, polished the commit message a bit, and
> pushed. May the buildfarm be merciful!
>
There's a couple failures immediately after the push, which caused me a minor heart attack. But it seems all of those are strange failures related to configure (which the patch did not touch at all), on animals managed by Andres. And a couple animals succeeded since then.
So I guess the animals were reconfigured, or something ...
regards
--
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachments:
[application/octet-stream] prattrs_column_fix_v1.diff (1.9K, ../PH7PR84MB18850A74D275F39762059E6CEE1B9@PH7PR84MB1885.NAMPRD84.PROD.OUTLOOK.COM/2-prattrs_column_fix_v1.diff)
download | inline diff:
diff --git a/doc/src/sgml/catalogs.sgml b/doc/src/sgml/catalogs.sgml
index 560e205..94f01e4 100644
--- a/doc/src/sgml/catalogs.sgml
+++ b/doc/src/sgml/catalogs.sgml
@@ -6291,19 +6291,6 @@ SCRAM-SHA-256$<replaceable><iteration count></replaceable>:<replaceable>&l
Reference to schema
</para></entry>
</row>
-
- <row>
- <entry role="catalog_table_entry"><para role="column_definition">
- <structfield>prattrs</structfield> <type>int2vector</type>
- (references <link linkend="catalog-pg-attribute"><structname>pg_attribute</structname></link>.<structfield>attnum</structfield>)
- </para>
- <para>
- This is an array of values that indicates which table columns are
- part of the publication. For example, a value of <literal>1 3</literal>
- would mean that the first and the third table columns are published.
- A null value indicates that all columns are published.
- </para></entry>
- </row>
</tbody>
</tgroup>
</table>
@@ -6375,6 +6362,19 @@ SCRAM-SHA-256$<replaceable><iteration count></replaceable>:<replaceable>&l
representation) for the relation's publication qualifying condition. Null
if there is no publication qualifying condition.</para></entry>
</row>
+
+ <row>
+ <entry role="catalog_table_entry"><para role="column_definition">
+ <structfield>prattrs</structfield> <type>int2vector</type>
+ (references <link linkend="catalog-pg-attribute"><structname>pg_attribute</structname></link>.<structfield>attnum</structfield>)
+ </para>
+ <para>
+ This is an array of values that indicates which table columns are
+ part of the publication. For example, a value of <literal>1 3</literal>
+ would mean that the first and the third table columns are published.
+ A null value indicates that all columns are published.
+ </para></entry>
+ </row>
</tbody>
</tgroup>
</table>
view thread (185+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: RE: Column Filtering in Logical Replication
In-Reply-To: <PH7PR84MB18850A74D275F39762059E6CEE1B9@PH7PR84MB1885.NAMPRD84.PROD.OUTLOOK.COM>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox