Date: Fri, 25 Mar 2022 23:43:17 +0000
To: Rachel Heaton <rachelmheaton@gmail.com>
From: gkokolatos@pm.me
Cc: Justin Pryzby <pryzby@telsasoft.com>, Greg Stark <stark@mit.edu>,
 Postgres hackers <pgsql-hackers@lists.postgresql.org>
Reply-To: gkokolatos@pm.me
Subject: Re: Add LZ4 compression in pg_dump
Message-ID: 
 <PSMV5cBDnG2Wd93aYAyTE9RxCPpO0K7ZZQezDkqxwrDTrnp0R8fokD3N8JcmxmuHqAI4cRp_vMmPSUu1igCtaZfk-rLwoSWuBoFiCcRl8WQ=@pm.me>
In-Reply-To: 
 <CADJcwiUbfBV0oNNpKvd2H4kP7m2U+7SmL-GAGO8Uv5H3HZUbAw@mail.gmail.com>
References: 
 <faUNEOpts9vunEaLnmxmG-DldLSg_ql137OC3JYDmgrOMHm1RvvWY2IdBkv_CRxm5spCCb_OmKNk2T03TMm0fBEWveFF9wA1WizPuAgB7Ss=@protonmail.com>
 <20220304161039.GL27651@telsasoft.com>
 <CAM-w4HNr=THV3WQoeUPs5jefY8zcXtZJQ5pjWjUAsSpDtEeCaw@mail.gmail.com>
 <20220325132253.GD28503@telsasoft.com>
 <CADJcwiUbfBV0oNNpKvd2H4kP7m2U+7SmL-GAGO8Uv5H3HZUbAw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/PSMV5cBDnG2Wd93aYAyTE9RxCPpO0K7ZZQezDkqxwrDTrnp0R8fokD3N8JcmxmuHqAI4cRp_vMmPSUu1igCtaZfk-rLwoSWuBoFiCcRl8WQ%3D%40pm.me>
Precedence: bulk


------- Original Message -------

On Saturday, March 26th, 2022 at 12:13 AM, Rachel Heaton <rachelmheaton@gma=
il.com> wrote:

> On Fri, Mar 25, 2022 at 6:22 AM Justin Pryzby pryzby@telsasoft.com wrote:
>
> > On Fri, Mar 25, 2022 at 01:20:47AM -0400, Greg Stark wrote:
> >
> > > It seems development on this has stalled. If there's no further work
> > > happening I guess I'll mark the patch returned with feedback. Feel
> > > free to resubmit it to the next CF when there's progress.

We had some progress yet we didn't want to distract the list with too many
emails. Of course, it seemed stalled to the outside observer, yet I simply
wanted to set the record straight and say that we are actively working on i=
t.

> >
> > Since it's a reasonably large patch (and one that I had myself started =
before)
> > and it's only been 20some days since (minor) review comments, and since=
 the
> > focus right now is on committing features, and not reviewing new patche=
s, and
> > this patch is new one month ago, and its 0002 not intended for pg15, th=
erefor
> > I'm moving it to the next CF, where I hope to work with its authors to =
progress
> > it.

Thank you. It is much appreciated. We will sent updates when the next commi=
tfest
starts in July as to not distract from the 15 work. Then, we can take it fr=
om there.

>
> Hi Folks,
>
> Here is an updated patchset from Georgios, with minor assistance from mys=
elf.
> The comments above should be addressed, but please let us know if

A small amendment to the above statement. This patchset does not include th=
e
refactoring of compress_io suggested by Mr Paquier in the same thread, as i=
t is
missing documentation. An updated version will be sent to include those cha=
nges
on the next commitfest.

> there are other things to go over. A functional change in this
> patchset is when `--compress=3Dnone` is passed to pg_dump, it will not
> compress for directory type (previously, it would use gzip if
> present). The previous default behavior is retained.
>
> - Rachel