From: Japin Li <japinli@hotmail.com>
To: Chao Li <li.evan.chao@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Use SMgrRelation instead of SMgrRelationData * in
 pgaio_io_set_target_smgr()
In-Reply-To: <96EB95E4-9032-44A6-A397-153256AA5E4D@gmail.com> (Chao Li's
	message of "Fri, 13 Mar 2026 15:29:31 +0800")
References: 
 <SY7PR01MB10921D0F6F3C2682570D6C31BB645A@SY7PR01MB10921.ausprd01.prod.outlook.com>
	<96EB95E4-9032-44A6-A397-153256AA5E4D@gmail.com>
User-Agent: mu4e 1.12.12; emacs 29.3
Date: Sat, 14 Mar 2026 11:07:02 +0800
Message-ID: 
 <SY7PR01MB10921122C8059E98C4923FE1CB642A@SY7PR01MB10921.ausprd01.prod.outlook.com>
Content-Type: multipart/mixed; boundary="=-=-="
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SY7PR01MB10921:EE_|SY4PR01MB8343:EE_
X-MS-Office365-Filtering-Correlation-Id: a4ef8b12-a3e9-45f2-1b5f-08de8176c692
X-Microsoft-Antispam: 
	BCL:0;ARA:14566002|19110799012|8060799015|15080799012|22091999003|6092099016|24121999003|12121999013|23021999003|461199028|5072599009|40105399003|52005399003|440099028|3412199025;
X-Microsoft-Antispam-Message-Info: 
	=?utf-8?B?RUVjMjlWU2c4MjAyVFB4dlAxWk1vMmdpM0xOQnF5enB4bEVYZWwwUGdoLzhy?=
 =?utf-8?B?dENnbDZkU3RjQkZlRWdWLzArS2U0TEdjcGNaM1A5bnlLdzJ4aDFzMCt1NnRi?=
 =?utf-8?B?VUp0VGJUL0YrdEMyV1pyK1g4dWZzU0lYSXBuQldKOGZ5UWhHWk4yUE0xRUtG?=
 =?utf-8?B?WG9TVlI5QkZpR3lnQk9CUDZDNTFUUE5ob2tWTXZvdU5IRU0xbURDcUh1VWV4?=
 =?utf-8?B?R0tSWFBxTElqK0JDSnIxZVgvUUdZNS9lZDI4anVCT2pGQWJOYjZCMWo0cjBp?=
 =?utf-8?B?RlhVbkRRbXk4cmNwbUVkc21rMGUra1lvVUdMc016WUlUNTJmYnFMa0ZaNEV3?=
 =?utf-8?B?QVFhUlpRV0E3SU94L3R6MzdqQnEyRHFGUHhEZEJOcStCUFJRbis3SHB6c214?=
 =?utf-8?B?amJtckZ4Tll3bzJYRGRqaklCMUdqWmxmSis5RVNTNDJhUmc3NEsvTjcvVnB4?=
 =?utf-8?B?U2xSVEUxcmYyYUxNS2VrY0VlVjNnWUpBTUZCQm9zUDZKdk5vYStPc3JBN3Mv?=
 =?utf-8?B?UWVEdHE3Snh5Nk1sSk1NSll3Nm5iSzBZV0V0TTluZzlIY1JUSmZ2cU1sa28v?=
 =?utf-8?B?OElVbFBCYy9jdXdlcGdxMHkrTTFIRzZhbFRZRzdJd0RpME11dmZ6Y2VDQ2p0?=
 =?utf-8?B?cTNPMWlid1pWOVgrY0ZZRnhHTlFrZjAva3l1TE0yTXhuUWFMYlNETGdzZnNP?=
 =?utf-8?B?cy9zS244TFlrZTVCbHBkWGx3NlI5STRTTGl1cU4vUk8wT0t2YnJWWDFhSnpS?=
 =?utf-8?B?VzZSbUZsZ2hhdDZBRzdhbVFqSGFvSHljQkxqaTJzMlk2S3lGQXc3bDY0aDAv?=
 =?utf-8?B?ZE1WeTEvZ3M2ckJhOGUvQlJhcCt0eWpkVlRXa1JIc2hnc3U4OVB3OWIzNTNw?=
 =?utf-8?B?aFRUZzZtM282bnhnMWZFM2J3ZUljNG1FUTVNYi9yTS9ZMEpzdDAwMSsraElK?=
 =?utf-8?B?OURnN0ZpR0x4MnBvc0xscFd6emhaNUE3NlUvbksweW9Meks2NjgrTjRuaHdZ?=
 =?utf-8?B?cWtWRE5KU2thM3o1dEl6OEFLaldLZ2ttQVBrTkJrTFJqS3FCZUhUaWxWK0Q4?=
 =?utf-8?B?VFFHZDRId25oRDU2eGxUZXEwNGdDK2w2TFJPOXlPUnhGWHNzTG9vV3FrOERN?=
 =?utf-8?B?WUZUWVIrZHZxbTBvbHltS3cyQUJCcExDVzM5VDNXeGI2bkorL3ZlUG1vZnhY?=
 =?utf-8?B?YkZPQjYzMTRDNnFqM0UydklWaVJLVEtLVHhxRU1mMWxCSmk4Ti8zS0sweS9H?=
 =?utf-8?B?bmpiYjdIU1ZwNTBnbkxEUWo0NUxONmlnTUJISnRyUUVjSHIzdnJaTUlXRk1D?=
 =?utf-8?B?ZGM2OWlOZTdFaGZQUzlXdTFqS3RwRFVBUHFZVVZLbWdOTEdYMmJTM0svbUZG?=
 =?utf-8?Q?lQc2qj8Iy9v1wmRYpkgMIsVu+MhC/HbM=3D?=
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?YkRZV3VnRE9CbTFsbTJ6OVJyUEN3RHFzcVppSnBwYUEwaUxPUUxXdkdCRmFL?=
 =?utf-8?B?OG53L3dIL1dFdVZhdGNOWnd0SlZPSFQvUUhyY3NTODFjWG5hbUlNbSt3cURr?=
 =?utf-8?B?eXJHa3U3MUNIYUNsTUxKZmV5RS9IV0FuWWVOSC9RcG5PV1BJaXI1QjNGWnht?=
 =?utf-8?B?Sys0V1ZRZUh3QXEvZlNncUhWL3FIN3p5M0tqWGVwN3NyQ1Y3U1EzRHdCazdk?=
 =?utf-8?B?Z000SitFTU80dEROelF1NE5lUHp2aDVNRXRqWlhUcmtIUGpEMTV3OExZZkNO?=
 =?utf-8?B?ZzNQcDluOU1yLzhVQnJkU0dQYU50bXpIemlLbDFFblZhK0d4V09WRWE5ek1W?=
 =?utf-8?B?N2NlbFFDZ0VzR084aE5iNUhpVVVaR1hIRTZyRE5UUURSR1RGNG9Makk2U3o2?=
 =?utf-8?B?MXR5Q010YTFtWEQ3ZVYrbm1saWdYaWh1ME1JRzlZcU55UFdBZmx3YTcwRlhy?=
 =?utf-8?B?Z3lqRlRmUlE5SkZYcWtSa1hhQi8xS0d0YlVna1lkcW54bDNyaGwzY21KdDhw?=
 =?utf-8?B?NHZuSmRzZEJETC80cWdRcUdwdmdOeklNU25VcEZmY0NkbVp6Zy9XbDJaLzdz?=
 =?utf-8?B?WGtSKy9DNmxmOWlscE1EK3I2QTFFazJOTVJ2MGp6V1FDdXg0MnhnamFUbzRQ?=
 =?utf-8?B?bG9iU3JuOGF1S0o5MjI3OFg1Y3psMnpidFdOUXRhdVF6dnE1UW43QTVEMHVN?=
 =?utf-8?B?MGtiR1dsTEZ5Nm9MMDlPQkUvNXorUFQvUjVTNEMvdGJTeEh2NEtqTWdMZlZa?=
 =?utf-8?B?KzkzSFVtR0VnbW1iUERON2MxWlIwcEJSejZJbEg2RGk3VEdVZVVydk4xcDdK?=
 =?utf-8?B?cXN0R3NFUDZxTHJhZ2NmaXJDOGlOZzJWU1k0NUhYcC9ic0VlMFRoZTg4Q3Vx?=
 =?utf-8?B?K2ZYeWJJc1N3TVhRcEZVMG5pTVJHZlJ5TERZd2taakF6dkJ4cUxoU3F5aUdx?=
 =?utf-8?B?bkJRazNxRmlNbzdhNVBXeUxUenhuNS9SSDFJSEtxYUN1eTQycFBEQzVWdGRy?=
 =?utf-8?B?dzVpdTdVTVpWL3cySklJeEI2a0FPM2Zxa2dBeE9vUWtWK1ZqZC95bkI0VFZD?=
 =?utf-8?B?anVnQWQ5YmlnMzlQa0Y4dXpidWU4c2llTVBuMDVjYjdndnIzNTEyUjNUekdU?=
 =?utf-8?B?dzhnZFF0enNvWUV2M2l0dVhEMjNFYkZ1VStLMkNOUUZxblhvV2JvYVdZdS93?=
 =?utf-8?B?THJ6RGJCbGRJTmJGL0FUYTZCNEs1MkFka0dpVElXWFJvbWtJbFpweWVZcThD?=
 =?utf-8?B?d2pJdGVFV3NlZ0VZd2FQMTR6ZEQrb0c5aDIzeGFTOUUza3ZTU3RWODNKWHUx?=
 =?utf-8?B?SkpTYmFQUlZCTzAvRTVib3g3SnVLeWZ2MHBkRTdaZHpnZG52NmtwNXJUeC9W?=
 =?utf-8?B?eWswYm9uVUgvMDhUYXZnVkI3MEhELzNIY3B3bTl6TCtWeWFIU1QzVDlrWjdG?=
 =?utf-8?B?dUNUMEM4ZVFqM0JJMFRrVWpjSkQxR1NiUkxubjdNSktqNUdoZnI0SGU2dEtp?=
 =?utf-8?B?bFV2elRncHpSQ0ZveVplcUpsb3pwZTJqVS9qVjkzVDNveVdBZXplQlpuaU16?=
 =?utf-8?B?Q1p5MnNKa200RVExb1B5dFJiR09TMFlzcllJeC9RaXlkQkV1bUM5VDREcnZw?=
 =?utf-8?B?Zm9mUTlic3NDLytsVEFuaXdRaVphOFZrTS90c21PRUtUeVNzdG1sV092R2hj?=
 =?utf-8?B?ZWMrbDFsTkZHSGlTNWNXa1VFeVhQSjZJVjViYUlpUlN0dUwrYTZLNmJrbmVK?=
 =?utf-8?B?NFZCS2Ivbml2TkZhV1lUSFdQaFNCQ2NGM3MwbHF4V3phdWxXSTUyU1RXdmty?=
 =?utf-8?B?cFZaV2MyUkcwS1RMSFNobWFJT3JKUmdNNExZTHRVRWRJaFdrUExrWGtUS0ZF?=
 =?utf-8?Q?gp4bVpaIUXW9M?=
X-OriginatorOrg: sct-15-20-9412-4-msonline-outlook-feddd.templateTenant
X-MS-Exchange-CrossTenant-Network-Message-Id: 
 a4ef8b12-a3e9-45f2-1b5f-08de8176c692
X-MS-Exchange-CrossTenant-AuthSource: SY7PR01MB10921.ausprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2026 03:07:07.2621
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SY4PR01MB8343
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/SY7PR01MB10921122C8059E98C4923FE1CB642A%40SY7PR01MB10921.ausprd01.prod.outlook.com>
Precedence: bulk

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


Hi, Chao

On Fri, 13 Mar 2026 at 15:29, Chao Li <li.evan.chao@gmail.com> wrote:
>> On Mar 13, 2026, at 15:05, Japin Li <japinli@hotmail.com> wrote:
>>=20
>>=20
>> Hi, hackers
>>=20
>> While reading smgr.h, I noticed an inconsistent type usage in
>> pgaio_io_set_target_smgr(). Currently the function is declared as:
>>=20
>>    extern void pgaio_io_set_target_smgr(PgAioHandle *ioh,
>>                                         SMgrRelationData *smgr,
>>                                         ForkNumber forknum,
>>                                         BlockNumber blocknum,
>>                                         int nblocks,
>>=20
>> However, SMgrRelation is defined as "typedef SMgrRelationData * SMgrRela=
tion;",
>> and all other functions in the smgr subsystem use SMgrRelation as the pa=
rameter
>> type.
>>=20
>> To keep the code consistent with the rest of the smgr API, this patch ch=
anges
>> the parameter from SMgrRelationData * to SMgrRelation in both the defini=
tion
>> and declaration.
>>=20
>> This is purely a style/consistency cleanup with no functional change.
>>=20
>> Thoughts? Is this change acceptable?
>>=20
>> --=20
>> Regards,
>> Japin Li
>> ChengDu WenWu Information Technology Co., Ltd.
>>=20
>> <v1-0001-Use-SMgrRelation-instead-of-SMgrRelationData-in-p.patch>
>
> pgaio_io_set_target_smgr doesn=E2=80=99t update smgr, so, instead of =E2=
=80=9CSMgrRelation=E2=80=9D,  I think it=E2=80=99s better to change the typ=
e to "const SMgrRelationData *=E2=80=9D.

Thanks for the review! Makes sense =E2=80=94 I've updated the patch to v2.

--=20
Regards,
Japin Li
ChengDu WenWu Information Technology Co., Ltd.


--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
 filename=v2-0001-Use-SMgrRelation-instead-of-SMgrRelationData-in-p.patch