From: Japin Li <japinli@hotmail.com>
To: "Euler Taveira" <euler@eulerto.com>
Cc: "Amit Langote" <amitlangote09@gmail.com>,  "Lakshmi N"
 <lakshmin.jhs@gmail.com>,  "pgsql-hackers@lists.postgresql.org"
 <pgsql-hackers@lists.postgresql.org>,  "Andrew Dunstan"
 <andrew@dunslane.net>
Subject: Re: Reject invalid databases in pg_get_database_ddl()
In-Reply-To: <976a432b-9221-4825-8e8f-41f4375737fe@app.fastmail.com> (Euler
	Taveira's message of "Thu, 16 Apr 2026 22:46:51 -0300")
References: 
 <CA+3i_M8m1k2gFch+tU0JmAQh9FRV+pFrfTXDrJo+BqmwsTmOhg@mail.gmail.com>
	<CA+HiwqH+0rgMNQDog0AT9dVt0CGjXza_Li80njDhynWqzUwvZw@mail.gmail.com>
	<CA+3i_M8Mq7fr6mUspSa2rLik9+oY4sOeD1qsB_-dvnUB4NrYbg@mail.gmail.com>
	<CA+HiwqFW7uY3Jknf8VzjWoXa1bf0-U6-+JgM+o1ggJ+onyOHHA@mail.gmail.com>
	<976a432b-9221-4825-8e8f-41f4375737fe@app.fastmail.com>
User-Agent: mu4e 1.12.12; emacs 29.3
Date: Fri, 17 Apr 2026 10:30:44 +0800
Message-ID: 
 <SY7PR01MB10921A7CBE85FBD6C670BB5F4B6202@SY7PR01MB10921.ausprd01.prod.outlook.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SY7PR01MB10921:EE_|ME3PR01MB5575:EE_
X-MS-Office365-Filtering-Correlation-Id: 5f018be2-9fcb-49a1-752c-08de9c295691
X-Microsoft-Antispam: 
	BCL:0;ARA:14566002|24121999003|22091999003|8060799015|19110799012|23021999003|15080799012|5072599009|461199028|40105399003|53005399003|440099028|3412199025|26121999007;
X-Microsoft-Antispam-Message-Info: 
	=?us-ascii?Q?vmmN5Fm7avv/oBAMKYlnnT2OEIscfgwO4LNjsSjPPEFjHHzpADE1LkrHxgyz?=
 =?us-ascii?Q?7iDNjXEVHfYVi8LZPqBzB0ihpgjyWsWmRQR51VOk2E7RRW3LIwiGFkOAMRPj?=
 =?us-ascii?Q?j0H+f+f0Ubx22jQQjtRRcSlXdLrw3LvY+c3FHujkv0OHW73AJNylL9ucacuK?=
 =?us-ascii?Q?7U9GouzAmcmLUiJjPnM9TG/I+GufZShZ9igYi1HmtjYDhg6WP5pvmsPJ4zvO?=
 =?us-ascii?Q?F4AtAiB59iiQmcNMSGeoArdF6gzxqpkUu9jF53EhiTi1OWPhs3aK9FoxZHhR?=
 =?us-ascii?Q?jjqwrmdWUlabhK/AKSr3XwRWdRqnM1G0BvxQ69rJzurMoKBNZ/PJ94PZ8xiH?=
 =?us-ascii?Q?32fuN1dUxalOhuDQlQduwuDAyX6RV4dtihE1niiUaBYF4iKVNm5zQ3gk6sJt?=
 =?us-ascii?Q?EHfq/xMi4qVHbUIcNqiSTTslYbpvWb7iUify6QnRH5hPKY2WPy3gD6efrDQk?=
 =?us-ascii?Q?n0fcGIqNA0NwScx/tu4TNltOvXwz0MhFuIYFveYgN3CTCltJJ8rebwsnq/cB?=
 =?us-ascii?Q?RZiQqT9f90SRXDA7VQ/o/CbsRcszhXDZiNkeMmi9+TkgUodg+b60o+c4RlgT?=
 =?us-ascii?Q?j0IyTjfLj5kQzYH3qO99vMb4YYLOEy+dK9qRhnjD9YAaeZ7RN5eR9Zi/Io5R?=
 =?us-ascii?Q?TSRvhLgPC1j5vRqKfJFWgjUiHe5KqkHPMXLp11SgtDTRNChBGx9H+X81iz9v?=
 =?us-ascii?Q?xW09NAKdydoCBMNvYwgmuDYIRQi5rZbaP8YjWdPMvPijPwNmvO0vRbGHkCjE?=
 =?us-ascii?Q?HomW/ecAzn6vDsoiSAeYd1s3SBf8hd7AtBuOr3wxVEzyL+IXOXk6FkQmdzQR?=
 =?us-ascii?Q?ZGySkXz8zH06ihwR6IxcOXbs9L8DZnr+R2hJT1vcm+nTqU+0jFmv0HrOxQV9?=
 =?us-ascii?Q?H8MF1mBPQG4BLBQNTm7fMHIRwYI/I/h/U99NAEhtaILrVTBVPkrbsFGdbjHf?=
 =?us-ascii?Q?KEh9erzky0GPrwfYKBxMDcNvEPEOnRkSCoehiS1iDuN6CfscrLhbarjo7gwD?=
 =?us-ascii?Q?YcO4?=
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?Z6rr6Mbu/iECcE3NOScl8CAHCLwOGhSmxsF2m3FAz1K0VVbtGwbpt1MEPt62?=
 =?us-ascii?Q?SXvBPKj5AjD/MZtEII7xW+l6EqqV5TFNZzP2hkQNfPhl+T6idN5Z8bpjhNus?=
 =?us-ascii?Q?EHbsRJnti6efNfzcOa+Vm7D3nAgqx4X+Ptbhqnp3PpQ/YpnnP+eDlJInLyyh?=
 =?us-ascii?Q?UyUK9g98CIoIR8ilLPDkqMh6KFIwbpFQSVptWaGUDG7s1+W/12Km0tyzj8SV?=
 =?us-ascii?Q?tJ7WJ8AVfHiJ7itvNFsa7bMUggGZ49E60fKQcB8jP/Zydtrl4jSdq0PQYQ3W?=
 =?us-ascii?Q?HwHSuTLWj4FC/PWtnMHDsPVlV9F2EPgioPqVEwPokoHlzv3rbFwcavlJzPbA?=
 =?us-ascii?Q?IJnuAOJsWAvoH52/VsoOgxy/qldDEERXuI7bCCLhn36pdTaF26l1lSGMxgWX?=
 =?us-ascii?Q?B/RykoaFaIq+m+50Vm3icgxn3o1DOFRHkhn/YvEyxvkUHv4G/wOPhcZJkXjc?=
 =?us-ascii?Q?xtaAhIhmZFhN2VE79GuPal3BuniwvC7O0mcsYKC0Joebc9IJxGgJcoBcup03?=
 =?us-ascii?Q?A1Mu0RXpUdGB3Aio78Zz0TTZzc8AS6a/Cf/O8d9IoQe7b9wecCyQJW+MR+4U?=
 =?us-ascii?Q?ewxJQWeUACRV6b6OQ/t43RnjRHQ2HYBLBcGcEwWOfN8E/UXvJo+GSZP2V458?=
 =?us-ascii?Q?CunBy6HPRYekGr+xS+MY07suZfFGBvZJ4Y4Y51N4yACEb2h6BMgNCcguklXd?=
 =?us-ascii?Q?SM1SXzXvhBAo7+C1cqtCUiZvy6Y4yWyd+UvqNa3ssXyNd9Tqfe4+VwzWhLhR?=
 =?us-ascii?Q?U9rCzC1beWPCt3o1an8DFk6jyT6cXJxbKqyvAsQ2lXsW8MhmFizPgyzqMAjj?=
 =?us-ascii?Q?GbrrDX/AAC50K0ILQfK/5CXnhWFKN2vLOfEWbhB2Mubu09mRdpE9u/6JSCdj?=
 =?us-ascii?Q?TglQW+zyDPghkEvPVIV3yT6rvngMxXHAMAw1BW9uBu/DrSqmKtistHWhjIZz?=
 =?us-ascii?Q?Wici6IzQMvx4jxzrNZ73Hc5twTbNLLmaxuyln094JIGDqTaU/TJcfQxl+YIi?=
 =?us-ascii?Q?SpvlV9C8eaUc3YPi6BpvjUMR0Foky3nO/RoGacaCkDyVNHpsCy9KClKK55WD?=
 =?us-ascii?Q?5HyiG8BX5j35uxsGtfIHoGONfeI29+ccvOVyS4OoyAP98Yu737UuXRCkeFXs?=
 =?us-ascii?Q?1vGRPnzgz+Z6feqKUGHf5pdUNf2VOdxM2VJ4hTmSm6CgrUSRgbll1U1nL/sV?=
 =?us-ascii?Q?0hQjIHnzqtIiVbWQQIk8a6opOvjiBi0SPzfpNiYW+HmM43TRDY8Qh0VUnHPo?=
 =?us-ascii?Q?Ei7S1hkWAq17Qcf/J8fkA8XGXkxJ5zpkw3vPBNLKO9XQQeDuz4MEHpfnP1Ec?=
 =?us-ascii?Q?fJIW9uXenXjqIBm/2JYgiEyr0HeAv+fJEzixAj5Y1N0KdguUiz+gJK2Lcv1g?=
 =?us-ascii?Q?A3EGuglUTbfoS3z9j/PvBjaYgUCW?=
X-OriginatorOrg: sct-15-20-9412-4-msonline-outlook-feddd.templateTenant
X-MS-Exchange-CrossTenant-Network-Message-Id: 
 5f018be2-9fcb-49a1-752c-08de9c295691
X-MS-Exchange-CrossTenant-AuthSource: SY7PR01MB10921.ausprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Apr 2026 02:30:49.4714
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: ME3PR01MB5575
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/SY7PR01MB10921A7CBE85FBD6C670BB5F4B6202%40SY7PR01MB10921.ausprd01.prod.outlook.com>
Precedence: bulk

On Thu, 16 Apr 2026 at 22:46, "Euler Taveira" <euler@eulerto.com> wrote:
> On Thu, Apr 16, 2026, at 8:46 PM, Amit Langote wrote:
>>
>> Thanks.  Will push the attached shortly.
>>
>
> I think the errhint() is excessive in this context. It makes sense if you are
> executing ALTER DATABASE, for example. I suggest a message like
>
>   database \"%s\" is an invalid database
>
> Regarding the test case suggested by Japin Li, I don't think it is worth because
> it is a transient state (unless something bad happened and pg_database contains
> a dangling row.)
>

Thanks for clarifying. Got it.

-- 
Regards,
Japin Li
ChengDu WenWu Information Technology Co., Ltd.