From: Japin Li <japinli@hotmail.com>
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Use SMgrRelation instead of SMgrRelationData * in
 pgaio_io_set_target_smgr()
User-Agent: mu4e 1.12.12; emacs 29.3
Date: Fri, 13 Mar 2026 15:05:05 +0800
Message-ID: 
 <SY7PR01MB10921D0F6F3C2682570D6C31BB645A@SY7PR01MB10921.ausprd01.prod.outlook.com>
Content-Type: multipart/mixed; boundary="=-=-="
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SY7PR01MB10921:EE_|MEWPR01MB9179:EE_
X-MS-Office365-Filtering-Correlation-Id: af6ee7aa-4f4f-467e-5ac3-08de80cedcc0
X-Microsoft-Antispam: 
	BCL:0;ARA:14566002|461199028|23021999003|5072599009|39105399006|20031999003|55001999003|24071999003|24121999003|22091999003|19110799012|8060799015|15080799012|6092099016|3412199025|440099028|16065399006|40105399003;
X-Microsoft-Antispam-Message-Info: 
	=?us-ascii?Q?2DXhEvdbIvQ69GxKK8mb13YWIex/S0+xxCRoBnDrQK7nC+6DxZp3A05B204p?=
 =?us-ascii?Q?WTjeRDflyfxXSFVidhdl/605i0jLAAwbYI1Mx8s4H3wSe4buuHiUxeMXNUu9?=
 =?us-ascii?Q?agfVOTOvwBt8gHWT+ctAbb1aNWsqkn2NSeHl+yKP9mVdtZqvEyUfbPXEr8df?=
 =?us-ascii?Q?X6mhkIYCc70fbGvMzJtrYYclGlDmcRYgdLmZjePjqwypPEzTp6Y3lCR8kRgt?=
 =?us-ascii?Q?PtovLakm0nwKRoxvxnSv3zDqAR2dm8uvUTXyB7nDj1Cy4pgWn+35gLa4S9Mj?=
 =?us-ascii?Q?SFXk1NMzRActXrU+8HPimDHaUXajZkYU3m8PDVGCktUiKAgsPBVIwx8Vd6D9?=
 =?us-ascii?Q?FBY44xfUkeH93yauCYk271OVsbHOzJRDexolljr0AnORC81nFQsc99tEjGnT?=
 =?us-ascii?Q?7Ib5YNhXjY/NBLdFnQn822SojI+9xN2jobu/TmHceCvmBgyrY4635AwWSFmj?=
 =?us-ascii?Q?KkSw5W5kde8hzlOAc0RGA1izUn8x+W4QZzoIV1anwXTGHrcnkYcL7U7990k/?=
 =?us-ascii?Q?GaZ1bF4nl5njr6CzZ3Vipds6R1626nCw7nOheb05WHQeX1TYrBaGhSB5xfLe?=
 =?us-ascii?Q?kbOGP5GpwaJ3Tf6qC91TLMWFJbLDtfoWQ4wQGPLF096jOIoo/6sVrNoO5UkV?=
 =?us-ascii?Q?jq+fobmPUVYGPH3/eDjS+RYZTndubcbziCXVBMyQVVe6L8MWeomHLsMPZ2kx?=
 =?us-ascii?Q?77aI9vTNuRUT4BEr7kkqOuvtwyHytoGcgzowjH9tbxXQ3UsiJnxWRsQd6fW/?=
 =?us-ascii?Q?rHs+LazgCE1kf1asTeGs+loGNRL73HXEzYIaAgd86GCOpyfmsZzGeNj6t53g?=
 =?us-ascii?Q?dguOtaDBMfkhFGcjzto4crSvHFtp7OIHup4z0f9zt5Cikk9reU5pZAAN5HJ/?=
 =?us-ascii?Q?uutEwJiXDvqV4gQIHU/5Il0TYBgseRc8dr2AGCd/wyOoJofJ8tb1oBavCiQX?=
 =?us-ascii?Q?6U06CVwDS8J9Ej34VDyYdL3aY4TPirDHCQpthfDoeaEHB5BdxhXQNq3FICI/?=
 =?us-ascii?Q?HX+HfRr6R7fngbWhGp1CSVGpopYGnmIkkRk+n7Su2cMVYfZKkDHXmYpbPPRe?=
 =?us-ascii?Q?3ZUgKW+J3lm05lAzpbi+xhPfE7a2l3npXfL5TRT7hX5t3dCP0ibUel3PNRXM?=
 =?us-ascii?Q?yvcn2Wk29r53?=
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?94A3FHKEZMO8VDE8YAmjpvvQn/NwRjg/bYF1ACA6YRpu/fb9LqOuGAOvVXQr?=
 =?us-ascii?Q?g2P2ZczvdcYEcIaJuhijUnHqJYZ90nXRo1UiEPUW4OWORQwFWCe3oTancirB?=
 =?us-ascii?Q?D2HAFL+sSTWa6GIdpN5+Gr/PRJmxlMEEsqf2jVdKks4SPqoyqftEEJWKumfm?=
 =?us-ascii?Q?aFcl5M+C3MTZfH1Y7s3qJY8vfufduKOVXoPhm9CEmzO9GaojYjhW0XDTWEIs?=
 =?us-ascii?Q?+7+8kduEuNVcsSdYLdFuDieFn8yM+S8AXsxQyagLLV1049O658b4YIbqQuSM?=
 =?us-ascii?Q?TrXZHs114iR/SL//9b8GZ4fCspnrG32QGBmUQEk2UOKsadMMFtSa+marCnQq?=
 =?us-ascii?Q?6SMW1Ae9drDGBoTc1CSVP4p045OOUekIzXC4IJoD2leT8/a2OMLjKg9f7nBw?=
 =?us-ascii?Q?wiKa5/ljK0UJU6MBYEQmwAuMtR6adBL1wR1xjqKHJ9dJaD8YTsBcAE7pCupv?=
 =?us-ascii?Q?h3oK3xb7JVrDmKFiyN7udlKyN0c4LAv38FCNkj3GduzJ58L1xiNJ198jYLxJ?=
 =?us-ascii?Q?BvTE5yMup3ACas9Wl1EXVqfU0GygxE1ta4jOS7gn2hNMhFHbwdEo5s6kBXc2?=
 =?us-ascii?Q?ARnaPNZJ+YXnTDKQSo4hHqJACX9yPdlFteNwc0kQhlzyfyoLp8QP356ijODz?=
 =?us-ascii?Q?F48BBeiW7Opl3fLXnWNfzXCQEXIgqGxdulauaI2UE5Iq9oPCMDf415bGuIkT?=
 =?us-ascii?Q?rSOiJkVPQYjfTNyCqBIdrTQz4mBVtvw3B6Ta9SXapM3dTu1H9X2KlArmVVBh?=
 =?us-ascii?Q?J5+18IEuChIMhzS/6VvnjOVmMi0ufWGHj7zc+xGRlM8hB16iP+DZmPSeonfm?=
 =?us-ascii?Q?3ZC1EMVMprk4VZKZTep4xGgJjbMlA49kctXyRDdoC8KyjcDDtO7dTzsgsXkM?=
 =?us-ascii?Q?QWEqsi9pvaOHQ1ROvAIqoY6Mhf1AhLjeBDVwZ2OBHxJczLJV7GFSIKeTdWDX?=
 =?us-ascii?Q?0MkrWnmIpH953N7qFkESDnOun/bQha2rsGb5/W6KEtXG8CQo9aor5WRu5zuS?=
 =?us-ascii?Q?NjiZO7XUkNDMyhD0F4/YpANmqMyhtcXymsUDoL704f78htPr43TBsYK/ZsH/?=
 =?us-ascii?Q?jVXQaNfNyctgGeZoSKPyrf91WgG6T+SDQCsFOxxoJMqi65I4zKtRHGEUtzPl?=
 =?us-ascii?Q?VooDHSX1F0GpU2LUC09tqtnx2t41dfjbZmfJm9KH4Nuh+7QGxhO9b4getQy6?=
 =?us-ascii?Q?Ga7pALyYi4iOaiwqtZ26mrkLD/KLSVXEocuu4ibUc4XbaU9OhPd7B+aYveg3?=
 =?us-ascii?Q?mGJ6WSigtzZ+rllWje8Oe7oQTfSUd4dOY0Wfwc3TQsZJ2bzgOwteYBQkCDNM?=
 =?us-ascii?Q?TZN+jNaVthaa9dPuQrER15EUC26DeTun1TA6cF+pYyAWAIzJz9gVOqM5Ih96?=
 =?us-ascii?Q?o9LLjZNx0Ufr2WcEUS2lIRkVCcKw?=
X-OriginatorOrg: sct-15-20-9412-4-msonline-outlook-feddd.templateTenant
X-MS-Exchange-CrossTenant-Network-Message-Id: 
 af6ee7aa-4f4f-467e-5ac3-08de80cedcc0
X-MS-Exchange-CrossTenant-AuthSource: SY7PR01MB10921.ausprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2026 07:05:08.9727
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MEWPR01MB9179
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/SY7PR01MB10921D0F6F3C2682570D6C31BB645A%40SY7PR01MB10921.ausprd01.prod.outlook.com>
Precedence: bulk

--=-=-=
Content-Type: text/plain


Hi, hackers

While reading smgr.h, I noticed an inconsistent type usage in
pgaio_io_set_target_smgr(). Currently the function is declared as:

    extern void pgaio_io_set_target_smgr(PgAioHandle *ioh,
                                         SMgrRelationData *smgr,
                                         ForkNumber forknum,
                                         BlockNumber blocknum,
                                         int nblocks,

However, SMgrRelation is defined as "typedef SMgrRelationData * SMgrRelation;",
and all other functions in the smgr subsystem use SMgrRelation as the parameter
type.

To keep the code consistent with the rest of the smgr API, this patch changes
the parameter from SMgrRelationData * to SMgrRelation in both the definition
and declaration.

This is purely a style/consistency cleanup with no functional change.

Thoughts? Is this change acceptable?

-- 
Regards,
Japin Li
ChengDu WenWu Information Technology Co., Ltd.


--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
 filename=v1-0001-Use-SMgrRelation-instead-of-SMgrRelationData-in-p.patch