From: Japin Li <japinli@hotmail.com>
To: Mats Kindahl <mats.kindahl@gmail.com>
Cc: surya poondla <suryapoondla4@gmail.com>,
  pgsql-hackers@lists.postgresql.org
Subject: Re: pg_rewind does not rewind diverging timelines
In-Reply-To: 
 <CAN305gCaErXmG3fg48n50dWUC7=ETBBopuFL_cgyzutXUdp-5g@mail.gmail.com>
	(Mats Kindahl's message of "Tue, 26 May 2026 18:03:32 +0200")
References: 
 <CAN305gBeJr8m7ZRW9mH0zakEFR4hDUPDo8fJRKJOHWMORG5_Bg@mail.gmail.com>
	<CAOVWO5oZZtniLR4Pyd=e_cS-FNxh837Gbz9TDUnSwWqmbap=bw@mail.gmail.com>
	<CAN305gCcj4Mhr3uBQAnQCYsx6F-syp1rGtazoy=h+_EHO0xOXA@mail.gmail.com>
	<SY7PR01MB1092190B1E748F1438CAB5D7AB60A2@SY7PR01MB10921.ausprd01.prod.outlook.com>
	<CAN305gBPFE8KPgT5cdsbK8Xwxxii_+Hp4WVhCWsjFOYJ9j4xaw@mail.gmail.com>
	<SY7PR01MB109216DF36CF987CF6EF10B29B60B2@SY7PR01MB10921.ausprd01.prod.outlook.com>
	<CAN305gCaErXmG3fg48n50dWUC7=ETBBopuFL_cgyzutXUdp-5g@mail.gmail.com>
User-Agent: mu4e 1.14.1; emacs 30.2
Date: Fri, 29 May 2026 10:01:41 +0800
Message-ID: 
 <SY7PR01MB10921E0F8383139EB27B33C11B6162@SY7PR01MB10921.ausprd01.prod.outlook.com>
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SY7PR01MB10921:EE_|SY4PR01MB8277:EE_
X-MS-Office365-Filtering-Correlation-Id: b8bdb4a5-beb7-424d-12c9-08debd263f78
X-Microsoft-Antispam: 
	BCL:0;ARA:14566002|5072599009|22091999003|23021999003|24121999003|24021099003|8060799015|15080799012|19110799012|10035399007|26121999007|440099028|4302099013|3412199025|40105399003|52005399003|1602099012;
X-Microsoft-Antispam-Message-Info: 
	=?us-ascii?Q?/WTnYrEPlFLy+ZMNAApu3+pECBAoMipFCXTqoCRnhF6B3vmewtayni2Jmm4q?=
 =?us-ascii?Q?AVznvviOrBfnN+oVPLPYHDr48Z5d3m03lRR5+2rUUYTIwSX482BFcdUD6InJ?=
 =?us-ascii?Q?ZxGUY+y2GPdzds1mUIMfL9NqSPTyfWs3yaUHXnJPxmiCAql6yQ8xykMaZogK?=
 =?us-ascii?Q?5CVv/Ietr5Ouby//vGPolAJGiAUXtOknnO6qdVmS4Jbzb075wEMD0zC68YpG?=
 =?us-ascii?Q?KkR63YYivOIEPDoEnmm76aHvBWHsf/fTy18c/aQwi4+FSo5NbBZkcB2XOWyD?=
 =?us-ascii?Q?j8/KeXK5BgmzQCvUI6lVpIuGJAppI/tRhJhsfFkMco5brKK3e1Bq64gtFYPq?=
 =?us-ascii?Q?lfJ5mkU91M2cni28F51JeSeSs6K1xGn972vxyzzutnltoH0sdOzZnj3mmX5d?=
 =?us-ascii?Q?jkn88bx+YGPLIybCHSM1tuzcXxrPAm/ghwvEso9xhjFO+PKy6orHT2/fMM4e?=
 =?us-ascii?Q?382YO5+5MQO0ZTS9pGgbhWLX354lDvhLsume4Mq6vmbDiKhxU7j8l1YJvEFq?=
 =?us-ascii?Q?dfXxsHdo3MueChjUvnA4FZE3dLSd3wKNEgqxSxbWP2qaHHK4GteVGYCzRUCQ?=
 =?us-ascii?Q?Jk+/H/B8MkJsvYU+1xBKdfaNCg6Cxw1pkfq19rL86Z0BGLhXsq3sisXwRT08?=
 =?us-ascii?Q?CKkn2SFMi9HUOT4B59DCjB2t+zPzWZhN9i+EJFIuxDylXqRswz4VXjA5MkUr?=
 =?us-ascii?Q?Xb1ZuvTdGfJEAggraAmMK4baHpVbS7kld8G63zuXrsEPokl99VcvmuRwcK/M?=
 =?us-ascii?Q?B/PbhOvnauqROVWqEZo4Y5ocUz6mrqOHnzhcH8Lpn2e4YCi+gOYocjx8zWSn?=
 =?us-ascii?Q?TygnRDnDDjWTc1vZvnEt1pf1E1jjzJ6qt+5Y+JPpaxN4paDjPqrX7RTWpKG9?=
 =?us-ascii?Q?DE41UKCOyeSsGCsbcujSI548g5YAvkM1eZzGC6gGoDwCMrOWqW3yJgsWaOmp?=
 =?us-ascii?Q?lqNpyXKD/u3hB9hUITI6hUa0xnHCpxq11+g6uVYoY97SW928/YZdRMunP48L?=
 =?us-ascii?Q?xMZ3FmS3h9h8k5fu0bDEHa3MB0xPxE7wjy0UK4Je761oPL6rGg2c12wRtSQE?=
 =?us-ascii?Q?2YNLY//bZJKHJ3JBtHeVmQa4YOIMzQ=3D=3D?=
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?hgy1laqB5SnWq4kqvJ65ry98DaeE5dS338qJSQq4ZDQwd815yWGoTPRYBJYq?=
 =?us-ascii?Q?Oy5CGpkSyL51FimpvfMfFLR72zVolVBtGq0lHRhlNmOGX+tTEPbAWIxYV0xp?=
 =?us-ascii?Q?hXES1iJgSWRt9BL7cagSY8MNtu9l3NZdBh4YKEC4lA2iiPmSxNJmEW1F/c+z?=
 =?us-ascii?Q?ttj0Tz/1wvEcGJDLwQum5DfeYPlYAKmI4oViQx6wu7Af5utG1N2NT70dqslx?=
 =?us-ascii?Q?Li64scTwBRWxbdcphatPdgyWxOdWP/88oztL3aiQsc97YOB57vkq3T5/tYLA?=
 =?us-ascii?Q?poCwUb8AS+TFP0uKMAY7PQ3gs+B7AxTtM8N3CdXr0qOB/3Y/jClVGiyWURZv?=
 =?us-ascii?Q?g1Qtbx9ZYlv3m9VyG0x+kS5f5p+A3P8PE2EZGGaZi8+e0psJU2JlckW2nhpQ?=
 =?us-ascii?Q?VFdner6unpieWe6uyiZxB30R4xqR/lfu66ZduX2HRYwtwGqqr5LIub2kdJd1?=
 =?us-ascii?Q?EY9dJMZ/Tb6R57nEwCapi1FjAzRSWU69XZSmvr/rxZUo2AYLRt9JVj4mGozS?=
 =?us-ascii?Q?FkQdT5eaHeblnh8Uhw3FR381YnzVYjEXujd6yveQjf+9r2hftjW0q7qbdzf7?=
 =?us-ascii?Q?oVMv3QG4jL2PO77H5vmVOk4XJnnsQUSLga9WeqQKichaKC2Ms682aRJfZFcj?=
 =?us-ascii?Q?y74nSHGtBCVZFOlziKw4mz7J3sXMmQad04ZIt1TsxJX0CN5odPSi8sog/FUh?=
 =?us-ascii?Q?YRku9IdIMhADhnhZKyWEvwsa01SopqDE2PGIYg/6LEYsbfbXQ1oVGQnf7YwN?=
 =?us-ascii?Q?1SicDOjVWoEe8Is3N72vdEPuJFFLbv4PEU9MDxUhFWhiTyZs3EhhXHMh95nQ?=
 =?us-ascii?Q?dBLld86RfnpCFr/pnUnRhUqmnuyf6wW3P+OJWIDGbSS4wQkLrwgsACMXhwcY?=
 =?us-ascii?Q?y1Zqw79gy+A/MW101jpnSojv/E2F75gkY8+/AnX3cVzIvSm7ZRS0emayHcdS?=
 =?us-ascii?Q?h9JPVl+7DfrpPoB87IQAKRWp1ktfL8jq3fcxdu3fSSordZDxn6FrhOtaMJGE?=
 =?us-ascii?Q?s4Xa95rU84SOJihHvqZ837XfyLgdS0cMWI3d5pxuY+GRheEKPrGWaiNgaDRZ?=
 =?us-ascii?Q?qkez+YEa60ljp4AcUXNFXXld54Z2+JujYeFeVEGbeUcyt0qpOt3hJ41HBkkk?=
 =?us-ascii?Q?pYz1KBPVfjCZuNH5bOy7EJjFQFeNSeEIz52NyVdFqgrM2C9MM1PRbVo4K4xM?=
 =?us-ascii?Q?Pd/Nnu1YnV+n5OmRZ7NsJO+d7tBMZ2j13SGkEdVdmL2jd2uH84AnisHOd0lW?=
 =?us-ascii?Q?FFJbbi1sKuPSRbVlKfqzmYKCIL6SGhd+hkD3VlE/2Hlf+QuXG9ZfmlVTuXR9?=
 =?us-ascii?Q?s8shLZg//NCFFeGjFa1lQfXZbxoPReyceBHmmT7H3dwwqYffs3iCLyPq7mos?=
 =?us-ascii?Q?pe9tDVFeNzUhwhQCYWyq0LIQOcIZ?=
X-OriginatorOrg: sct-15-20-9412-4-msonline-outlook-feddd.templateTenant
X-MS-Exchange-CrossTenant-Network-Message-Id: 
 b8bdb4a5-beb7-424d-12c9-08debd263f78
X-MS-Exchange-CrossTenant-AuthSource: SY7PR01MB10921.ausprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2026 02:01:50.9453
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SY4PR01MB8277
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/SY7PR01MB10921E0F8383139EB27B33C11B6162%40SY7PR01MB10921.ausprd01.prod.outlook.com>
Precedence: bulk


Hi, Mats

On Tue, 26 May 2026 at 18:03, Mats Kindahl <mats.kindahl@gmail.com> wrote:
>
> Attached a new version of the patch with the changes you suggested.
>

I found an error on the Windows platform [1].

[07:08:28.538] >>> MALLOC_PERTURB_=3D168 PG_REGRESS=3DC:\cirrus\build\src/t=
est\regress\pg_regress.exe REGRESS_SHLIB=3DC:\cirrus\build\src/test\regress=
\regress.dll MSAN_OPTIONS=3Dhalt_on_error=3D1:abort_on_error=3D1:print_summ=
ary=3D1:print_stacktrace=3D1 top_builddir=3DC:\cirrus\build UBSAN_OPTIONS=
=3Dhalt_on_error=3D1:abort_on_error=3D1:print_summary=3D1:print_stacktrace=
=3D1 MESON_TEST_ITERATION=3D1 PATH=3DC:\cirrus\build\tmp_install\usr\local\=
pgsql\bin;C:\cirrus\build\src\bin\pg_rewind;C:/cirrus/build/src/bin/pg_rewi=
nd/test;C:\VS_2019\VC\Tools\MSVC\14.29.30133\bin\HostX64\x64;C:\VS_2019\MSB=
uild\Current\bin\Roslyn;C:\Program Files (x86)\Windows Kits\10\bin\10.0.226=
21.0\x64;C:\Program Files (x86)\Windows Kits\10\bin\x64;C:\VS_2019\\MSBuild=
\Current\Bin;C:\Windows\Microsoft.NET\Framework64\v4.0.30319;C:\VS_2019\Com=
mon7\IDE\;C:\VS_2019\Common7\Tools\;C:\VS_2019\VC\Auxiliary\Build;C:\zstd\z=
std-v1.5.2-win64;C:\zlib;C:\lz4;C:\icu;C:\winflexbison;C:\strawberry\5.42.0=
.1\perl\bin;C:\python\Scripts\;C:\python\;C:\Windows Kits\10\Debuggers\x64;=
C:\Program Files\Git\usr\bin;C:\Windows\system32;C:\Windows;C:\Windows\Syst=
em32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0\;C:\Windows\System32\O=
penSSH\;C:\ProgramData\GooGet;C:\Program Files\Google\Compute Engine\metada=
ta_scripts;C:\Program Files (x86)\Google\Cloud SDK\google-cloud-sdk\bin;C:\=
Program Files\PowerShell\7\;C:\Program Files\Google\Compute Engine\sysprep;=
C:\ProgramData\chocolatey\bin;C:\Program Files\Git\cmd;C:\Program Files\Git=
\mingw64\bin;C:\Program Files\Git\usr\bin;C:\Windows\system32\config\system=
profile\AppData\Local\Microsoft\WindowsApps INITDB_TEMPLATE=3DC:/cirrus/bui=
ld/tmp_install/initdb-template ASAN_OPTIONS=3Dhalt_on_error=3D1:abort_on_er=
ror=3D1:print_summary=3D1 share_contrib_dir=3DC:/cirrus/build/tmp_install//=
usr/local/pgsql/share/contrib C:\python\python3.EXE C:\cirrus\build\..\src/=
tools/testwrap --basedir C:\cirrus\build --srcdir C:\cirrus\src\bin\pg_rewi=
nd --pg-test-extra  --testgroup pg_rewind --testname 005_same_timeline -- C=
:\strawberry\5.42.0.1\perl\bin\perl.EXE -I C:/cirrus/src/test/perl -I C:\ci=
rrus\src\bin\pg_rewind C:/cirrus/src/bin/pg_rewind/t/005_same_timeline.pl
[07:08:28.538] ------------------------------------- 8< -------------------=
------------------
[07:08:28.538] stderr:
[07:08:28.538] #   Failed test 'pg_rewind rewinds across mismatched TLI 2 /=
 TLI 2-prime to TLI 1'
[07:08:28.538] #   at C:/cirrus/src/bin/pg_rewind/t/005_same_timeline.pl li=
ne 45.
[07:08:28.538] # ---------- command failed ----------
[07:08:28.538] # pg_rewind --debug --source-pgdata C:\cirrus\build/testrun/=
pg_rewind/005_same_timeline\data/t_005_same_timeline_node_b2_data/pgdata --=
target-pgdata C:\cirrus\build/testrun/pg_rewind/005_same_timeline\data/t_00=
5_same_timeline_node_a2_data/pgdata --no-sync --config-file C:\cirrus\build=
\testrun\pg_rewind\005_same_timeline\data\tmp_test_ZCeZ/target-postgresql.c=
onf.tmp --restore-target-wal
[07:08:28.538] # -------------- stderr --------------
[07:08:28.538] # pg_rewind: using for rewind "restore_command =3D 'cp "C:ci=
rrusuild/testrun/pg_rewind/005_same_timelinedata/t_005_same_timeline_node_x=
_data/pgdata/pg_wal/%f" "%p"'"
[07:08:28.538] # pg_rewind: Source timeline history:
[07:08:28.538] # pg_rewind: 1: 0/00000000 - 0/040000E0
[07:08:28.538] # pg_rewind: 2: 0/040000E0 - 0/00000000
[07:08:28.538] # pg_rewind: Target timeline history:
[07:08:28.538] # pg_rewind: 1: 0/00000000 - 0/040000E0
[07:08:28.538] # pg_rewind: 2: 0/040000E0 - 0/060000E0
[07:08:28.538] # pg_rewind: 3: 0/060000E0 - 0/00000000
[07:08:28.538] # pg_rewind: servers diverged at WAL location 0/040000E0 on =
timeline 1
[07:08:28.538] # cp: cannot stat 'C:cirrus'$'\b''uild/testrun/pg_rewind/005=
_same_timelinedata/t_005_same_timeline_node_x_data/pgdata/pg_wal/0000000200=
00000000000004': No such file or directory
[07:08:28.538] # pg_rewind: error: could not restore file "0000000200000000=
00000004" from archive
[07:08:28.538] # pg_rewind: error: could not find previous WAL record at 0/=
040000E0
[07:08:28.538] # ------------------------------------
[07:08:28.538] #   Failed test 'rewound node reflects source history, not t=
arget TLI 2/TLI 3 data'
[07:08:28.538] #   at C:/cirrus/src/bin/pg_rewind/t/005_same_timeline.pl li=
ne 260.
[07:08:28.538] #          got: 'origin2
[07:08:28.538] # x'
[07:08:28.538] #     expected: 'b
[07:08:28.538] # origin2'
[07:08:28.538] # Looks like you failed 2 tests of 11.
[07:08:28.538]=20
[07:08:28.538] (test program exited with status code 2)
[07:08:28.538] ------------------------------------------------------------=
------------------
[07:08:28.538]=20


[1] https://cirrus-ci.com/task/6228217159221248

--=20
Regards,
Japin Li
ChengDu WenWu Information Technology Co., Ltd.