From: Japin Li <japinli@hotmail.com>
To: Richard Guo <guofenglinux@gmail.com>
Cc: Pg Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Convert NOT IN sublinks to anti-joins when safe
In-Reply-To: 
 <CAMbWs48YE2V9YhHWHP5seZ8fs2of7xcG1Vace7BQWsSvsQ2EjQ@mail.gmail.com>
	(Richard Guo's message of "Sun, 8 Mar 2026 17:16:58 +0900")
References: 
 <CAMbWs495eF=-fSa5CwJS6B-BaEi3ARp0UNb4Lt3EkgUGZJwkAQ@mail.gmail.com>
	<CAMbWs49tBNbW7S7VCbTasJEfPQKKU7fbJT2TMoi9uHMhT6rwqw@mail.gmail.com>
	<CAMbWs4-YfL4pnSxg87=6YDdhZD-DYtu1Oa9OvyXaR79q4Xk_mQ@mail.gmail.com>
	<CAMbWs4_V2QM=kUR3s3Jq8GVWAaZtouqpqU46GUuUXtCgAzBriA@mail.gmail.com>
	<CAMbWs4_g4+Vc1oKgoTMfo=sEw5h4seMQyC5m1Wx23Kpy21gvHg@mail.gmail.com>
	<SY7PR01MB1092144FE2B738E660860DED4B67DA@SY7PR01MB10921.ausprd01.prod.outlook.com>
	<CAMbWs48YE2V9YhHWHP5seZ8fs2of7xcG1Vace7BQWsSvsQ2EjQ@mail.gmail.com>
User-Agent: mu4e 1.12.12; emacs 29.3
Date: Mon, 09 Mar 2026 13:14:38 +0800
Message-ID: 
 <SY7PR01MB10921F205A15712E60C7CA04FB679A@SY7PR01MB10921.ausprd01.prod.outlook.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SY7PR01MB10921:EE_|SYBPR01MB5440:EE_
X-MS-Office365-Filtering-Correlation-Id: e0c70e9e-ca2e-4ceb-5967-08de7d9ac537
X-Microsoft-Antispam: 
	BCL:0;ARA:14566002|24121999003|6090799003|22091999003|5072599009|19110799012|23021999003|461199028|8060799015|15080799012|40105399003|52005399003|3412199025|440099028;
X-Microsoft-Antispam-Message-Info: 
	=?utf-8?B?bkNRN0YrWDNrTGJralZWZ29ZbmhPUGJxSGhLUkdxdkhXL1Q0akx0MmZTTVA0?=
 =?utf-8?B?TzM4c1VYNi9FbFIrN1FmQkppRFdUVXJRbng1RldaOEtWNkNmYzNuTnJMeHpB?=
 =?utf-8?B?UEZIaldkQWFkaGdqQXVaL3ZrOHNPZTZudUU1VS8xaVMxR2FVbUlEZldJTGk4?=
 =?utf-8?B?K3RhQU9EVzNUYklhMWEvUVl5TktlM0k4UHZlOVlxSzJwWTlQOVhiNnAwcFhx?=
 =?utf-8?B?anpZdlk5QUs5Y2JMY2JzazFJNitTTStSYjc0eWdJVWc4RHNqVUNEa2dxY2Er?=
 =?utf-8?B?Z1VZOHZ5cGJNcEN3OTZaSTZkYldLQVp0WGRBazdkUEdlaEpWczlxanFwMFB4?=
 =?utf-8?B?WEMzT25tOTZYSlNQTmdzdDU1SW50YVNMYkU5TGg0MG1LMEt5QWtFaGlFUzg4?=
 =?utf-8?B?WHdqZ3NiazFpRU1LbmJsRWk3cEFkOXpyUmR6THBPbW9DM3IzUWM3ZkV2MDgr?=
 =?utf-8?B?d0ZrdFVhbklTUEFZRmh2aFhPT1ArNGFxL3dPSitzc2hkSlowRDFCcU1NN0Z2?=
 =?utf-8?B?OUhPUmszaUF5SitJdGk5YXhyYW0vZ3d3MXdlVXdoOEdTT2NhbUkzV3g4RnFF?=
 =?utf-8?B?ZTh1bVEwVUN6eXlSZ1FtS3dVaVNQWnBjWW1ZTW1kWnFBaEtVNHExbjUyaHRF?=
 =?utf-8?B?c0U0ZmpyWGJBMUxHd3FqZy8remtSdE1KeHFhS3BkSElLWWtCTUJDN3NIT1VZ?=
 =?utf-8?B?KzRqS09jVzdOd2Foc3pJUUpFSUdxRis2ellkUUR3NzRleW9EdEtPRnZTd2lu?=
 =?utf-8?B?R3NmTTJucW8rWGI3ZzlaSW5Bb1dCdlhTQVFtOW9FeExqNEwwVmxPVm5mNyt3?=
 =?utf-8?B?S3JVVU5jYlpGS2h0S0ZxTW1WV2c1NDZHOVE3dytTVzkrQjBkZkpEMWlobURH?=
 =?utf-8?B?ZTROYisxZ3dKZi9CRUp1OXozYTZpWkdwUnJmSm1yenBWbWxKcXVEeksyNUJi?=
 =?utf-8?B?aWVET0k4eVZ2QUZUUytDaW5qZTJuWm9Vb3YxelRKLzFuRVlpN1IwbmFveTdt?=
 =?utf-8?B?SENCVTlxZTVERXVaUlNhUFNmSXlDaVo5L1NzQis2WDhpZDYzcnNFTzJ5Nk0x?=
 =?utf-8?B?RWcxYWdRbHYvNmJhd0JIU3d4Tkk2eHlhczRBRnBJYkpEekE3cXRybEJJQXFO?=
 =?utf-8?B?cFpTZDFDR3pOSWh3K3VuSVM1cXBmamYxdDVSbW5pcHA2eUpuaVpETWh2a0Na?=
 =?utf-8?B?eDN6bkNDYitSYmV3UmRyVHA2Sm9BTldZZDlJaEt3RzQ5dnp5VXdkSkhIRmt5?=
 =?utf-8?B?dUFwa3NnazlQVldHa0RJSDRubmNqR0t6eDF0Y3VHcmdlb0FSSXFsbC96eWZa?=
 =?utf-8?Q?EEKqsqN8C9PaXHkCav/5qRz7BQ5IlGCFR8?=
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?dFBvemFhM05oSTMvckZXaDJHa1loSjVocGNmRHptSHJNOEtUK25JMzZLUURv?=
 =?utf-8?B?Vy9HSWYveWJoMEljSzVMcjZMOXFNRm9vcTFpdFQxUm1ldm5WaDdOU1lMT3Rz?=
 =?utf-8?B?dkY0Ky9vL0FNMkJxVW1QMURYQXBJVFE5eWNyeWl5RlVNZDNnOU9Ua2RNUkc4?=
 =?utf-8?B?R3cvb20xRDc3Sk9zYzBSWTkyOVVVZUVtVnBkQ3lFeTVQYUhsZnBsSUtJRTVD?=
 =?utf-8?B?bnVvMlNDVUZQN3pMb3ZVZVdiQzI3aXVLMXdXR0Y5Y0xBWDJtMnpzanJKOWZh?=
 =?utf-8?B?blZoWXRCVDhxamx2dFBWNkFJZnBUTjdqU3R2elJFTSs2OWZoZ0wyWmZmVytG?=
 =?utf-8?B?MUdXM2Y3NDRyd0ZmZDhSTTBjMEoybk81REVmb203bEdvSXNNcVh0RUk3amNo?=
 =?utf-8?B?NmVqZEF2bzNDRnkwL25jRXNKZTRDano5TXNDcVNtU2h4WEM4U1VyVTRXMHFB?=
 =?utf-8?B?WVA0RVFGenY5aGNkWFJCeW1KTGJXQVZrWUFiRnlEQy8zNGxUYXg4c0hXMm85?=
 =?utf-8?B?L0NzSVowb3dPZHcrSUdxS0t5Y2pqWm92dFZhUlc4a3RDNG4vTHdkZ1A2M01n?=
 =?utf-8?B?NlpvSHYxVDVYZy9aUFViMTRmejR3b20xQmlQbGRpZUkwUGJFaU4rbE05WFU3?=
 =?utf-8?B?RlFZS1dOQjJRa2l3S1hTUGNuZVJ6ZW92ak9iMklBS2doaCtFQU1vMDRxS3ZC?=
 =?utf-8?B?QkZwV3BNTWY5WkZCbFo2cWQvODRrbitMTFhjdWRDR3k2NTJzQkNteVh3bWd3?=
 =?utf-8?B?TzhJcWY1cE1Pc3FUT09ZS3RGb2FTcndpNGpiZldTMWpZM3dGZVdIelBOU0or?=
 =?utf-8?B?QmpRcXhjN3A0UmkwQ1U5c3pGMHN6WHRFSTlpU21mSyt4NEFUNzJNdjFadVhL?=
 =?utf-8?B?bUxjVk9aZjNJSjFiR3dpNWl2WTVEZUlaNklUVExHZm9HTThRYVFsTXI4cnVI?=
 =?utf-8?B?ZEg5bmNKbk1IczhYVmIwTUFNalkzVUNwNllJTWIrZkwycTVGd1dDVWdNZDEr?=
 =?utf-8?B?V2V2NTh0cmRHMjNveDE0SnVlWjRBQmFTaTlrYWJIODVmL0pkclZDMHpGd2M1?=
 =?utf-8?B?YW5IQ2oxS3dvaFAyOXU4TEl3T0dnLzErNWMvMjYrZFdBTUF4Z2lnS3czbDl3?=
 =?utf-8?B?MjNqbmJYZlBQZ0lUSVN1OVRnc29LeVRyaUpCMitJMzNkeVVIdndOMm93OXZV?=
 =?utf-8?B?VFVLZmlVZlYvNSt0U3EvaWNZZytFNHJzdks2NzBTY3c4anpNcVhmQmVIV2hM?=
 =?utf-8?B?elVtWmtzaWQ3cE5Na21BdFVKVEJiNXpVbzZiUWI4TklZWHVic0hDeW1HbDcv?=
 =?utf-8?B?ZUN1ZTZKTHFuYnpja1crbjlUWjRkQ2RqKzVrWVJMTWlsTDM1SU1jNEVDODlx?=
 =?utf-8?B?L2VVbTJPUlNkbjQ4b0Y4WElwTG90VEdiYWZaMncrVjhMeFdHYnFUOFI0TGh3?=
 =?utf-8?B?ZjVHSzhneWp4a203WWlNYnVrVnN5SE1Hd3ZFQW5KTmM5RGIxTTdFaTZIejNB?=
 =?utf-8?B?dERxRTYwY1JXS2p5WkNKWWlZdVMvL2VrQUJQOU5zWlVGaWh1YWkzUXlEdTY4?=
 =?utf-8?B?Y2drcm56ZzdoMlVLZ3ZvZmo5bC9paTBKbVNMekJMK0FyTWZLN3BibTdUYXV2?=
 =?utf-8?B?Ny9Ld0xBUVhUMUM0YlZmVktkSXNCbUcwOElONWZaWTZsRDdISXBZelAvWHBZ?=
 =?utf-8?B?VFF4UXdjRnJyeVB0NDNYajdFNU1mK01rblFCa3FmWXVsQWhrUnlhcXlKcVVM?=
 =?utf-8?B?SXpFQk9YcWVCL1doaTRXSnd6K0F0S043VURqMTJDVkpNZzl6QWN0blVLVmJO?=
 =?utf-8?B?Wko5OUcrbjh0VmVyTWNDQ09kUUdkMHBCRS95Y1BWdktQb2I0OVkyT0xDb2dC?=
 =?utf-8?Q?EpLq7/IXmOAAg?=
X-OriginatorOrg: sct-15-20-9412-4-msonline-outlook-feddd.templateTenant
X-MS-Exchange-CrossTenant-Network-Message-Id: 
 e0c70e9e-ca2e-4ceb-5967-08de7d9ac537
X-MS-Exchange-CrossTenant-AuthSource: SY7PR01MB10921.ausprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Mar 2026 05:14:42.2213
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SYBPR01MB5440
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/SY7PR01MB10921F205A15712E60C7CA04FB679A%40SY7PR01MB10921.ausprd01.prod.outlook.com>
Precedence: bulk

On Sun, 08 Mar 2026 at 17:16, Richard Guo <guofenglinux@gmail.com> wrote:
> On Thu, Mar 5, 2026 at 10:57=E2=80=AFAM Japin Li <japinli@hotmail.com> wr=
ote:
>> Just a quick note: I think `foreach_ptr` is more appropriate here than `=
foreach`.
>
> Agreed.
>
> For homogeneous lists, it is better to use foreach_node so we get the
> additional type-safety assertions in dev builds.  For heterogeneous
> lists, we should use foreach_ptr.
>
> Attached is an updated version of the patch that replaces foreach with
> foreach_ptr or foreach_node accordingly.  Nothing else has changed.
>
> I plan to do one more round of self-review on this.  Unless there are
> any further thoughts or concerns, I'm hoping to commit this in a week
> or two.  Please let me know if anyone spots anything else I might have
> missed.
>

Thanks for updating the patch. LGTM.

--=20
Regards,
Japin Li
ChengDu WenWu Information Technology Co., Ltd.