From: "Fujii.Yuki@df.MitsubishiElectric.co.jp"
	<Fujii.Yuki@df.MitsubishiElectric.co.jp>
To: Bruce Momjian <bruce@momjian.us>
CC: Jelte Fennema-Nio <postgres@jeltef.nl>, PostgreSQL-development
	<pgsql-hackers@postgresql.org>, Robert Haas <robertmhaas@gmail.com>, Tom Lane
	<tgl@sss.pgh.pa.us>, Stephen Frost <sfrost@snowman.net>, Andres Freund
	<andres@anarazel.de>, Tomas Vondra <tomas.vondra@enterprisedb.com>, Julien
 Rouhaud <rjuju123@gmail.com>, Daniel Gustafsson <daniel@yesql.se>, vignesh C
	<vignesh21@gmail.com>, Alexander Pyhalov <a.pyhalov@postgrespro.ru>,
	"Fujii.Yuki@df.MitsubishiElectric.co.jp"
	<Fujii.Yuki@df.MitsubishiElectric.co.jp>
Subject: RE: Partial aggregates pushdown
Thread-Topic: Partial aggregates pushdown
Thread-Index:
 AQHaZV+FhOOC+4jqD0O6QaSNENpP/LEfzV+AgBnxJJCADnsVgIAB3niAgATs94CAXSjd0IAMTAEAgADLHwCAAJLNgIAJQrjwgAAp5wCAAQFMEIAALTSAgBFC0CCAAavCAIAAGn1QgACpMoCAAEuzIIAAiFGAgAh0U0CAB8s+gIAC0Z0w
Date: Sun, 7 Jul 2024 21:52:27 +0000
Deferred-Delivery: Sun, 7 Jul 2024 21:52:26 +0000
Message-ID:
 <TY2PR01MB3835F90801CE766B89B255EA95D92@TY2PR01MB3835.jpnprd01.prod.outlook.com>
References:
 <CAGECzQRVuUZEhPL+rzY0_0UKEaZ-sFFkLJ6GN+bad+im2r9=uQ@mail.gmail.com>
 <TYAPR01MB308841016A3F1AE8247BAA6495C02@TYAPR01MB3088.jpnprd01.prod.outlook.com>
 <CAGECzQSXXKVCQ13jHXtmk=PMsJHhFGb78PoT3JiT4eAcoLXxoA@mail.gmail.com>
 <TY2PR01MB383585CACD74F2106A0563C195CB2@TY2PR01MB3835.jpnprd01.prod.outlook.com>
 <CAGECzQSKMO9C8-9Eo-feE3BJTF68EWKHXY4-xf_5BMKm8yAHPw@mail.gmail.com>
 <TY2PR01MB38353E34056D0F91736F358395D42@TY2PR01MB3835.jpnprd01.prod.outlook.com>
 <CAGECzQTnfUdRO21CkwZeMowFZC3zQ9+dhNp3EB-G52=BXJvyPg@mail.gmail.com>
 <TY2PR01MB3835DE59D4654A499A5A699795D52@TY2PR01MB3835.jpnprd01.prod.outlook.com>
 <CAGECzQT=CjkORFaZuBn4Db9CRt9C_EpB2isadmx_iNS3ZzQMwg@mail.gmail.com>
 <TY2PR01MB3835CB1D110362A3213E5F6795D22@TY2PR01MB3835.jpnprd01.prod.outlook.com>
 <Zogu7zHOvDNl1LsK@momjian.us>
In-Reply-To: <Zogu7zHOvDNl1LsK@momjian.us>
Accept-Language: ja-JP, en-US
Content-Language: ja-JP
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?iso-2022-jp?B?TytDWHpVM1JFMWJmVHpjRWVoUHJBZTR4djlFR1dOa05hN1Y0Y0hGTDVD?=
 =?iso-2022-jp?B?U2lhcXRFeXdmcWxHalNLYWtkUXluZHlTYzZTNWJGbmhKYmZZWjRTY2FL?=
 =?iso-2022-jp?B?RkhrbGgrenZpekxGMm9MYUMzMHZ4UXd4dHVUYUVwZStsS0h0cXk5bjNp?=
 =?iso-2022-jp?B?dUFqN0dscEtpU21pQmJVeWRNL1Y4bHBNWVNRNlQxd2pkdGp2dm1rSzVX?=
 =?iso-2022-jp?B?UXp2Uk1WdnZNSFR5b1hpR21IL0VpdHBHR0JXYVNnTSt3Y0I3bkNpVHVC?=
 =?iso-2022-jp?B?TDY4UDRLMURuRGhkTC9rMSsrYU1uNFhFQVQ3TlRFTlhJWHZoZ3p0R3RV?=
 =?iso-2022-jp?B?MUZROEhEVFI0OFk3WG4xR3ZMUnhsYWo0b1JFcXd2bC9UeWlZZUtKS1dD?=
 =?iso-2022-jp?B?aE9GdDVXSDZkWjNNc1NHZVBWWE5xWXlvWjU1YmpBdGt2UXRwVU5XWE1W?=
 =?iso-2022-jp?B?SG54K2xpb3ZTSVR5TDloSjVIaUR0TWg3a05MQ09VY1pVRnduK0tzTE5t?=
 =?iso-2022-jp?B?MStpN29nU1p1NENqL1NHUG05c2ViUmd3ZzhiQTVFN1pNbDdWb0tIb21x?=
 =?iso-2022-jp?B?UnAxWktzRGQ3MFh3RVBCWTdXMzVYNkZjNGNXT2dsbEw4T0JIdzYrUm1Y?=
 =?iso-2022-jp?B?SlZnb2VyMG9LTmllRlIrVDMzZStZenBRc09UZGJUSXN1Q2p2SmFMbTli?=
 =?iso-2022-jp?B?eHJFQkgvdHU4aE5odnJWSkpITUl6K0tuRVJST3Q2OWovUU9nOExXYlY3?=
 =?iso-2022-jp?B?ZFVMaTRXMTkrMmhjMUM5WkhkRDk3RUNYM09sRkM4WkYvZjFnbXRaem1h?=
 =?iso-2022-jp?B?Vkk0VUUwYktlY0RHZTQ1SmlTT09Tamk4eXVCRlZXTlZTK0wwcHhxNmly?=
 =?iso-2022-jp?B?ZmpkLzNVME0vWURDbVl0U2hFMW1EVUZRWTZMSkwvNEZjZER4REQ1cHNX?=
 =?iso-2022-jp?B?WksrQnpGRk9zY2pGQXpiZ3hEQU9pOVptMHMyWVFoNHJJbmk2UjVGV3hE?=
 =?iso-2022-jp?B?cDRCVVdIUzRVM1RuU1RLRGFtRWxUOWh0amtMMHU1U0lXNkxpNXZaQWJN?=
 =?iso-2022-jp?B?R1Z0Qm96UWdSZUlDazhUOGFtSEQzVGM5ck5TYXBUVW9IUG9iSDNWSFJs?=
 =?iso-2022-jp?B?NkZEVG1WTURzUkQzU1A2dVBsZ3A3dFg0d0NaaTB1dmVMVUtyQmFkKzRS?=
 =?iso-2022-jp?B?cmpBTGc2enEvUE50REN4STAxNHNFVm9UWkk4UzdOTmxnTm5qclN5VUdB?=
 =?iso-2022-jp?B?VWRyRHZoSUhtVVpYb0JQOFhNeFRqSDloMUhxUEs4WmZaT0QxYlRDWXhB?=
 =?iso-2022-jp?B?cmFnSGNCMDJnZmdlNnlweXUwR2Z4RmZBRnR1QXNpU1JuZ3VYaExVa2dI?=
 =?iso-2022-jp?B?Uk5tdEc5dm1mVUQ3Z2lORmZVRTI5NlRscjZwOWZNa0pvTTYwSDNkd3A1?=
 =?iso-2022-jp?B?Wmdra29CSmdIK3JkL0ZHZ3ZYKzI1bGtvTlBrNXFMeW5ENzJOMCtuMkhT?=
 =?iso-2022-jp?B?NGxGRWk2Y2JrcEEwWm5WMnJUU0tDYkFEbnJQTjdvNmVwcXlHb0JXMlN0?=
 =?iso-2022-jp?B?bjVjeVo4dlBFcTBReXY2UDlkRytkTXZDRU1YazM3QzFzSjdITjYyVElE?=
 =?iso-2022-jp?B?b3NDMkxKZGpFS1AxLzdzbTc0VU16dDh3Mm91Y1N4VzByTzZQajk0akVY?=
 =?iso-2022-jp?B?VE9MQ3E3Q2FzdUY1V3J0cmJFY0hUME8xckVSNnJLdExrYVo2QWNFY3Bv?=
 =?iso-2022-jp?B?KzJyUmgvMzE2SXpGSytONWg0b3Z4THhZQ3o1Q29obXM0M0lUNEJ3SjNQ?=
 =?iso-2022-jp?B?eGRvY3RneEo1UXR6UHh3V3VYVHdISDQ1TmFuZllKaVhRRTkyTEZETTJG?=
 =?iso-2022-jp?B?VmNVcWFVZkZYTnZYRlo5aUZxY2pJZkNoWUkwaXU2SnJ2M0k4M25PeVd6?=
 =?iso-2022-jp?B?azdFVTlOOElOL3FvcElUNDYveHRJbUVwcVlPbjRkSnJIc2ozdm5mUnlY?=
 =?iso-2022-jp?B?cjc1QUlaazNUYnpSZE1HRXIwc0xxcWlmQmJhaWhFZStMdjRaT09rTHJ3?=
 =?iso-2022-jp?B?Y3hIUHlmV1ZGeElyOWNKMTJvWFMwOWo0MWhNSGtnbnpjM1Ryem1xK1JZ?=
 =?iso-2022-jp?B?bW5YSlJvSThlZE9DRUVPa04zaWd5aDdQM0dvUW43ejBFay9oWWpPNjZj?=
 =?iso-2022-jp?B?NjFEdTRFZUxnYmFHWis1N0NkaE1UNTd0NDF1Qit0eWI0KzFKY21SVURH?=
 =?iso-2022-jp?B?S3BpTU1tZm1mV3FFc2ZjYU00WE5JMW8yaXpHc1NFbzV3TnkyRmdIM0hH?=
 =?iso-2022-jp?B?dllTOQ==?=
Content-Type: text/plain; charset="iso-2022-jp"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: df.MitsubishiElectric.co.jp
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: TY2PR01MB3835.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fc3030eb-9a0f-419b-9667-08dc9ecf1b67
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jul 2024 21:52:33.4344
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: c5a75b62-4bff-4c96-a720-6621ce9978e5
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: FlxENv5Elo9ykDaft7hrEQuGWv4tobq1RI3z0up8urbIrO58NzORHVd86hwyF5tgKBojpWNgYqJjcMfrpzP2kQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS0PR01MB6339
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/TY2PR01MB3835F90801CE766B89B255EA95D92%40TY2PR01MB3835.jpnprd01.prod.outlook.com>
Precedence: bulk

Hi Bruce.

> From: Bruce Momjian <bruce@momjian.us>
> Is there a reason the documentation is no longer a part of this patch?
> Can I help you keep it current?

Here are the reasons:
  Reason1. The approach differs significantly from the previous patch that =
included documentation, the below.
    https://www.postgresql.org/message-id/attachment/152086/0001-Partial-ag=
gregates-push-down-v34.patch
  Reason2. I have two options for transmitting the state value and I'm eval=
uating which one is optimal.
   One is what I presented you in PGConf.dev2024. The other is Jelte's one.
   He listened to my talk at the conference and gave me some useful comment=
s on hackers. I'm very grateful that.
  Reason3. The implementation and test have been not finished yet.
Regarding Reason 2, I provided my conclusion in the previous message.

My plan for advancing the patch involves the following steps:
  Step1. Decide the approach on transmitting state value.
  Step2. Implement code (including comments) and tests to support a subset =
of aggregate functions.
    Specifically, I plan to support avg, sum, and other aggregate functions=
 like min and max which don't need export/import functions.
  Step3. Add documentations.

To clarify my approach, should I proceed with Step 3 before Step2?
I would appreciate your feedback on this.

Best regards, Yuki Fujii
--
Yuki Fujii
Information Technology R&D Center, Mitsubishi Electric Corporation