public inbox for [email protected]  

help / color / mirror / Atom feed

From: Hayato Kuroda (Fujitsu) <[email protected]>
To: 'Amit Kapila' <[email protected]>
Cc: John Naylor <[email protected]>
Cc: vignesh C <[email protected]>
Cc: Zhijie Hou (Fujitsu) <[email protected]>
Cc: Peter Smith <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: Dilip Kumar <[email protected]>
Cc: Bharath Rupireddy <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Cc: Bruce Momjian <[email protected]>
Cc: Julien Rouhaud <[email protected]>
Cc: Masahiko Sawada <[email protected]>
Subject: RE: [PoC] pg_upgrade: allow to upgrade publisher node
Date: Thu, 30 Nov 2023 04:12:50 +0000
Message-ID: <TY3PR01MB988913BBE71B519F29AD041FF582A@TY3PR01MB9889.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <CAA4eK1K228Z9TV4hGH8b9p86s+wGvE55P5Htz4jL7ie2tkSwWQ@mail.gmail.com>
References: <CANWCAZYgSjOKNAeCq=n4o=+jOxFK9tYxDRt1uP000hjgFfqOyQ@mail.gmail.com>
	<CAA4eK1K28agXNG4D2CoEWRVpFScswkwYhR60LaB3=T84Up6zoA@mail.gmail.com>
	<OS3PR01MB9882FED1F0060468FB01B9DAF583A@OS3PR01MB9882.jpnprd01.prod.outlook.com>
	<CAA4eK1JVg9Kv=-1_Do9K5xWR-pUD6bpS38FOfQZ=smvOHnKErQ@mail.gmail.com>
	<CAA4eK1K228Z9TV4hGH8b9p86s+wGvE55P5Htz4jL7ie2tkSwWQ@mail.gmail.com>

Dear Amit,

> Sorry, my analysis was not complete. On looking closely, I think the
> reason is that we are allowed to upgrade the slot iff there is no
> pending WAL to be processed. 

Yes, the guard will strongly protect from data loss, but I do not take care in the test.

> The test first disables the subscription
> to avoid unnecessary LOGs on the subscriber and then stops the
> publisher node.

Right. Unnecessary ERROR would be appeared if we do not disable.

> It is quite possible that just before the shutdown of
> the server, autovacuum generates some WAL record that needs to be
> processed, 

Yeah, pg_upgrade does not ensure that autovacuum is not running *before* the
upgrade.

> so you propose just disabling the autovacuum for this test.

Absolutely correct.

Best Regards,
Hayato Kuroda
FUJITSU LIMITED

view thread (4+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: RE: [PoC] pg_upgrade: allow to upgrade publisher node
  In-Reply-To: <TY3PR01MB988913BBE71B519F29AD041FF582A@TY3PR01MB9889.jpnprd01.prod.outlook.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox