public inbox for [email protected]  

help / color / mirror / Atom feed

From: Hayato Kuroda (Fujitsu) <[email protected]>
To: 'vignesh C' <[email protected]>
Cc: Peter Smith <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Cc: Bharath Rupireddy <[email protected]>
Subject: RE: Documentation to upgrade logical replication cluster
Date: Wed, 31 Jan 2024 06:12:17 +0000
Message-ID: <TY3PR01MB988921AFB207C42F354EDA79F57C2@TY3PR01MB9889.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <CALDaNm1G8pGY+W=fbMj3PPbpwUqexxQh3b8J=ON3jY0Nx4Ga9A@mail.gmail.com>
References: <CALDaNm1_iDO6srWzntqTr0ZDVkk2whVhNKEWAvtgZBfSmuBeZQ@mail.gmail.com>
	<TY3PR01MB9889BD1202530E8310AC9B3DF5662@TY3PR01MB9889.jpnprd01.prod.outlook.com>
	<CALDaNm2PD_eWLkLDs0qQ8MvWvh8j=hee4_n6MX6Zz=+Hosz=pg@mail.gmail.com>
	<CAHut+Pt2wS_VxMaU+fOcJ3LD438e1SahFMBkeVeFOY5fpcnu5Q@mail.gmail.com>
	<CALDaNm0ph5CFZ6ENL9EYiJhz3-xQMYx+UKWpFzggiLVfPKJoFw@mail.gmail.com>
	<TY3PR01MB9889B8A36DA929FD6561EACDF57B2@TY3PR01MB9889.jpnprd01.prod.outlook.com>
	<CALDaNm1wCHmBwpLM=d9oBoZqKXOe-TwC-LCcHC9gFy0bazZU6Q@mail.gmail.com>
	<CAHut+Pudr6H-MBurXXGpw-bkc0K9QPGPFr7khv7rVrQwEwByKw@mail.gmail.com>
	<CALDaNm2kgW9-XX4am1THzDhoUN8=f8kUMbYA6SkBu3jwL=__ew@mail.gmail.com>
	<CALj2ACWm6_6nesFkNvpxMKfwED5v6HJ1z8becjY4+hrRbbjm-A@mail.gmail.com>
	<CALDaNm1G8pGY+W=fbMj3PPbpwUqexxQh3b8J=ON3jY0Nx4Ga9A@mail.gmail.com>

Dear Vignesh,

Thanks for updating the patch! Here are my comments for v6.

01.
```
+   <glossterm>Logical replication cluster</glossterm>
+   <glossdef>
+    <para>
+     A set of publisher and subscriber instance with publisher instance
+     replicating changes to the subscriber instance.
+    </para>
+   </glossdef>
```

Should we say 1:N relationship is allowed?

02.
```
@@ -70,6 +70,7 @@ PostgreSQL documentation
    pg_upgrade supports upgrades from 9.2.X and later to the current
    major release of <productname>PostgreSQL</productname>, including snapshot and beta releases.
   </para>
+
  </refsect1>
```

Unnecessary blank.

03.
```
   <para>
-   These are the steps to perform an upgrade
-   with <application>pg_upgrade</application>:
+   Below are the steps to perform an upgrade
+   with <application>pg_upgrade</application>.
   </para>
```

I'm not sure it should be included in this patch.

04.
```
+       If the old primary is prior to version 17.0, then no slots on the primary
+       are copied to the new standby, so all the slots on the old standby must
+       be recreated manually.
```

I think that "all the slots on the old standby" must be created manually in any
cases. Therefore, the preposition ", so" seems not correct.

05.
```
If the old primary is version 17.0 or later, then
+       only logical slots on the primary are copied to the new standby, but
+       other slots on the old standby are not copied, so must be recreated
+       manually.
```

How about replacing this paragraph to below?

```
All the slots on the old standby must be recreated manually. If the old primary
is version 17.0 or later, then only logical slots on the primary are copied to the
new standby.
```

Best Regards,
Hayato Kuroda
FUJITSU LIMITED
https://www.fujitsu.com/ 

view thread (32+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: RE: Documentation to upgrade logical replication cluster
  In-Reply-To: <TY3PR01MB988921AFB207C42F354EDA79F57C2@TY3PR01MB9889.jpnprd01.prod.outlook.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox