public inbox for [email protected]
help / color / mirror / Atom feedFrom: Zhijie Hou (Fujitsu) <[email protected]>
To: SATYANARAYANA NARLAPURAM <[email protected]>
To: Fujii Masao <[email protected]>
Cc: shveta malik <[email protected]>
Cc: vignesh C <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Cc: shveta malik <[email protected]>
Subject: RE: [PATCH] Release replication slot on error in SQL-callable slot functions
Date: Fri, 29 May 2026 05:36:49 +0000
Message-ID: <TY4PR01MB17718C386870F9DAD4B0BF9BC94162@TY4PR01MB17718.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <CAHg+QDfF6-+2Tv3g3hkOFtcs24mKqPJnGpyEEDxwXMuE8WgDig@mail.gmail.com>
References: <CAHg+QDeuf9tCq3ce=kgFMJP0m=PZC+wi6B=yS+7V0vNXjLS31w@mail.gmail.com>
<CAHGQGwFZaWj8DctXuhWQZwSqi631=NKzQJyDV4yqT1Qapt8MFQ@mail.gmail.com>
<CALDaNm1Jjun=by60V-4EpLZe4pAKy0qVZ7ptyHGVCuDyKfo2xQ@mail.gmail.com>
<CAHg+QDcu2x0mjkBSqRxP_8EQ6UmpuX_jMgdKLDkAL1=N6wzZCQ@mail.gmail.com>
<CAJpy0uCmW_NUZN8mw26onvfoFzH_oMrFSKhLUhz896nDgf8c7Q@mail.gmail.com>
<CAHg+QDcf_9prAX=TaSO3UUiCLVD53bEw-KLqzAEXi+ud7h+Z4w@mail.gmail.com>
<CAJpy0uBShUF_xm0=BVWivpWHt-4zs__k_3wL1RRjpi0Av8nsog@mail.gmail.com>
<CAHg+QDf5PVyFgesBNs1GvOnuk_khoXifo96A7QW1EJ8zhhBxyw@mail.gmail.com>
<CAJpy0uCCqFLY7pu0RQVcS9fRr0FimFMuHPsMBQ-KzEGX3BEGPA@mail.gmail.com>
<CAJpy0uDHMvpUAdwXA3X7ugmO8S7kry-ZtrKUcugpX3WWp8hykw@mail.gmail.com>
<CAHg+QDdEGGQrmQXwH0_Y+DRe_tx5jxv9K+7vpCnooQn2_6QykA@mail.gmail.com>
<CAJpy0uBo-OuzyZZ=LY8L48Udt8=1Mffh2rrpXaTbKK_F9sJx7A@mail.gmail.com>
<CAHg+QDeKC=_31Fvs2pOVkJCdkpNuoJmLmXV5hOApStpODYWsXw@mail.gmail.com>
<CAHGQGwEoENMBTu0=f2h5_GFfTc-dGEo+_CfS0jinPwTX2AcyYA@mail.gmail.com>
<CAJpy0uB3sb2wfXaoYd8XnK53GcpTLW6BJLJve_K6JdNy8-dpgg@mail.gmail.com>
<CAHg+QDdYJ5+P=QpjvV-w3v7PgviQM5V2PgO5xbK58vd-RrAASw@mail.gmail.com>
<CAHGQGwFCLWw7nVYoR+9Z6DtzYNnDXv6YHseNRjaCXmdQsKnoWg@mail.gmail.com>
<CAHg+QDfF6-+2Tv3g3hkOFtcs24mKqPJnGpyEEDxwXMuE8WgDig@mail.gmail.com>
On Friday, May 29, 2026 1:11 PM SATYANARAYANA NARLAPURAM <[email protected]> wrote:
> Thanks for the patches, I combined these changes in my latest patch. Please find the v5.
Thanks for updating the patch.
Few comments:
1.
The patch places PG_CATCH() inside create_logical_replication_slot(), but the
caller may still error out before releasing the slot. It would be better to
catch the error at the caller level instead. The same problem exists in
copy_replication_slot(), which does not include the slot persistence logic
within its CATCH block.
2.
I have a concern about the LWLock handling added within the PG_CATCH block, see [1].
[1] https://www.postgresql.org/message-id/TY4PR01MB17718F04D32E0073F0BC7EC0294082%40TY4PR01MB17718.jpnpr...
Best Regards,
Hou zj
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: RE: [PATCH] Release replication slot on error in SQL-callable slot functions
In-Reply-To: <TY4PR01MB17718C386870F9DAD4B0BF9BC94162@TY4PR01MB17718.jpnprd01.prod.outlook.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox