Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kdSny-0006Ai-7P for pgsql-hackers@arkaria.postgresql.org; Fri, 13 Nov 2020 06:43:30 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kdSnx-00031P-63 for pgsql-hackers@arkaria.postgresql.org; Fri, 13 Nov 2020 06:43:29 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kdSnw-00031I-UD for pgsql-hackers@lists.postgresql.org; Fri, 13 Nov 2020 06:43:28 +0000 Received: from esa7.fujitsucc.c3s2.iphmx.com ([68.232.159.87]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kdSnp-00014H-Lh for pgsql-hackers@lists.postgresql.org; Fri, 13 Nov 2020 06:43:28 +0000 IronPort-SDR: B4rUuG2EKnwOP5FClSMjs4Z+a1zNYji4c4DJxxRJ4OT47oF2gFbNGRPtfy9sL5WeuLom6oitxH aQBr1OHc8K+38i+s2I+K4bKLPxqsY9GMkmoe0BxIZZbd/6xHBU9SWxqROSzjbfMwxw8Ir1dpXL 3NZ8oSNruLTrM5Z/zG4bya4nqpVxOPUUsK8dSmfCyZ5c06p6+oRHJZhGGhRqp0Ar7VN9vJPotd hatut3qJfbG2kuiatFSPiEl2lYiDV9sh0wcR34uS/gctrtmMLDS51t3nzyn+w3v+JBTpFnNvRq 1nQ= X-IronPort-AV: E=McAfee;i="6000,8403,9803"; a="21095396" X-IronPort-AV: E=Sophos;i="5.77,474,1596466800"; d="scan'208";a="21095396" Received: from mail-os2jpn01lp2058.outbound.protection.outlook.com (HELO JPN01-OS2-obe.outbound.protection.outlook.com) ([104.47.92.58]) by ob1.fujitsucc.c3s2.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Nov 2020 15:43:17 +0900 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OrowlyQvQUjp4UDPFAjeFEM6ETA+1QN3ybJU1hvHMKdGf+IwRtKmHk8mx6OEKc3KiCvjCaBfu9QBtpLqxdIMysGEWYXRHA+kJB41cd8FcNreCt3X/MuEBomlM+ekI9Min9+XXhUIYzhmDyCgT0A19x89qbUdhAYNFgsPBK+V9ex00mEycj40a68k+xhlp6QTUA0eQwQOyYd3+zGrk8/HoyLXo+UP4MDPlru/XEkgPvTDb3HWbpMBeqLJQLBpW0+L9MMY24rB9COaJrnWtkM9tIwV8jdKSuUX+P0jCUzB+xsr+y9j05OfMbK0EqON1O7JB+6Sz2dA68ETqx81wnLrLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Rbbm6lauersBTdzDX0ERyNcXrP8rEe6IaAHiYpu84fc=; b=PR9m3Wk65uVzf2Z9Bg9SJwrtpUGUVk4qnkSr5z5kua9zcryfRAp1z3GQ9k/XKLy38A9PfHoj7qVCm9tDX+MRRmGTbYXz2NEWea2CZWss/xpOr6PmlSiHShfrDtLjJTJTk1J20hdDL6blSlBBQYrEwhQm06CNoT5A8VARB+84aFb2QPyAItVICAZBAJFfyC7oKxSYw0b0kEzNmgFM3NVwa1x/qqpDHHNMyWBH1BX5TM9k5wSJlcKK6ZurjxONofEH5OySsVT51rGtITrFFmOOan0P1NvZWTbeYqMSWoJ6x4UH0LJCz5gxk/H/G/Q2ZtJBUnJKD+6ZGrdVGYVeTUGWSw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=fujitsu.com; dmarc=pass action=none header.from=fujitsu.com; dkim=pass header.d=fujitsu.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fujitsu.onmicrosoft.com; s=selector2-fujitsu-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Rbbm6lauersBTdzDX0ERyNcXrP8rEe6IaAHiYpu84fc=; b=LFINlNMsv60sXynnt/skVVufqGiyTNTFerGYTXRXsNLmj2ILxImShBjnh4S3tv3gtOl7aDLEbPq32xm63xN2UdkMXKPFr4x0xt/28KwNWnl94LgGXeZm6gSaKxbeGYXL01mgerciR3pVpmtTqXn561kXMjO13QQmqIKCs2Sl/14= Received: from TYAPR01MB2990.jpnprd01.prod.outlook.com (2603:1096:404:86::19) by TYAPR01MB4862.jpnprd01.prod.outlook.com (2603:1096:404:12a::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.22; Fri, 13 Nov 2020 06:43:13 +0000 Received: from TYAPR01MB2990.jpnprd01.prod.outlook.com ([fe80::ad26:4de1:1519:675c]) by TYAPR01MB2990.jpnprd01.prod.outlook.com ([fe80::ad26:4de1:1519:675c%7]) with mapi id 15.20.3541.025; Fri, 13 Nov 2020 06:43:13 +0000 From: "tsunakawa.takay@fujitsu.com" To: 'Kyotaro Horiguchi' CC: "osumi.takamichi@fujitsu.com" , "sfrost@snowman.net" , "masao.fujii@oss.nttdata.com" , "ashutosh.bapat.oss@gmail.com" , "pgsql-hackers@lists.postgresql.org" Subject: RE: In-placre persistance change of a relation Thread-Topic: In-placre persistance change of a relation Thread-Index: AQHWuAVWpBgdNJT6dUCBfvr3Pw06w6nFeQaAgAAkKrA= Date: Fri, 13 Nov 2020 06:43:13 +0000 Message-ID: References: <20201111.173317.460890039962481381.horikyota.ntt@gmail.com> <20201113.132201.148696021363404735.horikyota.ntt@gmail.com> In-Reply-To: <20201113.132201.148696021363404735.horikyota.ntt@gmail.com> Accept-Language: ja-JP, en-US Content-Language: ja-JP X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=fujitsu.com; x-originating-ip: [218.44.52.179] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 43455027-a360-4b01-a2c9-08d8879f6525 x-ms-traffictypediagnostic: TYAPR01MB4862: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3173; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3zUnB0f9h+KS21X2LIu9yFxcSXJbqqKS7bCsFmzsNe9vttCS2HLrUOni4BOQxv6qugHaCe9t2uNvJzV1/o1QzysoKhwsL3U4SAuV7YoPbyC21UQh2sJN30XLK0PWUTmkrNh16S4Q2/3QCrfXNTedDzzq1oqgaddWdjbG6PLZJ8qw23Wx7ex73zaWz+kPo92u9D/Mbj5NXZtjx37mlryRu+ncLkyr5Ot/6dKJXvIPdebw3cRw0CmYV6/z//+moA1xJtRByN44a7FgiBx1N9gK8st1ZEcNRDZbDKrxM25DGRVJleGrS+QSD2KLIlWH9MBC0YIEH8osi1vVIhxbMbRP/Anyo676i/m0e9LHhu8GF9H+MsLto3NaInnmhHhL3fQy x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TYAPR01MB2990.jpnprd01.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(396003)(39860400002)(346002)(366004)(376002)(8936002)(2906002)(55016002)(33656002)(186003)(52536014)(6506007)(8676002)(4326008)(85182001)(6916009)(4744005)(86362001)(5660300002)(26005)(7696005)(71200400001)(9686003)(54906003)(316002)(66446008)(83380400001)(66556008)(66476007)(66946007)(64756008)(76116006)(478600001)(777600001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: +K8AVxUJO2oGlshD4ADpCbUsUbu5ELIeHuLcfX8oqynUz5dnRoVEH8VW5cb/cnSEYeDKpVhgiziFYd5VcOs2OtEd80b08R/e7uj5W0vUeiVWEJfMc4d0IV1cVqF5fQwlgVoIb8Os6PZzZdS3h3IvjPx4GY7oIzgqJJE9XJS4ikRGNIZm+CY2cOgrg9tAjxEW5SgsqQzz+cibrBjnH5jcUmwqW9eQOn6kEilSk29bXNhAALvJIoV6n2tgricKcYtvgiMV6kJA1SL7WgbSndEQ5Wur9n1Tz6NdIsYmtYrHA0mux5/8zqwsjnYMAS99rx3o24MsqO0IQIfeBW4zV8UjIKAqXDiOVxfXe6fZnHAqNQBF8LG7Y/FgFmBzZAEc8f1jGXZMLzW0w3zPbWqrFqUJO/5BPvpV7d5hTAzC7jmFcRZeRNc5QfCnWsEZRjo0UcSfeP5XYNIZIAuf2fivBSJVmg4kwWFdErnKV/DdHJP0KnbirgtZmjdb33rGennOKdkZjnaHMIfE9k2j+waew7z2lEs/q1YWEhZnSoS3X8314BmuhwJ3uaZMxpAiAtdNZcZ/5Mmi+gO7T1eVUOqQ+9lEUiqQ8ObjvBTZMkT1aXjHaWzX/pHs6xZ9yKBytXVoSYYKckBXQBgw0ELqB5q1H9WsthsUV6rSNxqonrKtyitFbcEcDZWD35Qt5uEiUDhv5R9PsnaW6cORKQXKtuZAmiR+2RIcxBd02VZVJ5lEnyRy2mRU0/JUv9ifcyLNz8p3VAsmxqv8cUgqhrM1tBnKx07n2KAkzD7q1VA6XEKEEiKPtj2QOyzRR31Dggj1YF6BohDrrbFomDNI0n5YeN3m1V4ff7neqZRciu1KOmmVvXb1/Zx0LKxD69xctcX93iA3EdkZVZqgV6sKLO+Qe2ER/dUrjA== Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: fujitsu.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYAPR01MB2990.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 43455027-a360-4b01-a2c9-08d8879f6525 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Nov 2020 06:43:13.8470 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a19f121d-81e1-4858-a9d8-736e267fd4c7 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3XqO9BVWIHPfvRw1QmoAdK+1+siY7vGVE0AGcHNrt/WHwIdq04FJ+zDZ2jMMdCE8F6jrAUXF4G90YLeu0ZjoMa7400gWV4KwTa6HaG1Gt1k= X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYAPR01MB4862 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Hi Horiguchi-san, Thank you for making a patch so quickly. I've started looking at it. What makes you think this is a PoC? Documentation and test cases? If ther= e's something you think that doesn't work or are concerned about, can you s= hare it? Do you know the reason why data copy was done before? And, it may be odd f= or me to ask this, but I think I saw someone referred to the past discussio= n that eliminating data copy is difficult due to some processing at commit.= I can't find it. (1) @@ -168,6 +168,8 @@ extern PGDLLIMPORT int32 *LocalRefCount; */ #define BufferGetPage(buffer) ((Page)BufferGetBlock(buffer)) =20 +struct SmgrRelationData; This declaration is already in the file: /* forward declared, to avoid having to expose buf_internals.h here */ struct WritebackContext; /* forward declared, to avoid including smgr.h here */ struct SMgrRelationData; Regards Takayuki Tsunakawa