public inbox for [email protected]  

help / color / mirror / Atom feed

From: Hayato Kuroda (Fujitsu) <[email protected]>
To: 'Tomas Vondra' <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: RE: Fix for pageinspect bug in PG 17
Date: Thu, 14 Nov 2024 02:56:45 +0000
Message-ID: <TYAPR01MB5692A621179C18A8FDB3AE60F55B2@TYAPR01MB5692.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<TYAPR01MB56926215D57A11B12F9E7DA3F5592@TYAPR01MB5692.jpnprd01.prod.outlook.com>
	<[email protected]>

Dear Tomas,

Thanks for updating the patch.

I've tested new patch and confirmed the brin_pgage_items() could error out:

```
postgres=# SELECT * FROM brin_page_items(get_raw_page('foo_id_idx', 2), 'foo_id_idx');
ERROR:  function has wrong number of declared columns
HINT:  To resolve the problem, update the "pageinspect" extension to the latest version.
```

I also do not have strong opinions for both approaches.
If I had to say... it's OK to do error out. The source becomes simpler and I cannot
find use-case that user strongly wants to use the older pageinspect extension.

Best regards,
Hayato Kuroda
FUJITSU LIMITED

view thread (6+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: RE: Fix for pageinspect bug in PG 17
  In-Reply-To: <TYAPR01MB5692A621179C18A8FDB3AE60F55B2@TYAPR01MB5692.jpnprd01.prod.outlook.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox