public inbox for [email protected]  

help / color / mirror / Atom feed

From: Hayato Kuroda (Fujitsu) <[email protected]>
To: 'Amit Kapila' <[email protected]>
To: vignesh C <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: RE: Make default subscription streaming option as Parallel
Date: Tue, 22 Oct 2024 10:54:15 +0000
Message-ID: <TYAPR01MB5692E9FE75770EE171CA9D61F54C2@TYAPR01MB5692.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <CAA4eK1KoF9qNU4r7UOYv+asisi0eFNqTX8EqX9ba_-Oo5gWt2w@mail.gmail.com>
References: <CALDaNm1=MedhW23NuoePJTmonwsMSp80ddsw+sEJs0GUMC_kqQ@mail.gmail.com>
	<CAA4eK1Keu9jiJVCRac7a77+q29z8pGiJQocPO26uqAkdSEyVRg@mail.gmail.com>
	<CALDaNm1Wz91NZwMUgypuMNi9BQFVLT4Dg1TtO4zHo3nR+4ZRZA@mail.gmail.com>
	<CAA4eK1KoF9qNU4r7UOYv+asisi0eFNqTX8EqX9ba_-Oo5gWt2w@mail.gmail.com>

Dear Amit, Vignesh,

> 1. Please ensure that none of the existing tests that use
> subscriptions with large changes will be impacted due to this change.

I found at least 022_twophase_cascade.pl should be fixed.
The file has a part which tests non-streaming case:

```
# -----------------------
# 2PC NON-STREAMING TESTS
# -----------------------
...
$node_B->safe_psql(
	'postgres', "
	CREATE SUBSCRIPTION tap_sub_B
	CONNECTION '$node_A_connstr application_name=$appname_B'
	PUBLICATION tap_pub_A
	WITH (two_phase = on)");
...
```

I know the streaming actually does not happen because few tuples will be inserted
later, but creating as streaming=parallel is bit misleading.

I checked other files as well but I couldn't find what we should fix.

> 2. The pg_createsubscriber utility uses CREATE SUBSCRIPTION statement
> and after this change, it will enable parallel mode by default which I
> think is a good idea as users won't need to do that manually after
> running the tool. Do you see any problem with this?

I also think it is okay. IIUC, there were no specific reasons to create
subscriptions with streaming=off, it was chosen because it was a default.
I cannot find strong reasons to keep current behavior.

Best regards,
Hayato Kuroda
FUJITSU LIMITED

view thread (6+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: RE: Make default subscription streaming option as Parallel
  In-Reply-To: <TYAPR01MB5692E9FE75770EE171CA9D61F54C2@TYAPR01MB5692.jpnprd01.prod.outlook.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox