Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ql8Ip-001LjG-Ps for pgsql-hackers@arkaria.postgresql.org; Tue, 26 Sep 2023 13:40:40 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1ql8Im-00C4qL-PO for pgsql-hackers@arkaria.postgresql.org; Tue, 26 Sep 2023 13:40:36 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ql8Im-00C4q2-9X for pgsql-hackers@lists.postgresql.org; Tue, 26 Sep 2023 13:40:36 +0000 Received: from esa6.fujitsucc.c3s2.iphmx.com ([68.232.159.83]) by magus.postgresql.org with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ql8Ii-007gi6-Nd for pgsql-hackers@lists.postgresql.org; Tue, 26 Sep 2023 13:40:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=fujitsu.com; i=@fujitsu.com; q=dns/txt; s=fj1; t=1695735632; x=1727271632; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=mENKTju3E2pOexEiWrS/hOAkY+SB/isi1IYzA4i9i7I=; b=HmEO8POY1abB4KotITKCHidJnY4zny4RSpFylZrk63vAHvKe/LIpUjOz 2SQLIT/XqtzbdNl/J76krui6osMFo6vn7+PQqyzXnTvVhSlJjCCW7bB5Q CGiVw6DWO1AHTNLuvgfueoDUbD5ZejD5WjiS8tB7OjyCNZNFYc6NDWAZO WTa6m8zTI+QoEymDkzL/CkDpGNKCvNXjv8KjaLcH37A/YxRyGxtPBRRR8 GK+wvAyVxALa8K87iAEfod+CbCzDetAZ04xvEI+0avhNFhK8FOsEGuN0t Z/H5G//eaRZq/abg5xJPrJqtKdMg4yQ4NfR9DSF6H7OQOu48ryJeoWGlU A==; X-IronPort-AV: E=McAfee;i="6600,9927,10845"; a="96762163" X-IronPort-AV: E=Sophos;i="6.03,178,1694703600"; d="scan'208";a="96762163" Received: from mail-tycjpn01lp2171.outbound.protection.outlook.com (HELO JPN01-TYC-obe.outbound.protection.outlook.com) ([104.47.23.171]) by ob1.fujitsucc.c3s2.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Sep 2023 22:40:29 +0900 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bwBkLXYBk63nAZLs+2RuA6uJbWs/W2aPzuW9A0+gxm+XfimeMv8rI+k6wXC3rJn41I0Yy6FMzSZQWtqeT3pZLR20rOxdmkp9Akl1F4Y9rZUkFRv2Hh/s6CMmt5biV2vsD4mVfwHs9gfROGy56w3uLMAIPub+PQ7CrLUP2QzS+61VXcM9AeCnl4Dyn9JzkMhhKPJ7H1gbEf7ufA7xUt5YGHhsBXEl35V92qqdAxBjiD13BOieQBUG/j/FnixHEV45kZAPo7tvbWjSM3eXzGspb+ltbbrAK/zlpk7dseR5iUkG2XDvhwmHIftYkhxm0Iqs6HqJZd9+DzMoQ77Xi4VEtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5h0GUVR4i/BfyMUNY4JnwIziRoxc/QRwj1QWwZllZuM=; b=B9EoTR49I7Fx1+lfFeVGVbAMDs4FeOfQDSl2zjzYxsuNyDpirXQjzQjepEWb9VkuwfDbS2h6QeXAmcUzvpkeLYhoxeCVynNmwSb94gKjIwYQxZRAFTAJ2uPKl8KPP533m/6zdCBmLLZXEeov4uIXgSOnCZz29mbMSR6UET9YwJj5ofTUL6k5zHqLMB/jFhivOPvgPVefBwkiSJq9E35jgA6Je/0mYHzzIGj9L3t96quEk/H4El2OCeW+bF2KV3a/2fTbrl/mc3E2NnSt/0JbrTsVk2l+uOyTVh+ZWpYYgy3n8WjU+A+BbXIJVu7EtxtkBiWogceUH+eLDnrfgsXCMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=fujitsu.com; dmarc=pass action=none header.from=fujitsu.com; dkim=pass header.d=fujitsu.com; arc=none Received: from TYAPR01MB5866.jpnprd01.prod.outlook.com (2603:1096:404:8056::13) by OS3PR01MB8017.jpnprd01.prod.outlook.com (2603:1096:604:162::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6813.28; Tue, 26 Sep 2023 13:40:26 +0000 Received: from TYAPR01MB5866.jpnprd01.prod.outlook.com ([fe80::9437:7145:f0cb:d683]) by TYAPR01MB5866.jpnprd01.prod.outlook.com ([fe80::9437:7145:f0cb:d683%4]) with mapi id 15.20.6838.016; Tue, 26 Sep 2023 13:40:26 +0000 From: "Hayato Kuroda (Fujitsu)" To: "'Karl O. Pinc'" , 'jian he' CC: Postgres hackers Subject: RE: [PGdocs] fix description for handling pf non-ASCII characters Thread-Topic: [PGdocs] fix description for handling pf non-ASCII characters Thread-Index: Adml27qfKI1jGvH7Thyjah7K3JC7vgEWdaSAAALdfxAA2fyjAAAbgxqQEIoJOwAADpNyAA== Date: Tue, 26 Sep 2023 13:40:26 +0000 Message-ID: References: <20230926010328.2c556046@slate.karlpinc.com> In-Reply-To: <20230926010328.2c556046@slate.karlpinc.com> Accept-Language: ja-JP, en-US Content-Language: ja-JP X-MS-Has-Attach: yes X-MS-TNEF-Correlator: msip_labels: MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_ActionId=04cd0120-1a44-4d54-a322-e6bf03dffee5;MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_ContentBits=0;MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_Enabled=true;MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_Method=Standard;MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_Name=FUJITSU-RESTRICTED?;MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_SetDate=2023-09-26T13:02:19Z;MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_SiteId=a19f121d-81e1-4858-a9d8-736e267fd4c7; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=fujitsu.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYAPR01MB5866:EE_|OS3PR01MB8017:EE_ x-ms-office365-filtering-correlation-id: 2669343c-77a4-4f17-2a1c-08dbbe962415 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: yLmZlsNNhwtms/+vMnZdW1M2zt9ETmbylQuVNAkg9OV5g4xIl/RS0hIZAlAi4qlnsJCyeDe4AlDdu7Pri/4JSKw+U2j1ALIqBBducw+yaB2wsN3Sy7z7o2Q7FtjFFS+4XoLrpup/OLjGGTrGbfOskYnPwfoKcZXgIMhvQaJAPX4BYuezl3CH0Ndcvky90UCE+7UriFjy8MWZualKdQpjXcPGgcYXGjm5OhsT67tRKNEOdOKP3muAGoTdfIzLOVSKd4Dj8vdrJKoYafp+zsbc/ctWNOHEBj36+eF6a4BQzThHfBhoGeNa1frT32Q3+8z30l2+RBX/1U5RqbKG+/21twtRoOmJZjptXb537nDdM04paRIKprjBKeNTY/MpVjo4Ta8znDPwCRPNeLmppg36z/qgOVj3/WtODH4nOkzaA/zeldbU76uN0IlqpgrlivLMwPG0DSXFbJZFsy9ZGnDRqPu8aH7AchZQHO4mGbeyTpWbgWpLuMIPcGhNd8VwXJbxvbX3YUdP3yEQJedUb6dD0UvEF10A+ll/o9J26lN87APNEphHCHNEfwFH+oOvg49Mtx2yOvBPFwXPWKqYyhzJ1/nKoeXbEmKqZ1qIIHHaarGktDCbBeLy0zuJzLLmWpANnmNxzex0pzyIsob1gzbc5A== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TYAPR01MB5866.jpnprd01.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(346002)(376002)(136003)(366004)(39860400002)(396003)(230922051799003)(186009)(1800799009)(451199024)(1590799021)(9686003)(2906002)(8936002)(8676002)(85182001)(26005)(6506007)(33656002)(7696005)(71200400001)(41300700001)(38070700005)(966005)(478600001)(52536014)(82960400001)(316002)(4326008)(86362001)(38100700002)(64756008)(66476007)(66946007)(66556008)(122000001)(99936003)(76116006)(66446008)(110136005)(5660300002)(55016003)(83380400001)(1580799018);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-2022-jp?B?ZG4wNUl2dXFFN091SnVoV0wrZE9GVEgrdWYzMVgxUDJPdUNNOVVsRjZ6?= =?iso-2022-jp?B?cHlSWW5mK3NqTVR1bisrSHVzR2tEd1RxNW85UG5EcE5DUEtiOTRnSHZa?= =?iso-2022-jp?B?Y3p4WHVTYm4wV1owZUZPNTJuVUREZTVFMTFGNFdSakZOUU45S3psbnVD?= =?iso-2022-jp?B?c05BNDJxa1VSMWlhSWIyR3M3bmtrTEMwRTBFRERBWFYzOStZRW04VDRk?= =?iso-2022-jp?B?dWpFejgyd1Nwb1V3OVR2WCtxOXJHWFlvdGZMQVVtb082R2NQOGJ2eEtH?= =?iso-2022-jp?B?djZ0WHBzU1NEdk5jaVE1RXZzNU1RRk9zVnMxalpSUS9tWFgzdjF6a0wy?= =?iso-2022-jp?B?WjdBaENURUhoWmNzQ2VoVklIL1BVTHJEcHpKRVVkN3B2cTBxZ0k4R29o?= =?iso-2022-jp?B?SzJGeGRHdXVrNjJoanFST2lqR0RTNVN3UFFKMVMrN3VoSVBTWmVVUy9u?= =?iso-2022-jp?B?aVltOThuV1pCbWE5TTRyYVRteFl2S3JLZjh6Q1d0SWlENE12REY0RXBV?= =?iso-2022-jp?B?R3M5RzVDYm9LSkFvZ2hRTGZhaFQvYi9iU1ZkTTZQVElDZ3k4ZkNPNXM2?= =?iso-2022-jp?B?Y3MrZFVRbVZHQUxRajAxK3JFQ2Zadkh1cTVXd2IrZmZGSm5lZWxNaVBM?= =?iso-2022-jp?B?Z0xrNGpNbHBiVHNrcVA3MGhMUFpaKy90RGJZbFFwdGJZZEhhL0ZZUXZp?= =?iso-2022-jp?B?UklMWlRrdnpIZUpwbnNHcStBQVBqT3FyRkNBNXNtZnBBdjFHWm5JaWVo?= =?iso-2022-jp?B?K0c1dUI5b2xVcjNEZG50RUhVZmZsVHk4NFBnZnBSVGNmTERoaEx2M1U3?= =?iso-2022-jp?B?SnRVY3ZsN2Q3Z25vM3V4QUx2aCs0MU8wUmJSczNEYW5yTTNLeTJVaXU4?= =?iso-2022-jp?B?OTExUXZSc1VwYU10SElrSUsyZVlFSEZHSDlpYjdlTGd3NTZJQTNhSWFi?= =?iso-2022-jp?B?Y1JwT1lZNUE2cWRqUXF1c2JvcUd5ZmtYLzFSYUpzUlVkWVNubEZ1cHZ1?= =?iso-2022-jp?B?ckNUeklOcGpkWnZmeXV3UjU0aTlzckhBTkc2WWRXYmtsQUpsbUhxTWFT?= =?iso-2022-jp?B?OStLaFNYbVpTanE2aGZ4YzJKVTdmR0Qzd2p4UDFlRWd6WitRWlpyTXdo?= =?iso-2022-jp?B?TDVCajRyODAyY2lNNVgyZkFoZlZPY2NBMFVCc1pjOWEyQW8ydkx2a0JK?= =?iso-2022-jp?B?NGdWZWFSMTlETWVLLzhWUUhYb1Q0T0h0R1V3UXYyV1ZsUERxQm9xQ1lV?= =?iso-2022-jp?B?RG1zcjBzTHoxZWY0VkYrVHliZnB4QTk2RmdqYkk2RXhOMnl5cHNQam13?= =?iso-2022-jp?B?QWlHUFcrbGM4TFNVeER2OG8ybTBwdW90WE93cExadTlWV1BJeWRLVnpK?= =?iso-2022-jp?B?QUlsNzYrR0NhYmpJSmdzWkdobG1HUE5iblNSNDhiWXdYSTVIejQzd3lM?= =?iso-2022-jp?B?eXVtRFJvUkllc2FBelNOMllNWE5XMnRhdTZFRlBBMVVoRVBzMHlCWTgr?= =?iso-2022-jp?B?eE44cmxHOTZiaHdVdDluSnFCTGN4RlB3dFpMalp2dTlIZ0xLclJUN1B1?= =?iso-2022-jp?B?WmRHMDlYU1g1bEp6VnF0RFgzYXYrbHI2U2trOUhvcTZMQysxdWd6Q21T?= =?iso-2022-jp?B?OWtHSEI3SXlxRnpGcy9sMEx2YzBiMXRROWpKNlM5enVXU0l1UCtHdlhJ?= =?iso-2022-jp?B?QmpObkZCTDNPdzhXZ1IxVThOekx2ajhwV0NNTHNsRHBDYStkbFlQSG1J?= =?iso-2022-jp?B?OFlWcGFTYUY2RUo1eEt6c2NjZmNYMkFzWlJhSzlWczJsNVFEalM0akNp?= =?iso-2022-jp?B?ZjhTTlJ2Z09Ham9XSmxDNDdLY0ZZSkMweVVWTGluNkhBZGczeDF2d29m?= =?iso-2022-jp?B?alVJRVkvN3FOUFdOZklPVGF1M2VkRHVLN0k5M0s1MU5zb3NsK1Evd3Zj?= =?iso-2022-jp?B?ZERRN21FNlUwVDdEM3RRTjJwbFVZODhMZ1JsTUoySTRJZUh0emMrdDdp?= =?iso-2022-jp?B?RDBTbTk0VnpSME8zNzkxb3BiQlJOUUNFR1hFNFZ1VHJzMzBGQldvbXl1?= =?iso-2022-jp?B?S0VSQ2V3MS81WjM4T05VNlRmNEdDNUtyQ21reEl3VUFwaXErVTVGTmJ3?= =?iso-2022-jp?B?VElYS2JTU2x1dnduSENtckJuUXM4MDBmY0ttZisrb0VNaUtETEEyTUZB?= =?iso-2022-jp?B?NFNyb21wZ2FlRnhqMFMzUnYvenRCczRtZElNeXhnRVBxSCtIY0NjeHUx?= =?iso-2022-jp?B?cmp1aWdhZ2xMYURsTTVpdmkvWjdUQ1BmV2VkUEk3NnJpbzhTS0E4Q3pL?= =?iso-2022-jp?B?blpCUHhoUCtBRmV6aThNaldSdTczRjFhOGc9PQ==?= Content-Type: multipart/mixed; boundary="_002_TYAPR01MB586607D53C42E59DBB00FD9AF5C3ATYAPR01MB5866jpnp_" MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: oqdd5yQzJz4KxkcTJ9Qrda4gIqRyJez7pGkNd30hPtfYJbIl4ANK+KmvpiCui1hdQc34L5bRCNYron1BQabt0u489O5/SN7DPmZSu8a6Al0PRIWhZzsnKb73NAPvthfQwM0hxa5zLM8w97VyL2wJQcxRYuxQdNQPelkuaiFdxa+v4pct2VUI2H/L4rr6RwURP/kLiMvx3GrHtbkWwmjBL2KcS1ypEVyZRd7zUkmEQIfh76HfLppxK6eXInaKz0HYdVXZx/bl2G9AlbQdgf+vLC7vdI5QFG2OcTKu0qtARbFyD8C+fZ2hhsTBx+XPBCXAV6h42v2jhENMy7jGbeG0NrBfMqbFpM0KoW9z11RwylfeklXp1TjwMrR9E2xUY+O1TI9kjMxU+ePE0G5/b+atQWJQu4oWeQwAw6j2LQfKpamEoVVReBiqRUGcbcHDJyqVizOOuqcb1AYcg+ta/DRBhT00J+7qbxUi9hmfuRARsWZ7elHVjOgpNbpLlPMT2X/r8ebM5trCDxUwWV7cew7jBzs4bOQEd4tH4qKM+ryUtXhRDP1XuL5J9Gzk5Bm9fX0fiYdulitqVg9LgTiwFx/S6xP9g2/hxyP1JG/81oJopt86VMN3hfoa4lba1Ioov1wfMqTtOV0zoa73HKzEF7TRWsamHiv/zs3xQt80R3mzZlwKI+YJqL7VQSoQ+YzcLJmn/FOJDFFdQWWPz2Nj5yO6RYycoTtZDyzlnijM9H6bF8wmCkWFrA4DbNmVC6pZsFgKJWgsVCUOUwKZCW02Jfp2DkKSjZAyurkd4qfD64A6fH0913dWHD6vuuxlV9vLBJEhCEkRJp1YPLHGAgugwN/S43l20uxCFaAzZxN4fEmyimI= X-OriginatorOrg: fujitsu.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYAPR01MB5866.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2669343c-77a4-4f17-2a1c-08dbbe962415 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Sep 2023 13:40:26.2283 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a19f121d-81e1-4858-a9d8-736e267fd4c7 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 2w0ECGh+RqgVDQ7ok5FdAwyx02JdrTVsRcVgf1+mD2r7a+9G6aMTWOUqi0Ks2WAwZp683gvraSA+fw5li+B1sMGj6vLHCn61NTIPOzUp7KE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS3PR01MB8017 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --_002_TYAPR01MB586607D53C42E59DBB00FD9AF5C3ATYAPR01MB5866jpnp_ Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable Dear Karl, Thank you for reviewing! PSA new version. > I see a few problems with the English and style of the patches > and am commenting below and have signed up as a reviewer. Your effort is quite helpful for me. > At > commitfest.postgresql.org I have marked the thread > as needing author attention. Hayato, you will need > to mark the thread as needing review when you have > replied to this message. Sure. I will change the status after posting the patch. Before replying your comments, I thought I should show the difference betwe= en versions. Regarding old versions (here PG15 was used), non-ASCIIs (like Jap= anese) are replaced with '?'. ``` psql (15.4) Type "help" for help. postgres=3D# SET application_name TO '=1B$B$"$"$"=1B(B'; SET postgres=3D# SHOW application_name ; application_name=20 ------------------ ????????? (1 row) ``` As for the HEAD, as my patch said, non-ASCIIs are replaced with hexadecimal representations. (Were my terminologies correct?). ``` psql (17devel) Type "help" for help. postgres=3D# SET application_name TO '=1B$B$"$"$"=1B(B'; SET postgres=3D# SHOW application_name ; application_name =20 -------------------------------------- \xe3\x81\x82\xe3\x81\x82\xe3\x81\x82 (1 row) ``` Note that non-printable ASCIIs are also replaced with the same rule. ``` psql (15.4) Type "help" for help. postgres=3D# SET application_name TO E'\x03'; SET postgres=3D# SHOW application_name ; application_name=20 ------------------ ? (1 row) psql (17devel) Type "help" for help. postgres=3D# SET application_name TO E'\x03'; SET postgres=3D# SHOW application_name ; application_name=20 ------------------ \x03 (1 row) ``` > Now, to reviewing the patch: >=20 > First, it is now best practice in the PG docs to > put a line break at the end of each sentence. > At least for the sentences on the lines you change. > (No need to update the whole document!) Please > do this in the next version of your patch. I don't > know if this is a requirement for acceptance by > a committer, but it won't hurt. I didn't know that. Could you please tell me if you have a source? Anyway, I put a line break for each sentences for now. > diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml > index e700782d3c..a4ce99ba4d 100644 > --- a/doc/src/sgml/config.sgml > +++ b/doc/src/sgml/config.sgml > @@ -7040,9 +7040,8 @@ local0.* /var/log/postgresql > The name will be displayed in the > pg_stat_activity view and included in CSV log > entries. It can also be included in regular log entries via the linkend=3D"guc-log-line-prefix"/> parameter. > - Only printable ASCII characters may be used in the > - application_name value. Other characters > will be > - replaced with question marks (?). > + Non-ASCII characters used in the > application_name > + will be replaced with hexadecimal strings. > > > >=20 > Don't use the future tense to describe the system's behavior. Instead > of "will be" write "are". (Yes, this change would be an improvement > on the original text. We should fix it while we're working on it > and our attention is focused.) >=20 > It is more accurate, if I understand the issue, to say that characters > are replaced with hexadecimal _representations_ of the input bytes. > Finally, it would be good to know what representation we're talking > about. Perhaps just give the \xhh example and say: the Postgres > C-style escaped hexadecimal byte value. And hyperlink to > https://www.postgresql.org/docs/16/sql-syntax-lexical.html#SQL-SYNTAX-ST > RINGS-ESCAPE >=20 > (The docbook would be, depending on text you want to link: >=20 > C-style escaped hexadecimal > byte value. >=20 > I think. You link to id=3D"someidvalue" attribute values.) IIUC the word " Postgres" cannot be used in the doc. Based on your all comments, I changed as below. How do you think? ``` Characters that are not printable ASCII, like \x03, are replaced with the PostgreSQL C-style escaped hexadec= imal byte value. ``` > @@ -8037,10 +8036,9 @@ COPY postgres_log FROM > '/full/path/to/logfile.csv' WITH csv; > The name can be any string of less > than NAMEDATALEN characters (64 characters > in > a standard > - build). Only printable ASCII characters may be used in the > - cluster_name value. Other characters will be > - replaced with question marks (?). No name > is shown > - if this parameter is set to the empty string > '' (which is > + build). Non-ASCII characters used in the > cluster_name > + will be replaced with hexadecimal strings. No name is shown if > this > + parameter is set to the empty string '' > (which is the default). This parameter can only be set at server start. > > >=20 > Same review as for the first patch hunk. Fixed like above. You can refer the patch. > diff --git a/doc/src/sgml/postgres-fdw.sgml > b/doc/src/sgml/postgres-fdw.sgml index 5062d712e7..98785e87ea 100644 > --- a/doc/src/sgml/postgres-fdw.sgml > +++ b/doc/src/sgml/postgres-fdw.sgml > @@ -1067,9 +1067,8 @@ postgres=3D# SELECT postgres_fdw_disconnect_all(); > of any length and contain even non-ASCII characters. However > when it's passed to and used as application_name > in a foreign server, note that it will be truncated to less than > - NAMEDATALEN characters and anything other than > - printable ASCII characters will be replaced with question > - marks (?). > + NAMEDATALEN characters and non-ASCII > characters > will be > + replaced with hexadecimal strings. > See for details. > >=20 > Same review as for the first patch hunk. Fixed like above. > Since the both of you have looked and confirmed that the > actual behavior matches the new documentation I have not > done this. I showed the result again, please see. > But, have either of you checked that we're really talking about > replacing everything outside the 7-bit ASCII encodings? > My reading of the commit referenced in the first email of this > thread says that it's everything outside of the _printable_ > ASCII encodings, ASCII values outside of the range 32 to 127, > inclusive. >=20 > Please check. The docs should probably say "printable ASCII", > or "non-printable ASCII", depending. I think the meaning > of "printable ASCII" is widely enough known to be 32-127. > So "printable" is good enough, right? For me, "non-printable ASCII" sounds like control characters. So that I use= d the sentence "Characters that are not printable ASCII ... are replaced with..."= . Please tell me if you have better explanation? Best Regards, Hayato Kuroda FUJITSU LIMITED --_002_TYAPR01MB586607D53C42E59DBB00FD9AF5C3ATYAPR01MB5866jpnp_ Content-Type: application/octet-stream; name="v3_doc_fix.patch" Content-Description: v3_doc_fix.patch Content-Disposition: attachment; filename="v3_doc_fix.patch"; size=3256; creation-date="Tue, 26 Sep 2023 13:38:44 GMT"; modification-date="Tue, 26 Sep 2023 13:40:25 GMT" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2RvYy9zcmMvc2dtbC9jb25maWcuc2dtbCBiL2RvYy9zcmMvc2dtbC9jb25m aWcuc2dtbAppbmRleCBkNDJiN2Q2M2VlLi5lNjM5ZjFkMjZkIDEwMDY0NAotLS0gYS9kb2Mvc3Jj L3NnbWwvY29uZmlnLnNnbWwKKysrIGIvZG9jL3NyYy9zZ21sL2NvbmZpZy5zZ21sCkBAIC02ODg2 LDkgKzY4ODYsOSBAQCBsb2NhbDAuKiAgICAvdmFyL2xvZy9wb3N0Z3Jlc3FsCiAgICAgICAgIFRo ZSBuYW1lIHdpbGwgYmUgZGlzcGxheWVkIGluIHRoZSA8c3RydWN0bmFtZT5wZ19zdGF0X2FjdGl2 aXR5PC9zdHJ1Y3RuYW1lPiB2aWV3CiAgICAgICAgIGFuZCBpbmNsdWRlZCBpbiBDU1YgbG9nIGVu dHJpZXMuICBJdCBjYW4gYWxzbyBiZSBpbmNsdWRlZCBpbiByZWd1bGFyCiAgICAgICAgIGxvZyBl bnRyaWVzIHZpYSB0aGUgPHhyZWYgbGlua2VuZD0iZ3VjLWxvZy1saW5lLXByZWZpeCIvPiBwYXJh bWV0ZXIuCi0gICAgICAgIE9ubHkgcHJpbnRhYmxlIEFTQ0lJIGNoYXJhY3RlcnMgbWF5IGJlIHVz ZWQgaW4gdGhlCi0gICAgICAgIDx2YXJuYW1lPmFwcGxpY2F0aW9uX25hbWU8L3Zhcm5hbWU+IHZh bHVlLiBPdGhlciBjaGFyYWN0ZXJzIHdpbGwgYmUKLSAgICAgICAgcmVwbGFjZWQgd2l0aCBxdWVz dGlvbiBtYXJrcyAoPGxpdGVyYWw+PzwvbGl0ZXJhbD4pLgorICAgICAgICBDaGFyYWN0ZXJzIHRo YXQgYXJlIG5vdCBwcmludGFibGUgQVNDSUksIGxpa2UgPGxpdGVyYWw+XHgwMzwvbGl0ZXJhbD4s CisgICAgICAgIGFyZSByZXBsYWNlZCB3aXRoIHRoZSA8cHJvZHVjdG5hbWU+UG9zdGdyZVNRTDwv cHJvZHVjdG5hbWU+CisgICAgICAgIDxsaW5rIGxpbmtlbmQ9InNxbC1zeW50YXgtc3RyaW5ncy1l c2NhcGUiPkMtc3R5bGUgZXNjYXBlZCBoZXhhZGVjaW1hbCBieXRlIHZhbHVlPC9saW5rPi4KICAg ICAgICA8L3BhcmE+CiAgICAgICA8L2xpc3RpdGVtPgogICAgICA8L3Zhcmxpc3RlbnRyeT4KQEAg LTc4ODMsMTEgKzc4ODMsMTMgQEAgQ09QWSBwb3N0Z3Jlc19sb2cgRlJPTSAnL2Z1bGwvcGF0aC90 by9sb2dmaWxlLmNzdicgV0lUSCBjc3Y7CiAgICAgICAgPHBhcmE+CiAgICAgICAgIFRoZSBuYW1l IGNhbiBiZSBhbnkgc3RyaW5nIG9mIGxlc3MKICAgICAgICAgdGhhbiA8c3ltYm9sPk5BTUVEQVRB TEVOPC9zeW1ib2w+IGNoYXJhY3RlcnMgKDY0IGNoYXJhY3RlcnMgaW4gYSBzdGFuZGFyZAotICAg ICAgICBidWlsZCkuIE9ubHkgcHJpbnRhYmxlIEFTQ0lJIGNoYXJhY3RlcnMgbWF5IGJlIHVzZWQg aW4gdGhlCi0gICAgICAgIDx2YXJuYW1lPmNsdXN0ZXJfbmFtZTwvdmFybmFtZT4gdmFsdWUuIE90 aGVyIGNoYXJhY3RlcnMgd2lsbCBiZQotICAgICAgICByZXBsYWNlZCB3aXRoIHF1ZXN0aW9uIG1h cmtzICg8bGl0ZXJhbD4/PC9saXRlcmFsPikuICBObyBuYW1lIGlzIHNob3duCi0gICAgICAgIGlm IHRoaXMgcGFyYW1ldGVyIGlzIHNldCB0byB0aGUgZW1wdHkgc3RyaW5nIDxsaXRlcmFsPicnPC9s aXRlcmFsPiAod2hpY2ggaXMKLSAgICAgICAgdGhlIGRlZmF1bHQpLiBUaGlzIHBhcmFtZXRlciBj YW4gb25seSBiZSBzZXQgYXQgc2VydmVyIHN0YXJ0LgorICAgICAgICBidWlsZCkuCisgICAgICAg IENoYXJhY3RlcnMgdGhhdCBhcmUgbm90IHByaW50YWJsZSBBU0NJSSwgbGlrZSA8bGl0ZXJhbD5c eDAzPC9saXRlcmFsPiwKKyAgICAgICAgYXJlIHJlcGxhY2VkIHdpdGggdGhlIDxwcm9kdWN0bmFt ZT5Qb3N0Z3JlU1FMPC9wcm9kdWN0bmFtZT4KKyAgICAgICAgPGxpbmsgbGlua2VuZD0ic3FsLXN5 bnRheC1zdHJpbmdzLWVzY2FwZSI+Qy1zdHlsZSBlc2NhcGVkIGhleGFkZWNpbWFsIGJ5dGUgdmFs dWU8L2xpbms+LgorICAgICAgICBObyBuYW1lIGlzIHNob3duIGlmIHRoaXMgcGFyYW1ldGVyIGlz IHNldCB0byB0aGUgZW1wdHkgc3RyaW5nCisgICAgICAgIDxsaXRlcmFsPicnPC9saXRlcmFsPiAo d2hpY2ggaXMgdGhlIGRlZmF1bHQpLiBUaGlzIHBhcmFtZXRlciBjYW4gb25seQorICAgICAgICBi ZSBzZXQgYXQgc2VydmVyIHN0YXJ0LgogICAgICAgIDwvcGFyYT4KICAgICAgIDwvbGlzdGl0ZW0+ CiAgICAgIDwvdmFybGlzdGVudHJ5PgpkaWZmIC0tZ2l0IGEvZG9jL3NyYy9zZ21sL3Bvc3RncmVz LWZkdy5zZ21sIGIvZG9jL3NyYy9zZ21sL3Bvc3RncmVzLWZkdy5zZ21sCmluZGV4IDUwNjJkNzEy ZTcuLmY2YjYwZmZkYmEgMTAwNjQ0Ci0tLSBhL2RvYy9zcmMvc2dtbC9wb3N0Z3Jlcy1mZHcuc2dt bAorKysgYi9kb2Mvc3JjL3NnbWwvcG9zdGdyZXMtZmR3LnNnbWwKQEAgLTEwNjQsMTIgKzEwNjQs MTIgQEAgcG9zdGdyZXM9IyBTRUxFQ1QgcG9zdGdyZXNfZmR3X2Rpc2Nvbm5lY3RfYWxsKCk7CiAg ICAgIDwvcGFyYT4KICAgICAgPHBhcmE+CiAgICAgICA8dmFybmFtZT5wb3N0Z3Jlc19mZHcuYXBw bGljYXRpb25fbmFtZTwvdmFybmFtZT4gY2FuIGJlIGFueSBzdHJpbmcKLSAgICAgIG9mIGFueSBs ZW5ndGggYW5kIGNvbnRhaW4gZXZlbiBub24tQVNDSUkgY2hhcmFjdGVycy4gIEhvd2V2ZXIgd2hl bgotICAgICAgaXQncyBwYXNzZWQgdG8gYW5kIHVzZWQgYXMgPHZhcm5hbWU+YXBwbGljYXRpb25f bmFtZTwvdmFybmFtZT4KKyAgICAgIG9mIGFueSBsZW5ndGggYW5kIGNvbnRhaW4gZXZlbiBjaGFy YWN0ZXJzIHRoYXQgYXJlIG5vdCBwcmludGFibGUgQVNDSUkuCisgICAgICBIb3dldmVyIHdoZW4g aXQncyBwYXNzZWQgdG8gYW5kIHVzZWQgYXMgPHZhcm5hbWU+YXBwbGljYXRpb25fbmFtZTwvdmFy bmFtZT4KICAgICAgIGluIGEgZm9yZWlnbiBzZXJ2ZXIsIG5vdGUgdGhhdCBpdCB3aWxsIGJlIHRy dW5jYXRlZCB0byBsZXNzIHRoYW4KICAgICAgIDxzeW1ib2w+TkFNRURBVEFMRU48L3N5bWJvbD4g Y2hhcmFjdGVycyBhbmQgYW55dGhpbmcgb3RoZXIgdGhhbgotICAgICAgcHJpbnRhYmxlIEFTQ0lJ IGNoYXJhY3RlcnMgd2lsbCBiZSByZXBsYWNlZCB3aXRoIHF1ZXN0aW9uCi0gICAgICBtYXJrcyAo PGxpdGVyYWw+PzwvbGl0ZXJhbD4pLgorICAgICAgcHJpbnRhYmxlIEFTQ0lJIGNoYXJhY3RlcnMg YXJlIHJlcGxhY2VkIHdpdGggdGhlIDxwcm9kdWN0bmFtZT5Qb3N0Z3JlU1FMPC9wcm9kdWN0bmFt ZT4KKyAgICAgIDxsaW5rIGxpbmtlbmQ9InNxbC1zeW50YXgtc3RyaW5ncy1lc2NhcGUiPkMtc3R5 bGUgZXNjYXBlZCBoZXhhZGVjaW1hbCBieXRlIHZhbHVlPC9saW5rPi4KICAgICAgIFNlZSA8eHJl ZiBsaW5rZW5kPSJndWMtYXBwbGljYXRpb24tbmFtZSIvPiBmb3IgZGV0YWlscy4KICAgICAgPC9w YXJhPgogCg== --_002_TYAPR01MB586607D53C42E59DBB00FD9AF5C3ATYAPR01MB5866jpnp_--