public inbox for [email protected]  

help / color / mirror / Atom feed

From: Hayato Kuroda (Fujitsu) <[email protected]>
To: 'Peter Smith' <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Cc: Julien Rouhaud <[email protected]>
Cc: Amit Kapila <[email protected]>
Subject: RE: [PoC] pg_upgrade: allow to upgrade publisher node
Date: Tue, 11 Apr 2023 10:30:35 +0000
Message-ID: <TYAPR01MB586641134EF13CBF74F5746FF59A9@TYAPR01MB5866.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <CAHut+PseyGTDfEZDKB8Su3qZDKViQh3rGNRU-prRZDkHQyOpqA@mail.gmail.com>
References: <TYAPR01MB58664C81887B3AF2EB6B16E3F5939@TYAPR01MB5866.jpnprd01.prod.outlook.com>
	<CAHut+PvpBsyxj9SrB1ZZ9gP7r1AA5QoTYjpzMcVSjQO2xQy7aw@mail.gmail.com>
	<TYCPR01MB5870E212F5012FD6272CE1E3F5969@TYCPR01MB5870.jpnprd01.prod.outlook.com>
	<CAHut+PseyGTDfEZDKB8Su3qZDKViQh3rGNRU-prRZDkHQyOpqA@mail.gmail.com>

Dear Peter,

Thank you for giving explanation.

> 
> Hopefully, someone will correct me if this explanation is wrong, but
> my understanding of the different prefixes is like this --
> 
> "XXX" is used as a marker for future developers to consider maybe
> revisiting/improving something that the comment refers to
> e.g.
> /* XXX - it would be better to code this using blah but for now we did
> not.... */
> /* XXX - option 'foo' is not currently supported but... */
> /* XXX - it might be worth considering adding more checks or an assert
> here because... */
> 
> OTOH, "Note" is just for highlighting why something is the way it is,
> but with no implication that it should be revisited/changed in the
> future.
> e.g.
> /* Note: We deliberately do not test the state here because... */
> /* Note: This memory must be zeroed because... */
> /* Note: This string has no '\0' terminator so... */

I confirmed that current "XXX" comments must be removed by improving
or some decision. Therefore I kept current annotation.

Best Regards,
Hayato Kuroda
FUJITSU LIMITED

view thread (3+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: RE: [PoC] pg_upgrade: allow to upgrade publisher node
  In-Reply-To: <TYAPR01MB586641134EF13CBF74F5746FF59A9@TYAPR01MB5866.jpnprd01.prod.outlook.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox