public inbox for [email protected]help / color / mirror / Atom feed
[PATCH] walsender uses a temporary replication slot by default 2+ messages / 2 participants [nested] [flat]
* [PATCH] walsender uses a temporary replication slot by default @ 2019-11-09 21:10 Peter Eisentraut <[email protected]> 0 siblings, 0 replies; 2+ messages in thread From: Peter Eisentraut @ 2019-11-09 21:10 UTC (permalink / raw) --- src/backend/replication/walsender.c | 9 +++++++-- src/bin/pg_basebackup/pg_basebackup.c | 8 +++++++- 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/src/backend/replication/walsender.c b/src/backend/replication/walsender.c index 7f5671504f..c16455f3f0 100644 --- a/src/backend/replication/walsender.c +++ b/src/backend/replication/walsender.c @@ -563,6 +563,12 @@ StartReplication(StartReplicationCmd *cmd) (errcode(ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE), (errmsg("cannot use a logical replication slot for physical replication")))); } + else + { + char *slotname = psprintf("pg_walsender_%d", MyProcPid); + + ReplicationSlotCreate(slotname, false, RS_TEMPORARY); + } /* * Select the timeline. If it was given explicitly by the client, use @@ -703,8 +709,7 @@ StartReplication(StartReplicationCmd *cmd) Assert(streamingDoneSending && streamingDoneReceiving); } - if (cmd->slotname) - ReplicationSlotRelease(); + ReplicationSlotRelease(); /* * Copy is finished now. Send a single-row result set indicating the next diff --git a/src/bin/pg_basebackup/pg_basebackup.c b/src/bin/pg_basebackup/pg_basebackup.c index a9d162a7da..687bd331dd 100644 --- a/src/bin/pg_basebackup/pg_basebackup.c +++ b/src/bin/pg_basebackup/pg_basebackup.c @@ -68,6 +68,11 @@ typedef struct TablespaceList */ #define MINIMUM_VERSION_FOR_TEMP_SLOTS 100000 +/* + * Version 13 creates temporary slots automatically. + */ +#define MINIMUM_VERSION_FOR_AUTO_TEMP_SLOTS 130000 + /* * Different ways to include WAL */ @@ -569,7 +574,8 @@ StartLogStreamer(char *startpos, uint32 timeline, char *sysidentifier) "pg_xlog" : "pg_wal"); /* Temporary replication slots are only supported in 10 and newer */ - if (PQserverVersion(conn) < MINIMUM_VERSION_FOR_TEMP_SLOTS) + if (PQserverVersion(conn) < MINIMUM_VERSION_FOR_TEMP_SLOTS || + PQserverVersion(conn) >= MINIMUM_VERSION_FOR_AUTO_TEMP_SLOTS) temp_replication_slot = false; /* -- 2.24.0 --------------51F72D0156BA2FB5139E73C4-- ^ permalink raw reply [nested|flat] 2+ messages in thread
* RE: [Proposal] Add foreign-server health checks infrastructure @ 2023-02-09 14:38 Hayato Kuroda (Fujitsu) <[email protected]> 0 siblings, 0 replies; 2+ messages in thread From: Hayato Kuroda (Fujitsu) @ 2023-02-09 14:38 UTC (permalink / raw) To: 'Kyotaro Horiguchi' <[email protected]>; +Cc: [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]> Dear Horiguchi-san, Thank you for checking! The patch will be attached to another mail. > At Fri, 27 Jan 2023 06:57:01 +0000, "Hayato Kuroda (Fujitsu)" > <[email protected]> wrote in > > I found cfbot failure, PSA fixed version. > > + Unlike <xref linkend="libpq-PQstatus"/>, this function checks socket > + health. This check is performed by polling the socket. This function is > + currently available only on systems that support the non-standard > + <symbol>POLLRDHUP</symbol> extension to the > <symbol>poll</symbol> system > > I find it quite confusing that we have pqSocketCheck and PQconnCheck, > that does almost the same thing.. Since pqSocketCheck is a static > function, we can modify the function as we like. Renamed to pqSocketIsReadableOrWritableOrValid(), but seemed very bad... > I still don't understand why we need pqconnCheck_internal separate > from pqSocketPoll(), and PQconnCheck from pqSocketCheck. pqconnCheck_internal() was combined into pqSocketPoll(), but PQconnCheck() still exists. libpq-fe.h, did not include standard header files except stdio.h. I'm not sure whether we can add an inclusion of time.h, because it may break the compatibility that some platform may not have the header. If there are not such a system, we may able to export pqSocketCheck() and remove PQconnCheck(). The side effect of this changes is that codes become dirty when we add kqueue() support... > https://www.postgresql.org/message-id/flat/TYAPR01MB58665BF23D38EDF1 > 0028DE2AF5299%40TYAPR01MB5866.jpnprd01.prod.outlook.com#47d21431bf9 > fa94f763c824f6e81fa54 > > IIUC, pqSocketCheck () calls pqSocketPoll(), > > and in the pqSocketPoll() we poll()'d the POLLIN or POLLOUT event. > > But according to [1], we must wait POLLRDHUP event, > > so we cannot reuse it straightforward. > > Yeah, I didn't suggest to use the function as-is. Couldn't we extend > the fucntion by letting it accept end_time = 0 && !forRead && > !forWrite, not causing side effects? Modified accordingly. Is it what you expected? Best Regards, Hayato Kuroda FUJITSU LIMITED ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2023-02-09 14:38 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2019-11-09 21:10 [PATCH] walsender uses a temporary replication slot by default Peter Eisentraut <[email protected]> 2023-02-09 14:38 RE: [Proposal] Add foreign-server health checks infrastructure Hayato Kuroda (Fujitsu) <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox