Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p0F15-0003qA-7m for pgsql-hackers@arkaria.postgresql.org; Wed, 30 Nov 2022 04:48:15 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1p0F13-0005to-NB for pgsql-hackers@arkaria.postgresql.org; Wed, 30 Nov 2022 04:48:13 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p0F13-0005te-81 for pgsql-hackers@lists.postgresql.org; Wed, 30 Nov 2022 04:48:13 +0000 Received: from esa20.fujitsucc.c3s2.iphmx.com ([216.71.158.65]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p0F0z-00036P-Q6 for pgsql-hackers@postgresql.org; Wed, 30 Nov 2022 04:48:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=fujitsu.com; i=@fujitsu.com; q=dns/txt; s=fj1; t=1669783690; x=1701319690; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=oO6iSkF9mK7MRgOrzdmEc/OyF1CDt5OwuLCPCY0fqng=; b=tevyNqfc0mnqF2qp/DaFaPUYciVq6l7k0bpSFxX5//IRG1BeBLO4j2E4 FZ4kA6k6MOQz+68SdsF9b2fcGPIgY4KjyHAP9hSQ/9z5xNeeHhz/UAtrB l06bZU26c5cSNyZSVUkTRzWcYA6wgkGb+pTCz/rG9yBNBgXEKt5YHSkMh cYSFLhWYNpgpqGd7bM1bPCufhprUVWlJNmZb1430dUJr/7rL5DBpf2lYx Kr2o7LGA/u8C/7UkuBfxVFP2b+mj3gpOL1Fyk1OrPcHnMJKJ/SEqOf2n+ A5mVZ/zpoMCCCZ+HHATNJzPDsfMn4TTxCrSrhXxRHA/pcS7xscQ26vY9V A==; X-IronPort-AV: E=McAfee;i="6500,9779,10546"; a="71158551" X-IronPort-AV: E=Sophos;i="5.96,205,1665414000"; d="scan'208";a="71158551" Received: from mail-os0jpn01lp2105.outbound.protection.outlook.com (HELO JPN01-OS0-obe.outbound.protection.outlook.com) ([104.47.23.105]) by ob1.fujitsucc.c3s2.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2022 13:48:07 +0900 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NGr6NSodtEWZjl2O0rOyh7IG4MhFLWrEaYi5s9N5PWqk8PFbf5H5OmqwgMRzgKt4nxA4FYid7RbRbV7rMzKN5RA+USwYohQEj9Jum0tFmrWed8iWB+QNnysxPLq1O6E1v1VCD5C6qd8njXyuKuuLod7tqhUBQefIXiOIt9rg9AujTEtfWrkwyGM1xSDYHHVy14swqbSx4dfYuec+SDIfIkXpesATY9kYq2E6kt7m3adtTOBDBv09iv96iXmD2ttbwghaI+NDpUaFw7QgJRqtd8+z7Ln6kEzJj8qbyVtWypMad3o22ilGUdkbpGsqRyyjtcx8RQenHdhu1ykubR5Q4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=D5bvd7TPrknbxjUaelXWi3qRlVKbGhcvqgQuNMec5ko=; b=Aii/cg2q7bE0JKVYOCj0USYQ72yIZnXgzcpFJRHBx2IqkhTXs6GcklQSdM3VtAkBq9BcA3B6c/wDh/0YSM/uHJ1HTe0WVDNXzNywLg7gH9zcMM0+ij2K1dy4Hu9XkWySU8MNhkDiBoteNXfkyppQ9a5G3DqTUXXfJSPsS1h3RIPVW3pKzQj/YsShusq+/ot/4IWh5Kc+T1mbn7ZRg+wwLXEVFEdMqv1q0ZRVRWka9GC7sWVkr22mGxJ1Ox5JiVHNXHZYpV2Yi0GCM8g8wRIXjVJNw+1vG5q4/OeP1+n5DoQ16O7qfeQcJ1b/lq4avaaAfNIQPWwVc7dD5LE2oSzAFw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=fujitsu.com; dmarc=pass action=none header.from=fujitsu.com; dkim=pass header.d=fujitsu.com; arc=none Received: from TYAPR01MB5866.jpnprd01.prod.outlook.com (2603:1096:404:8056::13) by OS0PR01MB5971.jpnprd01.prod.outlook.com (2603:1096:604:cc::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Wed, 30 Nov 2022 04:48:03 +0000 Received: from TYAPR01MB5866.jpnprd01.prod.outlook.com ([fe80::f4b:1dbf:dc2:dc91]) by TYAPR01MB5866.jpnprd01.prod.outlook.com ([fe80::f4b:1dbf:dc2:dc91%5]) with mapi id 15.20.5857.023; Wed, 30 Nov 2022 04:48:03 +0000 From: "Hayato Kuroda (Fujitsu)" To: 'Nathan Bossart' CC: "pgsql-hackers@postgresql.org" Subject: RE: wake up logical workers after ALTER SUBSCRIPTION Thread-Topic: wake up logical workers after ALTER SUBSCRIPTION Thread-Index: AQHY/gstJTOw1KVvYkmzgq5jwtGOWq5KPp3ggAAeDQCAABlmgIAAFRMAgAJzNYCAAH8N0IAF+ywAgANutACAAAVzIA== Date: Wed, 30 Nov 2022 04:48:03 +0000 Message-ID: References: <20221122004119.GA132961@nathanxps13> <20221122043916.GA230228@nathanxps13> <20221123205027.GA368966@nathanxps13> <20221127234528.GB878043@nathanxps13> <20221130041028.GA1604177@nathanxps13> In-Reply-To: <20221130041028.GA1604177@nathanxps13> Accept-Language: ja-JP, en-US Content-Language: ja-JP X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_Enabled=true; MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_SetDate=2022-11-30T04:34:38Z; MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_Method=Standard; MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_Name=FUJITSU-RESTRICTED?; MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_SiteId=a19f121d-81e1-4858-a9d8-736e267fd4c7; MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_ActionId=6be9b2e0-4f38-499b-8d5a-c69bebd36832; MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_ContentBits=0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=fujitsu.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYAPR01MB5866:EE_|OS0PR01MB5971:EE_ x-ms-office365-filtering-correlation-id: 056a5770-a568-4e37-a1ac-08dad28e10d6 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Sk7FvqOOh/0QQgoCqQdBWLJSyGr59jJ3rcH/k9c9nVwkWlOGC+AEjTVOEHEqAHLzVWueTVw2W8HX1/ra1KfQJuOyRjmPQvr7HHExKgi8i7neYi3cWv9BDJirGIKkPpc28/gfC1W2un8AlQNj5zJ2CtRlTFU5rylNFqs9XJvgf4N9dHg9VBt4RWQzkZzFTxSxTHNNtg9p/6oEON0GSkpqtgZ5lPRZbWyKk1MTPFyzp9QQV4xPXjnRpPYpmfBmX/RJzE/dmF9s61mwQ96Cb9rLpxzCPsQ9RL8VlD592jPSa0fMQk0aUHz71qqNY68ns0ao6M9S/GjymaKIpd3T+1w1VaPMidp/uS5FGi2vkh4Hh9NPpInuwpGiK+WObimAoXfmJUd4zvNyaY+dYpCM5fzXVen/FavIbCO0AShS+Uloirq+aUYwB+Oib5D99+37j5DNTfgYXUSgZIGH6M7P9B4DZfqivr/Xiwa97JY8+SqZei0ShmKhWEwi2JFbcTAv3jmvm0u/SkLMpYpWYjZ4XacMb20+hX2+XF/fCRLytCI8KOI1GYF1cIIk+MAILXBHUAJwIJ1iOQjr7nm3SMfRf82LFUM1mKxa3VcD4qXWqeicy2oX6eGBpyNVWIF+z+Q4a7rnUKJv3c1hHNEkdpJs3PT+uHWbiEiu9Vha8Jt/7LCtAuVa3UbSEsRER/ZKwohO1AEjJzKrzSPx92eZm5BhvJK+RlnTwjMHs0xT6+qf7vmEOZlyQvlg4yNUIbEiQm2s9x2mP4/fIXSGxuXl60cSEK3+qQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TYAPR01MB5866.jpnprd01.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(376002)(366004)(396003)(136003)(39860400002)(451199015)(1590799012)(186003)(1580799009)(122000001)(86362001)(966005)(316002)(6916009)(71200400001)(26005)(85182001)(55016003)(82960400001)(33656002)(38070700005)(38100700002)(83380400001)(9686003)(6506007)(4744005)(8936002)(478600001)(45080400002)(7696005)(76116006)(41300700001)(52536014)(2906002)(5660300002)(66446008)(66476007)(64756008)(66946007)(66556008)(8676002)(4326008);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-2022-jp?B?NFB0a01VRE5JdFJEd1BOYVNFZ3grZWR0VituZVlpUXc0OXJ4aEVwMmJq?= =?iso-2022-jp?B?YTV6Wk41Z0pJZFcveXNXaHVoTTJEelpEVVhZamNoalRjNitTR085elFm?= =?iso-2022-jp?B?MGtHSzdhVUw5Q0FTLzVtQVlmSUNMU1VFQlNRdk9iODlwemU1NFBudU9v?= =?iso-2022-jp?B?UUQ3UlpoMWpYYXlCTjliRGJrdVJkdXRocWFYU3RjVXg2NWczN1hpNVFk?= =?iso-2022-jp?B?U2E3eHVvUnFueUhna2JJNDVrT3dMeG90UW9tMktBNnEzeEwwb1E0S0gr?= =?iso-2022-jp?B?NWZQMXl5MDlRUGFwMWZBVVY4LzM3MTNKTHk5WTBTanlFdnRUc2RqbUpr?= =?iso-2022-jp?B?RWd3MmZ0YU1KNEhyaEs1YkNOdmttZDdPVHpOVHVzSkoxZUwwOG1XY2c2?= =?iso-2022-jp?B?OU15S1pOQTd4Q3BqZWNIbzlhcGN4dnl3cVFIZ05Kb0RxNHdxL3VQZS8x?= =?iso-2022-jp?B?VHJJb1pDaE5GWVFoMG9ScEQzRmxYZE1rUFQ3TE5adXJJSGhxaGVKNllV?= =?iso-2022-jp?B?MVk2MXpHd3d5d2tTRUpVOHhLVkRPbW1BVHlZYTJmaXRCb1JiNmhRRVE4?= =?iso-2022-jp?B?c0oyb29VcjJ1czVZVENhL2FWRDh5V2tWRlhoT3I1VjUyNHdNMEZNcEpj?= =?iso-2022-jp?B?N2N2NURiZE5CMm9xYUM5dTBCdGhoSWhxaWtQRVJPWHRHVHBUdFY4ZTdV?= =?iso-2022-jp?B?K3ZBeVhKYjhhWjhWUitXZ3FsVEpYZmhaOUFJZjVCY2labnNLTzNaQ2lO?= =?iso-2022-jp?B?YmhmL1hGTnMza3BoYWsxRTBxZWtIUXRyMXRoSDhPRUs0Ull4Q24zWWU2?= =?iso-2022-jp?B?ZmRsNHZ1bFAyNkttRmdLWjZHemY1RWFqdVI2U1pPc0gzdTFtV0xvK1dl?= =?iso-2022-jp?B?K2xtQ2kvdC90OGdyM1d4bGlqekFmOGw2aUVXeENZR0NIS2FGTlVEWDRY?= =?iso-2022-jp?B?bXBaZDJubmlMRGo3Szk5N0lyc2lzczBnVXpvV1RxSkQ5clVRaGx2L1o1?= =?iso-2022-jp?B?VlRXczcvMXR0SmhjRjJWc25HclNGOUZzakxYaVBDcC9XbDl5TGdEbTdX?= =?iso-2022-jp?B?ckVNZFphSWJ1b2dVWlcxN1hOSENaaEsvRGdaMldDWGhENWh3SkE2RjBp?= =?iso-2022-jp?B?N1RGeVBzdjdOT24xa3ZFdlpqUzhQR25jUEVmL2JMWTRidXpZdTNyNzBF?= =?iso-2022-jp?B?dmxsUnkzRkZlc1BQdEErb3c2N0JqK0x3WjUrU01kQ2JXbkJDcXhSWXBi?= =?iso-2022-jp?B?TG1RQU9CcnJoNXdWU3dPYUtYUTRxVDJRZncwV0xuaDR5T3hhcXcrdTJS?= =?iso-2022-jp?B?MUxzUysveXgzOU9hcitpTFFsYUJiWXZiMUNXRGZuNXRWRkZxYnpzRjZP?= =?iso-2022-jp?B?UW5mNjlyemdQNkVwNTRRNzVQbkN2SDVDV3FnamRIdzY2V2hOYVFMazc4?= =?iso-2022-jp?B?OFhzbVo0Nk5XclJINlIrSjI1OUJCNkJrQkhqMHRvNzRKeGFTUm8wVHFQ?= =?iso-2022-jp?B?MDJHREVQaWxkNFRacHNIUVY4US9XUjBRU1c0Z01DaEg0dEpLS1hEV0ll?= =?iso-2022-jp?B?K0ZPQ0FVY1gwU0pkWmtqY0dPUndCUHlvWHhSQkpDN2VrUWlkUHYrMlc3?= =?iso-2022-jp?B?TWpkc3pqTlFYWUtMR2hxNjdTSW5TcktZNGw2OVhqQjA2c0RqZVZVVGcw?= =?iso-2022-jp?B?c1RkdDZCQ1o4UmZqcXRaQ0YwWXlPTlMwUzBmNDArVWg5bU9mbkxwOU9s?= =?iso-2022-jp?B?QkNjbGNia2wvMktnbEM3dHY4NDViaEp1bEhlVXpQN3ZKMzRRYWNOY1No?= =?iso-2022-jp?B?SWdmcEFkT01wUlh6U3FLU3hhQnJyVE9XbUNBOGViQ2RzNWh1ZHB1SGFn?= =?iso-2022-jp?B?YXVMUkF2dWhUTU9jMFNJUkRCOUdzTTd3QUczRkR0T1pmeUxhRFJLdTNr?= =?iso-2022-jp?B?cDEvQUxYdW0xM0RES29XazJtMk1rTHIwekw0UDNscTZraHc5VW9pYjRL?= =?iso-2022-jp?B?OGludW1KeVIrTVplSmZ6ZXhmYVJhOTRtS2huUVp5Q2g3TFJQZzBmZzNP?= =?iso-2022-jp?B?Ylp0TnJKSVBjTDBXbVpoMkVXdm1vRGtpQ2VjdXRJRlRDSzVvaW53SHVS?= =?iso-2022-jp?B?aXh1TDdJTTJhZUc5ZzVZaXFOci9nR2p0c0hrZVoyNTBNOUlzMDVlZndW?= =?iso-2022-jp?B?MkNhTGYyWWJwRFdvdjlIV0IwTlJleHdoZ0tQUFpFeHAxWEtjdEQ2QURT?= =?iso-2022-jp?B?MXhmbnA1Q3Y5ZmVrVXNqTXEyNzZpa0VRMEJmb1hySFdJcFRuUFdIcnNx?= =?iso-2022-jp?B?TWFoTk91WGFYeXB6VU5hZWZaQUhxL2tWUmc9PQ==?= Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: UBcv1n2KYGWcWFWQtJYdV8Hn8C0eMj0YGh9bgCI2tghOQTqBLhzSRZuEyhPrsmgNN1bIMqpYkgA5g/hqjndBzg8qGSWyBh0vLaVCG7xy3uyIebqdiHIOyyUaVpExHpZEzfD0AbNbawQfcuqQ0rNis9jqy6lbLOrPWFtLQ5n2EeSYW0AycNvSqhBerxwKTuKU2TCvLe5Y6xsD5snraYXJHHtYCmJmF/D01LkVhgRfUZ7/eX/22EaV5/BENWInnqb+ei2ovDWbz/61Y/ldDq+CsOQcjCIr/WQGi4SO+BfBKJvmsrvmclap101Bh/ZBTEMPfMy6lg+nTLmQWAFNBt1bqez/Rn6Cj1Wtvieqvn8glQJOiY0TGfK6tUj+1oZ8EMEM0bcrtZKHUFFHB8YRcE1GxEvOTXPajnGYYyyEC42xVI/SjlQH/sIc67DVRKCw31T7KwG4DTR9ld2LNIT7WglmujOfavmBc/3LspDhgcXCoRm7+Ianl2DK26IF53O/2pjgUzJwOElIdCsDOHZ4KJw8ndYM9q9I+BD5dgB9IsuxC99aa8Z8h5q5XtuOO1iRfg+0R5RxvHXnPwd/JK6I8Qz2KWmVZis+6Ue5GQLlxwmE40jBiwU+aaMsX0w3HciECsHS3nlSKVLFncGERnL3I4eEtjwjo9VT+qGhx+fTKGC0eWKb+2Ayy0aZi+KaBQeYZjsATyfGDRfprc4Rs7ZaxK2X5k84+saFGEoFktBJxGTsoxpPmbmF5z2V6vITWVdUuTq70OaL7zHPcvm8W6y0ApzeWNQEO85BBlWvTDXc6PqAdro= X-OriginatorOrg: fujitsu.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYAPR01MB5866.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 056a5770-a568-4e37-a1ac-08dad28e10d6 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Nov 2022 04:48:03.5724 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a19f121d-81e1-4858-a9d8-736e267fd4c7 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +8mtfq/KkAM9pBoQcqR+Pola7ey/OjnNT0z5N7K9wopJBedId6qoLXx+pQ0edqNOI+8ACJummExLKmQJbAFp91x8pGGu4IusRw3qbhIRcgE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS0PR01MB5971 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Dear Nathan, > I spent some more time on the prevent-unnecessary-wakeups patch for > logical/worker.c that I've been alluding to in this thread, and I found a > few more places where we depend on the worker periodically waking up. Th= is > seems to be a common technique, so I'm beginning to wonder whether these > changes are worthwhile. I think there's a good chance it would become a > game of whac-a-mole. I think at least this feature is needed for waking up workers that are slep= t due to the min_apply_delay. The author supposed this patch and pinned our thread[1]. [1]: https://www.postgresql.org/message-id/TYCPR01MB8373775ECC6972289AF8CB3= 0ED0F9%40TYCPR01MB8373.jpnprd01.prod.outlook.com Best Regards, Hayato Kuroda FUJITSU LIMITED