public inbox for [email protected]  

help / color / mirror / Atom feed

From: Hayato Kuroda (Fujitsu) <[email protected]>
To: 'Melih Mutlu' <[email protected]>
To: Amit Kapila <[email protected]>
To: Peter Smith <[email protected]>
To: [email protected] <[email protected]>
Cc: Euler Taveira <[email protected]>
Cc: Bharath Rupireddy <[email protected]>
Cc: Dilip Kumar <[email protected]>
Cc: Takamichi Osumi (Fujitsu) <[email protected]>
Cc: pgsql-hackers <[email protected]>
Subject: RE: Allow logical replication to copy tables in binary format
Date: Mon, 20 Mar 2023 04:13:29 +0000
Message-ID: <TYAPR01MB5866657CFB28FFC1D552B97AF5809@TYAPR01MB5866.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <CAGPVpCQDsg3D-dd6rjqt3=DaQ+FAZzzF6zf2Y-6uxAocCWB_EA@mail.gmail.com>
References: <CAA4eK1JXK9Xo+ikrN1D5iJ2Te3bV_s1-kw=NmqiU8LU0QmdFJw@mail.gmail.com>
	<CAGPVpCQDsg3D-dd6rjqt3=DaQ+FAZzzF6zf2Y-6uxAocCWB_EA@mail.gmail.com>

Dear Melih,

Thank you for updating the patch.
I checked your added description about initial data sync and I think it's OK.

Few minor comments:

01. copy_table

```
+	List 	   *options = NIL;
```

I found a unnecessary blank just after "List". You can remove it and align definition.

02. copy_table

```
+		options = lappend(options, makeDefElem("format", (Node *) makeString("binary"), -1));
```

The line seems to exceed 80 characters. How do you think to change like following?

```
		options = lappend(options,
						  makeDefElem("format",
									  (Node *) makeString("binary"), -1));
```

Best Regards,
Hayato Kuroda
FUJITSU LIMITED

view thread (2+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: RE: Allow logical replication to copy tables in binary format
  In-Reply-To: <TYAPR01MB5866657CFB28FFC1D552B97AF5809@TYAPR01MB5866.jpnprd01.prod.outlook.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox