public inbox for [email protected]  
help / color / mirror / Atom feed
From: [email protected] <[email protected]>
To: 'Peter Smith' <[email protected]>
To: Önder Kalacı <[email protected]>
Cc: Amit Kapila <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: RE: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher
Date: Wed, 21 Sep 2022 02:21:37 +0000
Message-ID: <TYAPR01MB5866B899EC0F9B00B0DC2811F54F9@TYAPR01MB5866.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <CAHut+Pv-P-wacqShunWm7zRZqLoR7UjrgZAOjY9xV2GXUj4Mjg@mail.gmail.com>
References: <CACawEhVLqmAAyPXdHEPv1ssU2c=dqOniiGz7G73HfyS7+nGV4w@mail.gmail.com>
	<CAA4eK1JfOBtdObF420-jnCYt8nhfWCWKq-7pX4KM3RQsjis+6Q@mail.gmail.com>
	<CACawEhXgP_Kj_1iyNAp16MYos4Anrtz+OZVtj2z-QOPGdPCt_A@mail.gmail.com>
	<CAA4eK1+mmsZqyVrVO6ey2QjYzd2EX344-jryiz3BXiHVwnQ7Eg@mail.gmail.com>
	<CACawEhUZ=7nT=KWGza+ME0ztx=nczzOpdAQELLqr9KpcyKOCtQ@mail.gmail.com>
	<CAA4eK1K9e1zVhNtkuRV128JqJ28pj2_vfBMiyDLie2BO7OKU4w@mail.gmail.com>
	<CACawEhWV=H_jDyJPm_CUqkBZNMkK-1gtt3ddShj_7p3eF3iwRQ@mail.gmail.com>
	<CAA4eK1+q_6dJksasaA1SOibQk2huUFUEvZRa3Mi0J9uU235Fvw@mail.gmail.com>
	<CACawEhVZUJ0jDe3W-_U51Xt28p_s03sHGo82QmUm5t3X7aVQCg@mail.gmail.com>
	<CAA4eK1J3fFvQUGoOPCsyUxwpXMBEA007CnEJd3qHw8jJngKq8A@mail.gmail.com>
	<CACawEhXavM7kjzVgMfRSN+YyB_Lxqjoi8PJ2Gh7MdL-eScb9vw@mail.gmail.com>
	<CAA4eK1KQMH1U=OpAKSx3GE=3jXCtE=p2JMXTp=46QbU9nMV8ZA@mail.gmail.com>
	<CACawEhWcLevu72AtdM1G6vK_8EhmRXb77NY5eFf1vht2i9Xh8w@mail.gmail.com>
	<CAHut+PtomDp=9UOkE+epQ6Tq00PCFnustRX3qZJWxC_5rZxcDg@mail.gmail.com>
	<CACawEhXnTcXBOTofptkgSBOyD81Pohd7MSfFaW0SKo-0oKrCJg@mail.gmail.com>
	<CAHut+PuA7=kytMWX7QJBuou7yfUDNofsgz_Hr3fNy2k=2C_shg@mail.gmail.com>
	<CACawEhWA5P7PkW6GqLt-iBQposVxJZeu_=FNTQF-6ch6SkyZhw@mail.gmail.com>
	<CAHut+Pv-P-wacqShunWm7zRZqLoR7UjrgZAOjY9xV2GXUj4Mjg@mail.gmail.com>

> One last thing - do you think there is any need to mention this
> behaviour in the pgdocs, or is OK just to be a hidden performance
> improvement?

FYI - I put my opinion.
We have following sentence in the logical-replication.sgml:

```
...
If the table does not have any suitable key, then it can be set
   to replica identity <quote>full</quote>, which means the entire row becomes
   the key.  This, however, is very inefficient and should only be used as a
   fallback if no other solution is possible.
...
```

Here the word "very inefficient" may mean that sequential scans will be executed every time.
I think some descriptions can be added around here.

Best Regards,
Hayato Kuroda
FUJITSU LIMITED



view thread (61+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: RE: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher
  In-Reply-To: <TYAPR01MB5866B899EC0F9B00B0DC2811F54F9@TYAPR01MB5866.jpnprd01.prod.outlook.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox