public inbox for [email protected]  

help / color / mirror / Atom feed

From: Hayato Kuroda (Fujitsu) <[email protected]>
To: 'Amit Kapila' <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: RE: Add missing copyright for pg_upgrade/t/* files
Date: Tue, 4 Apr 2023 04:18:53 +0000
Message-ID: <TYAPR01MB5866C9F80BF0C497D017AD83F5939@TYAPR01MB5866.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <CAA4eK1+grdj4Br7sGGs=8JO81k94iPWzuEn3WUmtf6SFQWDW-Q@mail.gmail.com>
References: <TYCPR01MB587073D91E372B8EF719931EF5929@TYCPR01MB5870.jpnprd01.prod.outlook.com>
	<CAA4eK1+grdj4Br7sGGs=8JO81k94iPWzuEn3WUmtf6SFQWDW-Q@mail.gmail.com>

Dear Amit,

Thank you for responding!

> 
> Yeah, it is good to have the Copyright to keep it consistent with
> other test files and otherwise as well.
> 
> --- a/src/bin/pg_upgrade/t/001_basic.pl
> +++ b/src/bin/pg_upgrade/t/001_basic.pl
> @@ -1,3 +1,5 @@
> +# Copyright (c) 2022-2023, PostgreSQL Global Development Group
> 
> How did you decide on the starting year as 2022?

I checked the commit log.
About 001_basic.pl, it had been added at 2017 once but been reverted soon [1][2].
322bec added the file again at 2022[3], so I chose 2022.

About 002_pg_upgrade.pl, it has been added at the same time[3]. 
Definitively it should be 2022.

[1]: https://github.com/postgres/postgres/commit/f41e56c76e39f02bef7ba002c9de03d62b76de4d
[2] https://github.com/postgres/postgres/commit/58ffe141eb37c3f027acd25c1fc6b36513bf9380
[3: https://github.com/postgres/postgres/commit/322becb6085cb92d3708635eea61b45776bf27b6

Best Regards,
Hayato Kuroda
FUJITSU LIMITED

view thread (5+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: RE: Add missing copyright for pg_upgrade/t/* files
  In-Reply-To: <TYAPR01MB5866C9F80BF0C497D017AD83F5939@TYAPR01MB5866.jpnprd01.prod.outlook.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox