From: "kuroda.hayato@fujitsu.com" <kuroda.hayato@fujitsu.com>
To: 'Zhihong Yu' <zyu@yugabyte.com>
CC: Shinya Kato <Shinya11.Kato@oss.nttdata.com>,
	"pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Subject: RE: [Proposal] Add foreign-server health checks infrastructure
Thread-Topic: [Proposal] Add foreign-server health checks infrastructure
Thread-Index: 
 AdfNNjec7xk22WznTt+52qg+YpAmvANdE8aAAG+tXeAALaEGgADyvFSgAOXdLoAAHbFoIA==
Date: Mon, 29 Nov 2021 08:51:40 +0000
Message-ID: 
 <TYAPR01MB5866D73C56A4363039175E56F5669@TYAPR01MB5866.jpnprd01.prod.outlook.com>
References: 
 <TYAPR01MB58662809E678253B90E82CE5F5889@TYAPR01MB5866.jpnprd01.prod.outlook.com>
 <54449d7bea79263e937266ad6ebc65b3@oss.nttdata.com>
 <TYAPR01MB58662CD4FD98AA475B3D10F9F59B9@TYAPR01MB5866.jpnprd01.prod.outlook.com>
 <4e64bb8a0a88f5b6ac5a8901377c81af@oss.nttdata.com>
 <TYAPR01MB58661992162BA7708191EC79F5619@TYAPR01MB5866.jpnprd01.prod.outlook.com>
 <CALNJ-vQWNK6AzpL=5iXLfpr4oRMYdJ72tDYhxLwd=iX5H5XUdQ@mail.gmail.com>
In-Reply-To: 
 <CALNJ-vQWNK6AzpL=5iXLfpr4oRMYdJ72tDYhxLwd=iX5H5XUdQ@mail.gmail.com>
Accept-Language: ja-JP, en-US
Content-Language: ja-JP
msip_labels: MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_Enabled=true;
 MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_SetDate=2021-11-29T08:13:03Z;
 MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_Method=Standard;
 MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_Name=FUJITSU-RESTRICTED?;
 MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_SiteId=a19f121d-81e1-4858-a9d8-736e267fd4c7;
 MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_ActionId=3b0b2423-64b6-4793-80f4-c805ea944935;
 MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_ContentBits=0
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=fujitsu.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 2cd40aee-446d-4380-5dda-08d9b315765a
x-ms-traffictypediagnostic: TY2PR01MB4267:
x-microsoft-antispam-prvs: 
 <TY2PR01MB42679F5ADB211CB06542389AF5669@TY2PR01MB4267.jpnprd01.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8273;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 O3PQem2ReDsB+RccXGB0GyDl5lED13kPpGfsP4WRHysTWEUSDd8LBbztvco/QcRWJn02RS5Qg3s0Nb5sJ1Y4OrQvZLpSn14fu15KOygZ6SWU+bUegi7DxRj1XsmGcJcHWz0kyPZtaOAj5GzWIK91f9LrUCWXT7RCmVu9CIY+B40UrrcBnO01kxpFQwFcrp1Xdm9EWtW42++eqe/R7kYHAQnHLSjpJnk7w2pPj/ZduuMx0QDcEC1b3XR/61Dx35ADoyEm8+L7AbQbFNErX4sFSDu/Jh5GWS1L0hP/vRUdfjDJ9ojFRfYsuXRt1ENCmvg2mdDYCGRAtjTf7biEsfUn8wRfTGHQmkTvgEO0dKc7eX4C/hG94WMogIRsHo6g4/sgt0idEtuSYXVnDOoqz3cjW0gJWqPhgpDI39R5wDdQhdcHM3Z3Di0L4A967IZKFKNctowLdoaPOCpjpO7zVXaVUSJLCatsky829Awc1TSTL44A0cUcKa1IrAM79SoAjJsrpmJ1ggMLTz0SKOI7QLt+TGctAJpWG+ROP/oaietfHCYc77+JCQqJFVHGe+WONYXneqNYF3C3iq0uY3Xfa/IrVMm2QsQgglxRt7L6Ga9z6w5FsFpNAjS1UdPLQSJ+VEk22nd2DhfkRa5o3QipQWReHaZwpPcjCydGCobS1g9tsgmW8MdVzzu4UD90H8Q98J9fM2/bVaHNak6aN7la6aYYng==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TYAPR01MB5866.jpnprd01.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(2906002)(122000001)(508600001)(9686003)(38100700002)(71200400001)(66946007)(26005)(186003)(76116006)(33656002)(66446008)(83380400001)(8676002)(38070700005)(66556008)(64756008)(66476007)(5660300002)(85182001)(82960400001)(8936002)(6916009)(54906003)(4326008)(6506007)(86362001)(52536014)(7696005)(55016003)(316002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?iso-2022-jp?B?WGpGVEwwL3FCODFiSjlhVG1LZW9XOXBsV0dJK0h4UzduTFM3ZDN6ZGJY?=
 =?iso-2022-jp?B?em52WFJPQ1dOMVZDYlI2R2Jqb0g0SzRpRGlZMGk0TldWU0NxZlBvak1R?=
 =?iso-2022-jp?B?R0hwdDdkeGkxbE9ONGJSRE5jODgrTWtaYXdkOG1jVTJQazFxdExCUmxJ?=
 =?iso-2022-jp?B?SUJ5YWtLcGZJTW9KVlNVd3dLdTNVaGVibEVVc1IxV1VKZjZOWkxySGhI?=
 =?iso-2022-jp?B?bXdWUDB2enhGeGljY2x5YW1SVkxDeFJnc0NSdEFtelRtWlQvYnpDeXJy?=
 =?iso-2022-jp?B?emRWNFIzdlBmN054enl2SWFhYmRHejBHNi8xelJuekVTQWQ3QnpLK1RJ?=
 =?iso-2022-jp?B?aEZmM05COGNyRDR1dVQ0NVZObXQxLzd6UWhQNVdJd2dTekR0S20rVTNZ?=
 =?iso-2022-jp?B?WWJBbDV6RERRL0ozL0ZhekNpQTY5WVc2L1FjMExZQlZXcCt6SVV1ZzJS?=
 =?iso-2022-jp?B?MDRwL1h2UXFEb0VPN0oydC80UWw5dG5zak5oekZUbkw1SC9VdlBVVklM?=
 =?iso-2022-jp?B?RFJxZFpRbUl2NzFEcHFKbkxPWGN3ODBiWTlteWcvL09ZaFN2dE41NEdj?=
 =?iso-2022-jp?B?bHgxSzRBSGllNXg1eVRpMm0yK1BFNklmYkZIaGlzNytEUUJOTlRWTHBN?=
 =?iso-2022-jp?B?VGFnaS83OVkrT0MxdHJTU1ZlNG9WRlg4Zlh6d2R1Nm1BYVFETkVnUFFS?=
 =?iso-2022-jp?B?ZXBHYzIzTXpjaWdDTW1Ua1MyRllpZDNMOCtNQ1RVYTNNZnA2Z2ExWkNZ?=
 =?iso-2022-jp?B?UU9yQ3o4ZnlZenhpREhzeUxYa0UyaFZMWStBNXhPQ2RkYlYrbFF5ZmVl?=
 =?iso-2022-jp?B?WklXQ2lpMDVSV0tZbVNNZUhZTFBISmEremR3VzY1VWdBVVoyZnJLUS9r?=
 =?iso-2022-jp?B?MG5yMVZlYWF0eXlRNFQ5V1U4VG5SUVpIUkxvVkpRRFVxb2hvY0ZpK1h3?=
 =?iso-2022-jp?B?YnhKZi8yTElkZmh1UXBNK3NCaEtpN2htMHAreEt5d3R0OFpaSkMwZE12?=
 =?iso-2022-jp?B?ZUJFQnBTVEZtQlNKajVFbEt3TFMzT3BCeXBtU1VRaE5GQlpxOTNSbGFr?=
 =?iso-2022-jp?B?QS9NVVdnWTdPMTB2bXI2cDM5T2NIOVB4MG5VMklYakZuMnlqS1grd2oy?=
 =?iso-2022-jp?B?TS9YaTg2T0JSS1kvRERmRDBoa0czWnNUb1BOOENZMnpoWDhXaTkxY0F5?=
 =?iso-2022-jp?B?TFJad2ZpTWhjMVUwUTc1MHNxenh6RERsMEt3VFV0LytXaWR6dEk1VXIy?=
 =?iso-2022-jp?B?WXcrM2FxeVdFeHVlR0dad1h3eXBwOHhvL0dKcnNQS3VtQjhQUVpyelVV?=
 =?iso-2022-jp?B?MUZ1ZVMwVjFnWkc4WHNrY0IzQnFqTXJaZXNjNHBHczFGeW91TjBueEZo?=
 =?iso-2022-jp?B?RnNmbGo3R0ZXZldETkppdUg3ZU5jK0RKb0g0OXNIc3Vad3c0WHNTWE5v?=
 =?iso-2022-jp?B?QWN1M0VqSnBJTTI0bm84MzYzdDZQYzUvNTJoYklRTkpCR2l4ZHZ0Y2tH?=
 =?iso-2022-jp?B?bHRVNlhsdEFmT1MwRnpGdWZYMkpaK3g2bmxxcGgwT1E1bEhoU0xtS3RN?=
 =?iso-2022-jp?B?TTF1RmVPd0xQR2FwSmxiUDNmYWJ6NXJHSmd6UkN3Z2JSMXUrK2gwbVlX?=
 =?iso-2022-jp?B?dWp2L3RmUDN3NnFFeW50MzY5YUprVUNMeVB1d0RneXJGbFA0b0doZk5m?=
 =?iso-2022-jp?B?Q0IvQU9hblRQYmE0dWVUN05wV000VFhrSCtRcFpGYXMyemlRdTl3cXlv?=
 =?iso-2022-jp?B?N0RiTDdmQWtDamoxN2lyMmdsWG1vQ256dVMwczgwQU4wamNuQ2FFOFNF?=
 =?iso-2022-jp?B?dElzS3ZLWFBFV1g2OHZNWUFrUmhEZXRvbjVNam1JdHZvcElMd3NMVWJ1?=
 =?iso-2022-jp?B?Rlo1aXpvSE5FUGMwS3V1UCs0cUI0MWtncVBKQkx1MElGckgxVkk4cGhE?=
 =?iso-2022-jp?B?Y0Q3Z1JTRnc1VFJYWjAzVHZ4Y0NLVk5iVkZjTkx5bTM3RFloVElOOVln?=
 =?iso-2022-jp?B?eEZlZVpOVzYvempncXdmVGQrS3BwelpNVm1UbzRyeVYxUExIUC9taEI0?=
 =?iso-2022-jp?B?ZGM1M3JJNllhS05EZFRySk5Rak5raEVMZkttSXZmbmNKSWxxSEpDeVlM?=
 =?iso-2022-jp?B?eDdxa1NuSnhVOWNJeXNtTHBZOVkxWWw5U3IwSzg1V1VTa1o2WWQ0QTRw?=
 =?iso-2022-jp?B?T1RsNzVKV0ZKdmU0bGNxSjhpa1FDYlp0UDdHU3hJV21NQVVQOGorQXpG?=
 =?iso-2022-jp?B?V2l6bzRSYXBMMUE5Y0tmSEVUWTdHbTF2M1doQzZJY2Zyenl6bStNZzdo?=
 =?iso-2022-jp?B?aFlGVmJneEtiaTRtQStwZ0lKOFgydmpTV1ZpVHNwU0dEeStIYUI0ci9x?=
 =?iso-2022-jp?B?UmRyeHVJNTI4dSt0V2lRNG5LRjBBdytnc0E5ZnlqV05WYnN6aGVnTHh4?=
 =?iso-2022-jp?B?a1hiQkVRPT0=?=
Content-Type: text/plain; charset="iso-2022-jp"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: fujitsu.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: TYAPR01MB5866.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 
 2cd40aee-446d-4380-5dda-08d9b315765a
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Nov 2021 08:51:41.0397
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: a19f121d-81e1-4858-a9d8-736e267fd4c7
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 
 615JuOxrzYIIeQd9MWqv3vTw3RCrBcvTtDweaCvzBEUN/fYl/eDxBDobmC57JUyf4LUCfZVAYXJWlx/JsKWeu9XLSRoMCtPz7zM89WzM+J8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY2PR01MB4267
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/TYAPR01MB5866D73C56A4363039175E56F5669%40TYAPR01MB5866.jpnprd01.prod.outlook.com>
Precedence: bulk

Dear Zhihong,

Thank you for giving comments! I'll post new patches later.

> +#define HOLD_CHECKING_REMOTE_SERVERS_INTERRUPTS()  (CheckingRemoteServer=
sHoldoffCount++)
>=20
> The macro contains only one operation. Can the macro be removed (with `Ch=
eckingRemoteServersHoldoffCount++` inlined) ?

Hmm, these HOLD/RESUME macros are followed HOLD_INTERRUPUST() and HOLD_CANC=
EL_INTERRUPTS():

```
#define HOLD_INTERRUPTS()  (InterruptHoldoffCount++)

#define RESUME_INTERRUPTS() \
do { \
        Assert(InterruptHoldoffCount > 0); \
        InterruptHoldoffCount--; \
} while(0)

#define HOLD_CANCEL_INTERRUPTS()  (QueryCancelHoldoffCount++)

#define RESUME_CANCEL_INTERRUPTS() \
do { \
        Assert(QueryCancelHoldoffCount > 0); \
        QueryCancelHoldoffCount--; \
} while(0)

#define START_CRIT_SECTION()  (CritSectionCount++)

#define END_CRIT_SECTION() \
do { \
        Assert(CritSectionCount > 0); \
        CritSectionCount--; \
} while(0)
```

So I want to keep the current style. Could you tell me if you have any othe=
r reasons?

> +   if (CheckingRemoteServersTimeoutPending && CheckingRemoteServersHoldo=
ffCount !=3D 0)
> +   {
> +       /*
> +        * Skip checking foreign servers while reading messages.
> +        */
> +       InterruptPending =3D true;
> +   }
> +   else if (CheckingRemoteServersTimeoutPending)
>=20
> Would the code be more readable if the above two if blocks be moved insid=
e one enclosing if block (factoring the common condition)?
>=20
> +   if (CheckingRemoteServersTimeoutPending)

+1. Will fix.

Best Regards,
Hayato Kuroda
FUJITSU LIMITED