Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1voJqG-001HBT-1a for pgsql-hackers@arkaria.postgresql.org; Fri, 06 Feb 2026 11:17:40 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1voJqF-003REc-1r for pgsql-hackers@arkaria.postgresql.org; Fri, 06 Feb 2026 11:17:39 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1voFzq-002RI4-07 for pgsql-hackers@lists.postgresql.org; Fri, 06 Feb 2026 07:11:18 +0000 Received: from mail-japanwestazon11011066.outbound.protection.outlook.com ([40.107.74.66] helo=OS0P286CU010.outbound.protection.outlook.com) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1voFzm-00000001Jxa-2e7w for pgsql-hackers@postgresql.org; Fri, 06 Feb 2026 07:11:17 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dx8p/cmFBZkNRZty++QorxYsJ30mMDpmz4+NEFj3Hf71Y4KIf7LNdXFV4y2lyEB53o9IaI+SjqPhp2HTdkkNgXfHe9rncR+onCwwHR+5ydT2wO1gc9sQJSUPOCwsW4XT9NXwKHeBXyrPB4xTOFtgUKvK8wu+n0354Ci2MpFeRZKKQ/HQNIIX+3U6UtY1+d6X3dfs33Edb+tMTLTK6OmDlt5ufqaTnbsUAN9fSBXA5rDVwYpkXp8gQGwTKuoa9gCmDdvVUtr0dP5RbdZNk9AY4uWd94TLDUZ0MfW4sNRHJA2YhHfH+n5AEy27FaNPQo6I3lMVRVIkLRIFeD6q9d3oIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lAt30HkoB5fKjjhtLlfrZk2vTRhmAVyPXHWlDC5Gzmw=; b=SZuL5hW4Z1Y3O/mB2SrDExmSCMGqJ1I+7ZgEJ47oyi+2JgrcQpv1B5rrrL6yj8/V5Ge1p6mZlEAJBBQjGYqbPJI/+eU3erQOFda6FGUTWnPBZdzbAE1xZmlKPFKONGiGgOzrKyg+m320mU7UYXmdth/sIQXBFwD3+YrEbnlfBRdKprXoN+rw1MjlvAS0xhvJrruaxrxfk27AHpwKHZ17I4VwelMDdkGVQbIn1Vvqu+XQ7mPR60Zl4lUuCkCdZLXoIr1yjbTwTTDhqw99qgtZ77RPvAID/diPR3mojeAJqrnNFOFPigRkPFPDG+wRflKrX06V6uzDAJurxkdj6HszEQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=fujitsu.com; dmarc=pass action=none header.from=fujitsu.com; dkim=pass header.d=fujitsu.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fujitsu.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lAt30HkoB5fKjjhtLlfrZk2vTRhmAVyPXHWlDC5Gzmw=; b=KTZLl/x7nNXhjgcxO0qfdd2baaYI8N6GIEqnTA2v0FIBcG8zHhP+iRP6HsmJK2BGF9fQE9i+VU3EMKmPC9XnaVvK3DAlEFSOad8NBPFN2EG9ZCSoeUrG22W2M2DQV407w65OTEeVMuO4mH4XPUzt73rEayjHjC8qaeL4yUAEbM1gxYRFIQZBwVgS6UMTajeU/dOS+zDi2/nUkA9NE2qZCNDQwrT+hKmXf3svIptzkVqXQ9QzM3lASVv0gd9NJE/qssD+FShMOIpajI8z3lN2LIPDdsvP4sC7S8M8Fxk75bjYF+NdcpwaoLPKaQmIajVCVPIKAZRrTmgWoBP9p9p6MQ== Received: from TYCPR01MB11316.jpnprd01.prod.outlook.com (2603:1096:400:3c1::9) by OS7PR01MB15156.jpnprd01.prod.outlook.com (2603:1096:604:371::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9587.15; Fri, 6 Feb 2026 07:11:08 +0000 Received: from TYCPR01MB11316.jpnprd01.prod.outlook.com ([fe80::f623:78ce:8186:d924]) by TYCPR01MB11316.jpnprd01.prod.outlook.com ([fe80::f623:78ce:8186:d924%6]) with mapi id 15.20.9587.013; Fri, 6 Feb 2026 07:11:07 +0000 From: "Ryo Matsumura (Fujitsu)" To: "michael@paquier.xyz" CC: PostgreSQL-development Subject: Concerns regarding code in pgstat_backend.c Thread-Topic: Concerns regarding code in pgstat_backend.c Thread-Index: AQHclzaQMTqJ362grkuRcSdy7WJNUg== Date: Fri, 6 Feb 2026 07:11:07 +0000 Message-ID: Accept-Language: ja-JP, en-US Content-Language: ja-JP X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_Enabled=True;MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_SiteId=a19f121d-81e1-4858-a9d8-736e267fd4c7;MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_SetDate=2026-02-06T07:11:07.394Z;MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_Name=FUJITSU-RESTRICTED;MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_ContentBits=1;MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_Method=Standard; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=fujitsu.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYCPR01MB11316:EE_|OS7PR01MB15156:EE_ x-ms-office365-filtering-correlation-id: a53d7a28-3465-4b0e-e8da-08de654ee637 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|366016|1800799024|376014|1580799027|8096899003|38070700021; x-microsoft-antispam-message-info: =?iso-2022-jp?B?WkdJQlFPVkp1YXBtQ2F1Y1hVVjhDQld3clMzKzI0enR6UlkxU2ZHZTVk?= =?iso-2022-jp?B?YTcrdTI0MnhaemJpNEFKaHgrU0c0K2ZhcEJ1ODlha0ZmMTE4WGtMY1NC?= =?iso-2022-jp?B?SDkzRllRMFNvQzJDTi9XVTVRVnlYaU4yNjNnaEpKZ1hiR1R4a09CQlk5?= =?iso-2022-jp?B?RW0wZ0VQNlFBTUc5NkF6YjJpZ0JxZ3JiUTl6L3lxMHNpb2dXWXQ1Q2dj?= =?iso-2022-jp?B?c3hzeVZ4eUptTnIwRWtsL1hhYWVOU0wrK0Y3ekRuajR2R2VEZGIrZW1E?= =?iso-2022-jp?B?ajRYQlI4cUc2QmFoSThVMVZydThENlhDTjhzWW5SS1VCYTZOaGpBb1VE?= =?iso-2022-jp?B?VHlPNUJadGd1T1F1Uk93RUpSeUliRkNNNG5hUkdVcVcxSFIvUlhVZ3VV?= =?iso-2022-jp?B?WDJnRXFpOXBWY01jcjlyTzJ2M0F6T3FNN1ZPZzlKSmIvYWhWQXZQRGZH?= =?iso-2022-jp?B?WkhGMDVnMS90SjVNUXQ2VEdEdldJeGtCcXc1SDNzc2tDN0RzSTArTjhX?= =?iso-2022-jp?B?RDR3cnRUcnU0SVM5M0xzeFoxek5RallFS0JaNnF2SnVuV0JFTGFRcG9Y?= =?iso-2022-jp?B?RjRWZUYvK3pJNkZYQ2FlU1pBRDRMZ3BrcUZYUENxNUphQVRjNWdaMndL?= =?iso-2022-jp?B?M2lUMmwyeWVEWXBpNGgySk52amJrQklRREJZbXhpR3ZibGMzaEZBdGRy?= =?iso-2022-jp?B?QzFBU2hhZnFod1I5bDBoZ2FkZmt4WE9TaXdyQXcwbURob2wwRVVBTk5E?= =?iso-2022-jp?B?eENTRVJ0TkRpa1RoVHFHVDc1aUw0T0xxQXV0V2I0NjUwZ29XZmNmU2kw?= =?iso-2022-jp?B?NFg3Q1JQclRVVi9uU09od3REaVRyb2M0MTBZOXNOOVZVV2dTK2FwQVhq?= =?iso-2022-jp?B?ZDhnclpKOFlEQ2pEY2haR2pWRlBUcGlyMzVkSWV5dTA3UTdYWlV5cklh?= =?iso-2022-jp?B?K3Ruc3Q5QzRPTm5JRVArVCtBU0xFSm9hZ1VDc2VreU5rQk90OVFGT3JO?= =?iso-2022-jp?B?ZkwxMllwUzc2QmRNUm1vRjUzUERkTUlNaEZtS280VGtoblRjMnJES3BV?= =?iso-2022-jp?B?TG14TkJyR2l1elZvN21wak5HQjRkUjhrTysvRVgxTzdLRlh6NElxMlVw?= =?iso-2022-jp?B?YTJzVzdjU2VsVlo0SXNaN0xDOGorRk1xS3UrRytSb0dQMzFiOGZTeVMz?= =?iso-2022-jp?B?YzI2RDR5VkpyY1NncDdDc3FXbUdkQUJoOWZkZDhGSnUyY1gvNlBRS1k2?= =?iso-2022-jp?B?YXFSb1BxaEFiM2xVNFBQR09ubkd2ck9yNTNRek9oYTR1Ylk1YzZUWE9C?= =?iso-2022-jp?B?STlzcXJMelo2MFBmMHV2NmRRSGoxNkJXRTRUYVBnUnRMY0puZTh4MWhJ?= =?iso-2022-jp?B?a3F1dFlOa1pueGxhZkcrbGZONUR0YmR3N0c3SmEzUlFBc1p6Y1BGRGNM?= =?iso-2022-jp?B?VmR5RDd6c1g5dXVpRUJnUjBiZEFhY3VmMmJycW1rbjRteE51T0pzQkVa?= =?iso-2022-jp?B?SUl6a3BRclJWeTVIQ3ZiVEhzTG5yVU92RHB5cFVuMHVzY1cwMHBoU1l1?= =?iso-2022-jp?B?S2E3V3hCZW5JTk5wRmNUS0VtYlVsVWNVdU1Ba0NrcGdNK3pjVjUxQmN2?= =?iso-2022-jp?B?SUFZcDhXdFJIczZEQUpadEQ1SThpY2Z1U1daYXpiRkE1SS9yUmFXakNs?= =?iso-2022-jp?B?cWxpMSs3bnljR1dNMDVVMHN3OGo3dmJBV2dmWGwzeXl1RmlLM25PdCtE?= =?iso-2022-jp?B?NWUrU3ozbnVGa0YvN2pUQVk2M1pzQnVDaVhwRStRL3NBNkNUZVg1NnBC?= =?iso-2022-jp?B?SWRMTUhLNmhrdUd1d3RDNlBNTVVLbTVIQ0llcmJRdzB2djQwNlMzcDkx?= =?iso-2022-jp?B?NDBCSkZ0SytLVVBLV3NSRHcrcXR4V0hoRzl5NStoK00wVzZNK2RoYjRo?= =?iso-2022-jp?B?bGJldlQwN3dZWWRXR2lNNHJCK0hmd0o1RVFRS0RRUDdaVzh5QVpuY09a?= =?iso-2022-jp?B?RUFOR2pYVWZ0dUNTM3duR1FBcnByK1JLTmxjWDdzdHZ3am1YRGNIcVg1?= =?iso-2022-jp?B?cWtMU2ZoM0ZCV3BmMTA0NDN3YW5nZU9zaTNublFOTkN2a1hoVXBmdEFh?= =?iso-2022-jp?B?WGt4R2ErZ0ZTQnJYNTFFMXpqamo0ZjBDMkxqK1hDZXpmSGhrSEFLUHox?= =?iso-2022-jp?B?Um5ZT0FPOXc3NmNkQWsxUEp3Z3B1V2huOE9iWmtpMGt0cFdLd1NFdExR?= =?iso-2022-jp?B?ZGFUSCt0bU1XR0FEbDlwdnBPOEFrcnQ3Y05vYk1ZcnpyTVZ4Y1o5TkNx?= =?iso-2022-jp?B?dlU0amdiWlNiWUlWS2lOK2NLS0VwUmx2VnA4MG1JVGhRMDdRT2oza21r?= =?iso-2022-jp?B?ZitKN3JoeFZHbTZhb1lrekRvYy9xOVUvRjlyYktic1NzMi9HNnU4blMy?= =?iso-2022-jp?B?Z1g1ektnPT0=?= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:ja;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TYCPR01MB11316.jpnprd01.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(1580799027)(8096899003)(38070700021);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-2022-jp?B?eHBzNWhQaEZDYjBmTEVBN2Y3VXRaVkwzcUJTQy9HTUttakhmREJXZkhX?= =?iso-2022-jp?B?MkpIWnJXVVlUdi84QkYvWW54SGxEN255WERDeGlndDRxbVJuTG1mWnEy?= =?iso-2022-jp?B?amlka0NUMWw3cDlpOUg2bmo1MXdoa2tOelFCa2ZWN0Z4RkFQaXZEbjVt?= =?iso-2022-jp?B?ck9UTnpiWFExYTRlTHdUQUpBVThaMW4ybThHMVlEeUN3VUpLcEo3M0VH?= =?iso-2022-jp?B?VGVYcnZQT0hwYlBDZ0RpbGh4V2F2ZmFINGdYb2c4MnJEMXBFd1IrVlkv?= =?iso-2022-jp?B?dER6bjZUVHBXTWFwWmFnZVhpV2JuQkw5bFpFS1BKUTF3NGs3YlVnckRN?= =?iso-2022-jp?B?eHdTVTFlT1FTZ0JOY2l0dW1YRmRQb2dFbmhZUDF2QWd5WUVJZ3A1OHB3?= =?iso-2022-jp?B?Y3RTRldrc2lhYkozUXNObTZJVFdLVXB0M0p0VWRYMWZCYVpaMHF4cTli?= =?iso-2022-jp?B?WjQvdWd1MGdhem9NTXgwenIrcmYrU21mQ0szb3RDNzRudzlnQ1U3NmZD?= =?iso-2022-jp?B?VVdsTWxhUWZQemN6N1E2KzhhSWxyZUZVQ0MzSDNtT2JOQ3hlUloxSXR4?= =?iso-2022-jp?B?ZHZ4aTc5enNuWmI2dmN2K3lKTDUzczdsQlRQdHI4dEhSbGIrQ1BQd21N?= =?iso-2022-jp?B?K1VtbGNiVksvVitRMjhtM0FNNmJEUkhuVmszM2oxT2RwUnNUZFBUUkhF?= =?iso-2022-jp?B?K2FQa3NoRGN3Q0htQ2VPNGhhVnZkWEFNMDF4OTc1QWZBZGU3VlBYVHFs?= =?iso-2022-jp?B?cGdKUDZXamNwU1pJblFqYlh2blB5MTh1VTFqcnI1ZHJVZm5UVjhzRVZE?= =?iso-2022-jp?B?L2xId1h4RDg0azNhR05ZVFlKamNLb0dZYWY2SGVvc1o2UEJhaDRxMHpZ?= =?iso-2022-jp?B?dE1aVFJBbDhUWXluYzVGTElYb05LN1hSUnEycFBvUEl1cVJ6SWp2TGpC?= =?iso-2022-jp?B?UVoraURXYlNqeEZnOHIwaHVUTndvdHN3QklycDlSTUVpTC9tRmE2RjhB?= =?iso-2022-jp?B?OG1pRUZiT25vMll4MHlyMjkvdUNXUS83V20yQW1JOXNvVit0bjdSakJQ?= =?iso-2022-jp?B?UFkyUEk4bWl5WmcvMVVJU0RYOFQ0UHplRmk2MmFmaDBDREdOSTc0S2s3?= =?iso-2022-jp?B?dXU1RHUycWJ2TDFCc1NZVnJNeW9xeklFaHRPelhnMC9sNjlwazgwVWgx?= =?iso-2022-jp?B?OFIrdzFRSTVPcjhjd3djM2IzU2JtMEFMekQ0S0NxWHRLWmdQdEt3N3J6?= =?iso-2022-jp?B?L0ZpcEpwUExXYkpwMUVjTzlleE05QkNWcWd4SnNITVdTN1o5MFA1Tk1u?= =?iso-2022-jp?B?NEw1bDFYT0kvTkZQVXIyL3o3Y3VmTzcraEd1Tm1CVllIWmcvWjFCMXBo?= =?iso-2022-jp?B?ODVPZ1FxV2RURngvRmNqZERzc2JtYnl4THFmT29UZnVaeExhQzBWN1E5?= =?iso-2022-jp?B?WFRPa05YbDJKRGJzUkNldFhwdFhMdFFaaURLQzNvTVhlK0w1REFaRG4r?= =?iso-2022-jp?B?M244dTd0Z214bEgxZHZXK2Nqb0JObi9raEFLbWZneVlpOExjNWxOZzdB?= =?iso-2022-jp?B?ZmhhOFpoV2pOM3BKUEk0TTIzNklNODBtNTJVRWpQdmcxcG5ROE9UQ2po?= =?iso-2022-jp?B?UzhFaGNBVzlwZ2dwNG5BL3BuekxFUUhqcWRKaURibXl1KzZlM2w3WFV4?= =?iso-2022-jp?B?N05zVXdiaG5IOGJBTTFoRXdXT1dROWFjZDlMR2dodSs1MjN0RU5uUTFS?= =?iso-2022-jp?B?LzdsazBSMnEyV3pvcDZNbjVMK0F1VmVKMVZKcmZEWEIyVkVQWG5KSWEv?= =?iso-2022-jp?B?aVJmN0dKMXFXTERsMm9yUUxRb0VsNXVBOUxRWk8rTEcxbjJhMG1NUXJE?= =?iso-2022-jp?B?a0RTTVVZcFFVbWdOR0NwSEQzUytFZ1JvelNxZWJKUE4wdnRaekh1NUVY?= =?iso-2022-jp?B?V0lNWTdyL25kUm9QZzUyalV5NEZTNFFEYUhhT1RVdnIxMTVWbG9KcmRp?= =?iso-2022-jp?B?VnZpdkxpbFpkVUZyWGFrUW5abkpxbGVmUExJeU9FRGE0ZWJJY2hMRFl4?= =?iso-2022-jp?B?VERBdTFpY2pKRXM4NXA0MWU1dzFQaEJpOTlWRHVnS0YzY3VyRUdhNVhl?= =?iso-2022-jp?B?UFREVnNvb1RFU1Zqdyt5dEtjM0VNVzVvU1dZMy95M2JhejEycis0WXU2?= =?iso-2022-jp?B?MS8wM2YyaGVSS29ZVFQwQ1Jwa3lVNHc3Y010WWdpSnE0Z0FlZitlc2Zm?= =?iso-2022-jp?B?d29EcmNPL2oyL3ZZckhjaERnRnRmdEg3bUtkakpUMnFsekNuZzBNRStX?= =?iso-2022-jp?B?UjV6Q1ViaHhiZDgxdnREVFhTSVNCcldIZkhVaXp2M3JnZ0hLUHF5SURq?= =?iso-2022-jp?B?Q2t1SGxBaG9JR29xQkU4YktnbFl0TytxQU9OOHdyNTRDeGN6Q0x6SW5H?= =?iso-2022-jp?B?ajVNVWtqaWxtRzc0TGxCSTl6UU1EdTJWY0o5Sk1XWU9kVlYyVTJKenp5?= =?iso-2022-jp?B?bk5aZjNjcENIdm9JTkoycUF2RzhTMjBYRjMyZz09?= Content-Type: multipart/alternative; boundary="_000_TYCPR01MB11316AD8150C8F470319ACCAEE866ATYCPR01MB11316jp_" MIME-Version: 1.0 X-OriginatorOrg: fujitsu.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYCPR01MB11316.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a53d7a28-3465-4b0e-e8da-08de654ee637 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Feb 2026 07:11:07.7183 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a19f121d-81e1-4858-a9d8-736e267fd4c7 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Cy58BX4P+7Bx7z2idOacKafpaBf/G2hGWAGBVRTnEduiVGuBqYOjXGc5C24KKbY8elRWGT+Y5MqcFCYewg7r4bPyVT9EWex1/t9LRnCcHno= X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS7PR01MB15156 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --_000_TYCPR01MB11316AD8150C8F470319ACCAEE866ATYCPR01MB11316jp_ Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable Hi, Michael and Hackers, I found the code that is likely to cause bugs in the future. It's not curre= ntly a bug. Should I have misunderstood, please feel free to disregard this email. pgstat_create_backend(ProcNumber procnum) uses MyProcNumber instead of the = argument. I've had a quick look through the commit log and thread, but I don't seem t= o have found the reason. Wouldn't it be better to use 'procnum'? This change seems to have appeared in v2-0002-More-work-to-allow-backend-st= atistics-in-critical.patch on 2025-01-20 06:34:41 https://www.postgresql.org/message-id/flat/66efowskppsns35v5u2m7k4sdnl7yoz5= bo64tdjwq7r5lhplrz%40y7dme5xwh2r5#fba8e490848df1798e7c693c70a43f56 Best Regards Ryo Matsumura --_000_TYCPR01MB11316AD8150C8F470319ACCAEE866ATYCPR01MB11316jp_ Content-Type: text/html; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable
Hi, Michael and Hackers,

I found the code that is likely to cause bugs in the future. It's not curre= ntly a bug.
Should I have misunderstood, please feel free to disregard this email.

pgstat_create_backend(ProcNumber procnum) uses MyProcNumber instead of the = argument.
I've had a quick look through the commit log and thread, but I don't seem t= o have found the reason.
Wouldn't it be better to use 'procnum'?

This change seems to have appeared in v2-0002-More-work-to-allow-backend-st= atistics-in-critical.patch on 2025-01-20 06:34:41
https://www.postgresql.org/message-id/flat/66efowskppsns35v5u2m7k4sdnl7yoz5= bo64tdjwq7r5lhplrz%40y7dme5xwh2r5#fba8e490848df1798e7c693c70a43f56

Best Regards
Ryo Matsumura
--_000_TYCPR01MB11316AD8150C8F470319ACCAEE866ATYCPR01MB11316jp_--