From: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>
To: 'Kyotaro Horiguchi' <horikyota.ntt@gmail.com>
CC: "barwick@gmail.com" <barwick@gmail.com>, "pgsql-hackers@postgresql.org"
	<pgsql-hackers@postgresql.org>, "robertmhaas@gmail.com"
	<robertmhaas@gmail.com>
Subject: RE: Have pg_basebackup write "dbname" in "primary_conninfo"?
Thread-Topic: Have pg_basebackup write "dbname" in "primary_conninfo"?
Thread-Index:
 AQHaY4w65IBe/94StU+MpHyUhcCkE7ES+IvQgAAZ+YCAABLU8IAAJQ4AgADT2gCAACE5IA==
Date: Wed, 21 Feb 2024 05:08:51 +0000
Message-ID:
 <TYCPR01MB12077971400566CF058270132F5572@TYCPR01MB12077.jpnprd01.prod.outlook.com>
References:
 <CA+TgmoYfagyp5AvKMfGpRUgXNJZ0ymuqiWTzOc2tV_ZMM0UkCA@mail.gmail.com>
	<TYCPR01MB1207777150173002564A753B8F5502@TYCPR01MB12077.jpnprd01.prod.outlook.com>
	<CA+TgmoaLRCcCeY3_n7h0rw-r-UfJt_GiFZiJQ1pFZ-iQNUozug@mail.gmail.com>
 <20240221.120424.79274783106518358.horikyota.ntt@gmail.com>
In-Reply-To: <20240221.120424.79274783106518358.horikyota.ntt@gmail.com>
Accept-Language: ja-JP, en-US
Content-Language: ja-JP
msip_labels:
 MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_ActionId=beb83c30-2969-4a9d-b861-7e636aba950d;MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_ContentBits=0;MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_Enabled=true;MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_Method=Standard;MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_Name=FUJITSU-RESTRICTED?;MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_SetDate=2024-02-21T05:03:30Z;MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_SiteId=a19f121d-81e1-4858-a9d8-736e267fd4c7;
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=fujitsu.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: TYCPR01MB12077:EE_|TYCPR01MB12108:EE_
x-ms-office365-filtering-correlation-id: 5f18b957-dca2-471c-5a0c-08dc329b31ca
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 +TjQFfxytP9DHsQUz8xG4WpohW1M7i4JXca8uAjKCR/4VV0QW+KTeWejrP058vImRZ5CvwxVujAZYrRvn3MYtpcqUzZ7+fB8IpnbIzSrutNtZ2cBXKZqaSfDZsOsRy0uIu6lqhprBVzQ6N/3k593eo6CPJ5s7YbOkrmGJf1AdE2Vyg820PygSrH4SMfMbLhmW7GdJnweThNRw8BwnApWZo0T/x547EA+gm3M8XMFYsCSUNlH2knIi/ZitiVWUz2xHJFldGox6HGwbjpzSWGv000COZSyUMH+REEy2++oylLS/x5yUo7wnonjIgkeeO5Zrn6X/JqvWF40wX9Ao7AMQ2kTBFBhhx4jHOeotdacUUEga2krtjyjAPeuwHlxm3BtLzh/MmQD2lwzB5IAbulkh36SX6XPRgQ9O8AtUKf87VLp3o5uA0V4pF0oEldOEgjVLnqeY4Limvguvp7VTC6QbhnO8a6YLX64FT8sYrIIWuppK9UX7ENkL/Z4wS+v2+g9HY8p7ZO5tnitFgF+zkwp4hgGsnVgJrdeiwlEK0PIBMoNyCX8GY72m+VeIdpvcps1I7zQi97GUKL2A2bYsJCQiOer4dX1bXwekVeJFFFAg2lywXKJrAiG1dCuZ5TpDo7/oAkXEBOjUHd/tKdYZUy1CA==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TYCPR01MB12077.jpnprd01.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(1590799021)(1580799018)(38070700009);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?iso-2022-jp?B?cjdNQWdhWGQwREQzQmQxekxFcU9PSnJ4N0lMVTZ4MjlTUkJMdGRsR3hw?=
 =?iso-2022-jp?B?bGx2c2ZhMXhWZW9GeU50UmhMNy93M3IwQm5qM2IvVENTaWhmaEdCWXBC?=
 =?iso-2022-jp?B?OEdsbk8ramZUMmFUTGFFNmpEYWRUSHoxSFhiNnRkNU81L0hqck5rUXhE?=
 =?iso-2022-jp?B?RlFkeTROM1pvcTk1d1haNEJhVmxGMlgzSVJEWnVKOTBweTdnSGxIeWsy?=
 =?iso-2022-jp?B?WVVxYzZ3b0EydWlxNlZ5YWhzQUl5STN4VUFrRVJpZXppVEZ4enk4RzhF?=
 =?iso-2022-jp?B?OHhrMCtKOU90dXlFWHBtZkNjSENGUWlHL1hIZWdETXl3Y3NFRHc2NFo2?=
 =?iso-2022-jp?B?dXpZWGFmY3NGakgzTEVIVU0yaDN3bUloMHZDUm1HVEQ2STc2LzB2TW8y?=
 =?iso-2022-jp?B?eWsvaFBIVHJwUUJVVWYvZkYvMmRuL1QzbEpZckxqU0VkczA1UjlKcW1I?=
 =?iso-2022-jp?B?blNoNnE0Y21qd3VDckRmQlFOSkRjL0ZUNUx5U1picHhsOC85VFl2U2Jh?=
 =?iso-2022-jp?B?V0hrN0RzUEI0bEorYmRCQTVqS3BLWTVLN0NhWWZYTVNBUTZZY2ZnWUk3?=
 =?iso-2022-jp?B?aEFIYThVcnptRFZDN25iUnNvcS9xL3F3bDdYdjFUN0w1NHNCS05BYVpJ?=
 =?iso-2022-jp?B?UjVHbE54c0RaWW04LzNLdVFjT2tYSjlPd2o5UWRUTUFScm9ZR2ZPa2cr?=
 =?iso-2022-jp?B?WEY5UUQvQmJITC91bExIWGNYclFKRXN5aHJFanI2aHhxWnVQMkhWUmlJ?=
 =?iso-2022-jp?B?aVRsUTZuTjhxMzZBRnZ4dDRXRFp3RWhFeTZKQTJURlNFUFR2SENxR2E5?=
 =?iso-2022-jp?B?QkRUOE9VUmg1VXFzTStleFVsZitWZnd0Rys5d0JSM2ZOd2tZeWhGcERI?=
 =?iso-2022-jp?B?Ym9pU25PT0Zadm5JcHNOSldlRE9nc1RIbXRMWkFDRGpFVk0vLzBiL2pJ?=
 =?iso-2022-jp?B?U2tWMW8vL3lnRmdaMmsyQmFpWEttaWhuMDdtQjYvWVRCcTdHNklXMnIz?=
 =?iso-2022-jp?B?SCtjV0dFU2JWTGlacHNZSFJ5ODcySGZxSEJSa3NITDZ6ajk1czFVV1Qz?=
 =?iso-2022-jp?B?cE90b2pVb2hiUWVWUHFaS2ZGU1hkVzk2Y0lCeDNoNmQvcXNKNlhrWmVP?=
 =?iso-2022-jp?B?RU9VYkQyY2ZDMWZPUklvUVUvRk8xeUg3M0UxY3pDdG8raHk0S0czeVh6?=
 =?iso-2022-jp?B?OGxnekVleGt3RjhJZ09VUFFBd3U2c04zQUFzQnk5eTBuSlRTaHRES0tL?=
 =?iso-2022-jp?B?K2FWcm1ESExneVVTMTVQYnhmd0ZTTG93bmhjUWt4cGRQYzcwZDRkQXBw?=
 =?iso-2022-jp?B?MG1nTERKZTk4RHBFUytFQnJJYmNJL3UrSm9BMWp4K3ZkOE1TbjdBK3Jl?=
 =?iso-2022-jp?B?K2NkZWhKTmtrV3ZqN2ZUQWc0ZFJscWZ3MUR6aXNxdEE1dGtHT2JuOG1u?=
 =?iso-2022-jp?B?MUpKU2R0cVFpUEdBOUVXYU9OOS9kMEYrcktqcVVweFFzUmV6bmRwRHlI?=
 =?iso-2022-jp?B?ZTAzSEFJZEszdGlrRUErKzZENktCamNXU1B0Sml6UE1vZ2E2N0xVWnBi?=
 =?iso-2022-jp?B?amI3d0RQazFGS2R4OHVKOUo5TVY1SGJzYmxrOGRrTTY0emx5Yk92Tmd5?=
 =?iso-2022-jp?B?YitTbkFleHVkaS9YcnRyUUtvbHFnL2FYSE1hL1lvRkhZck5obTF4Wmww?=
 =?iso-2022-jp?B?KzY1Z2M2c1RibFh0K1dCR1dQRVFGRk81M1FXUUVPc245YWRjUFlkaHdD?=
 =?iso-2022-jp?B?WlRhSytnTlFXQnN6SFprUHR0VzdsK05vOGdBNVdPNHl3akp4dUM1YmdD?=
 =?iso-2022-jp?B?Vms4Rm9iUjlqdlU4R3ZmMkNKSWxUbU9iaTNtNjcydW9FQ1VXUDBvdzE0?=
 =?iso-2022-jp?B?YU5hbitSNjA0ZElzNzl5ZnlhbnBlbWRpNDBxRzlXNE5CRis3b0lzMWdL?=
 =?iso-2022-jp?B?cTlPL0hhL3NkeW43N2VHWTN5SjRIMEZlZFBmcytPSm9HVnNDdFNSMENF?=
 =?iso-2022-jp?B?Ym9QS05aME0yVjJrZm8rTjhBOWxoT3hFakJEV1VPV1gxR2N6a2xweFM5?=
 =?iso-2022-jp?B?YURIdTUxOHlEY0hnQ2ZxZlpxd0EwMmcrMkE4ZWpyMFBaaTJ1SnpWNTJG?=
 =?iso-2022-jp?B?aG9KMjJZTEpnWENmSlBqRGs2RUJzUGszQWhNUHZhVHpSLzI5QnE0MVlX?=
 =?iso-2022-jp?B?VHdVQ2UySkdPWWdHV25ERTVPWnczUWRLUG1yZzJpdldnRXZEWm4yaHIr?=
 =?iso-2022-jp?B?cFZ1Tk93dE5zS2kwVmxBR0gxdk9kcVl2Uk9PZjZwU09HODU5Sy9yY1Q5?=
 =?iso-2022-jp?B?eGJNalFEK3VZQkFwRllPaWRRVnQ1Q3VnWnc9PQ==?=
Content-Type: text/plain; charset="iso-2022-jp"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0:
	h/0MAdX98Eo+R/E2T1+/ETUFggiwIY9mSnk8dsxMlRpIhvfuPTq/mgpWLYy13ypIxf4PzgLfZiZBGJVm40dShVog9kGZm5qsTe6NFqyu+3d2GLMdQllyGeybQVScxCh+WJqy+ZUzQ8YqR0WA5ZcXoJVfH4LM99uMCaq582soLsmMq1hRRJXnzJWw6MyiNrANa2ZwSTJnEH7rqClBaZdk64lavy2fRo1KmtJqKWbEVxK0dNyd+mVf+n5e+3oDLx+eC5enrN3yL25GOsqm3EGro1MXv6Vbtv/j0ODlgVLykVBfu8zLD4Gc9Rl5XRfyRamsSaBnBdJgFXEDbIzlJDc1PYdZHG5YEtstZEFFUwKngXQSx1cVUumIO5rBIzTmhpj7W8hCgJzC0oZsh4l8NnHsy7/fy/oYifA41YNgzVjM4Xa3vVcx6UIO1GiIq7DJQlrOImHFS3TYPs/N6XLL1aFjuZnKBlBP21JnQvFBhA1e+InD6M64gcC7POP7uq8rdyyd1QJhgU1Nv8+bePOPw8OX/DFixIetmGtEVow394OM46f05Iw6mY3dDhHr80HGUlsPUSqfAC0jnEH8m24jdare65dKnSKl14nFKljUjhT4Dwmi5kYUbcXSZjEo5pNmE3T7
X-OriginatorOrg: fujitsu.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: TYCPR01MB12077.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5f18b957-dca2-471c-5a0c-08dc329b31ca
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Feb 2024 05:08:51.6260
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: a19f121d-81e1-4858-a9d8-736e267fd4c7
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 2qif5SHd0Q+GXx3NGtVIx+VawpkPd9TR8njFcd0thpGeoU+fTjT8fwxmus3IY2t1cdcwsyMujiMlilVhMIOqMNWiKdqDcfsgQ6BKBTmoAiE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYCPR01MB12108
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/TYCPR01MB12077971400566CF058270132F5572%40TYCPR01MB12077.jpnprd01.prod.outlook.com>
Precedence: bulk

Dear Horiguchi-san,

> GetConnection()@streamutil.c wants to ensure conninfo has a fallback
> database name ("replication"). However, the function seems to be
> ignoring the case where neither dbname nor connection string is given,
> which is the first case Kuroda-san raised. The second case is the
> intended behavior of the function.
>=20
> >	/* pg_recvlogical uses dbname only; others use connection_string only.
> */
> >	Assert(dbname =3D=3D NULL || connection_string =3D=3D NULL);
>=20
> And the function incorrectly assumes that the connection string
> requires "dbname=3Dreplication".
>=20
> >	 * Merge the connection info inputs given in form of connection string,
> >	 * options and default values (dbname=3Dreplication, replication=3Dtrue=
,
> etc.)
>=20
> But the name is a pseudo database name only used by pg_hba.conf
> (maybe) , which cannot be used as an actual database name (without
> quotation marks, or unless it is actually created). The function
> should not add the fallback database name because the connection
> string for physical replication connection doesn't require the dbname
> parameter. (attached patch)

I was also missing, but the requirement was that the dbname should be inclu=
ded
only when the dbname option was explicitly specified [1]. Even mine and you=
rs
cannot handle like that. Libpq function PQconnectdbParams()->pqConnectOptio=
ns2()
fills all the parameter to PGconn, at that time the information whether it =
is
intentionally specified or not is discarded. Then, GenerateRecoveryConfig()=
 would
just write down all the connection parameters from PGconn, they cannot reco=
gnize.

One approach is that based on Horiguchi-san's one and initial patch, we can
avoid writing when the dbname is same as the username.

[1]: https://www.postgresql.org/message-id/CAA4eK1KH1d1J5giPMZVOtMe0iqncf1C=
pNwkBKoYAmXdC-kEGZg%40mail.gmail.com

Best Regards,
Hayato Kuroda
FUJITSU LIMITED
https://www.fujitsu.com/=20