public inbox for [email protected]  

help / color / mirror / Atom feed

From: Takamichi Osumi (Fujitsu) <[email protected]>
To: 'Nathan Bossart' <[email protected]>
To: Hayato Kuroda (Fujitsu) <[email protected]>
Cc: [email protected] <[email protected]>
Subject: RE: wake up logical workers after ALTER SUBSCRIPTION
Date: Tue, 22 Nov 2022 07:18:40 +0000
Message-ID: <TYCPR01MB83731782CB6FF64C3F058F29ED0D9@TYCPR01MB8373.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <20221122043916.GA230228@nathanxps13>
References: <20221122004119.GA132961@nathanxps13>
	<TYAPR01MB5866233C60501EA7CBFE4385F50D9@TYAPR01MB5866.jpnprd01.prod.outlook.com>
	<20221122043916.GA230228@nathanxps13>

On Tuesday, November 22, 2022 1:39 PM Nathan Bossart <[email protected]> wrote:
> On Tue, Nov 22, 2022 at 03:03:52AM +0000, Hayato Kuroda (Fujitsu) wrote:
> > Just One comment: IIUC the statement "ALTER SUBSCRIPTION" can be
> > executed inside the transaction. So if two subscriptions are altered
> > in the same transaction, only one of them will awake. Is it expected
> behavior?
> >
> > I think we can hold a suboid list and record oids when the
> > subscription are altered, and then the backend process can consume all
> > of list cells at the end of the transaction.
> 
> I think you are correct.  I did it this way in v2.  I've also moved the bulk of
> the logic to logical/worker.c.
Hi, thanks for updating.


I just quickly had a look at your patch and had one minor question.

With this patch, when we execute alter subscription in a sub transaction
and additionally rollback to it, is there any possibility that
we'll wake up the workers that don't need to do so ?

I'm not sure if this brings about some substantial issue,
but just wondering if there is any need of improvement for this.



Best Regards,
	Takamichi Osumi

view thread (46+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: RE: wake up logical workers after ALTER SUBSCRIPTION
  In-Reply-To: <TYCPR01MB83731782CB6FF64C3F058F29ED0D9@TYCPR01MB8373.jpnprd01.prod.outlook.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox