From: "Takamichi Osumi (Fujitsu)" <osumi.takamichi@fujitsu.com>
To: 'Peter Smith' <smithpb2250@gmail.com>
CC: vignesh C <vignesh21@gmail.com>, Kyotaro Horiguchi
	<horikyota.ntt@gmail.com>, "Hayato Kuroda (Fujitsu)"
	<kuroda.hayato@fujitsu.com>, "shveta.malik@gmail.com"
	<shveta.malik@gmail.com>, "dilipbalaut@gmail.com" <dilipbalaut@gmail.com>,
	"amit.kapila16@gmail.com" <amit.kapila16@gmail.com>, "euler@eulerto.com"
	<euler@eulerto.com>, "m.melihmutlu@gmail.com" <m.melihmutlu@gmail.com>,
	"andres@anarazel.de" <andres@anarazel.de>, "marcos@f10.com.br"
	<marcos@f10.com.br>, "pgsql-hackers@postgresql.org"
	<pgsql-hackers@postgresql.org>
Subject: RE: Time delayed LR (WAS Re: logical replication restrictions)
Thread-Topic: Time delayed LR (WAS Re: logical replication restrictions)
Thread-Index:
 AQHY9/SeVGNfJ+eMH0OkVO9Bch6SIa49/p8AgAAf6ACAABrAgIAALyYAgAEoiICAGrgLgIAGnftQgAEcg4CACAUGgIAAVUUAgADhA4CAAJ9SgIAA6ooAgACaBYCAAPtugIAAI30AgAsiVvCAAjbLEIAEQWWAgAGfSACACtcCAIALd3wAgAFMWoCAAC9FAIAA74IAgADRMqCAAoxsgIAFAcUwgAFSZoCAATe4AIAAbdjg
Date: Thu, 19 Jan 2023 08:16:11 +0000
Message-ID:
 <TYCPR01MB837334F4E55DA5ACCA5E128AEDC49@TYCPR01MB8373.jpnprd01.prod.outlook.com>
References:
 <TYCPR01MB837340F78F4A16F542589195EDFF9@TYCPR01MB8373.jpnprd01.prod.outlook.com>
 <CAJpy0uC2Czf2iJ17yHf4gnMb9pVJyc2QXVe6_NfxiwHhdNLmVg@mail.gmail.com>
 <TYAPR01MB5866D0527B1B8D589F1C2551F5FC9@TYAPR01MB5866.jpnprd01.prod.outlook.com>
 <20230112.120338.534662300633460797.horikyota.ntt@gmail.com>
 <TYCPR01MB83739C6133B50DDA8BAD1601EDFD9@TYCPR01MB8373.jpnprd01.prod.outlook.com>
 <CALDaNm2d=+WBGye015DoACY_PzrRKdmwjeZwDa+Y9LXFqnT0Ow@mail.gmail.com>
 <TYCPR01MB8373F3E780D5BB60E441ECF3EDC69@TYCPR01MB8373.jpnprd01.prod.outlook.com>
 <CAHut+PsydEoqQaDv861qS_366hBovYAE8RRoDu3=+sBM=yo3Dg@mail.gmail.com>
 <CAHut+PswgSwSu2a-nEsMVtdf6QmuQNto3_B3S7hJy+jtJSUtDw@mail.gmail.com>
In-Reply-To:
 <CAHut+PswgSwSu2a-nEsMVtdf6QmuQNto3_B3S7hJy+jtJSUtDw@mail.gmail.com>
Accept-Language: ja-JP, en-US
Content-Language: ja-JP
msip_labels: MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_Enabled=true;
 MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_SetDate=2023-01-19T08:16:08Z;
 MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_Method=Standard;
 MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_Name=FUJITSU-RESTRICTED?;
 MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_SiteId=a19f121d-81e1-4858-a9d8-736e267fd4c7;
 MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_ActionId=493d9e67-3624-4bee-82f5-2b515d1f9bd5;
 MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_ContentBits=0
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=fujitsu.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: TYCPR01MB8373:EE_|TY3PR01MB9683:EE_
x-ms-office365-filtering-correlation-id: 944332a4-8e3f-460e-c8df-08daf9f56cda
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 NCbPF+q/Oh3ws4zuHSf9qPXCPgsLaBWDhw6wL7JTjTWUEIIDlWB6ilVMjh+hIyv1dLaLDyfWsmGd/Ha7++pxAenqgmU4g7nbGXZRP1bhtkoYewmxSWh8ou8g1efG7QkJImElEVCTsuTTRGG+PQULduUTSl1HR+V+XYmRNddJJjopX6qDMAJHeTJGG/AuVcca1cXKZv5Ov/OLoYj0f+hLTX8awYb3aQMatZSDQvqchvsQEpogDpGbGxOsGFOMg0oIw1nGtC8O9O0I35dHtDXA3ZTqogkdiQricwjVm5gl/3cxjxmO0rcKsxvClio2sM39G5VP1uRupQAqzt0xK0/UmcqMs5B95Wy4oXB630eVHq6PL9jPtLwq+E9d26vnqf9h/ycSaf4WG+D/wNynujGXAXE0GdSoQ8epZp7qTsxl/BLuAyIFqbvRDFc5WzEggiAXIp1ukA2lGJWh0UD9f+EAkhaKe0tBSuq+C+t1R8fT+emCuv2oMeDRo0BNXEYLkqM9JJXMhw2v7OaRy4I8cHIb65YZhxiuqg1IJfG0peXcX5MGUFXtUmM1dplSKxrJCs8Y3gAFfBhYLH07SYlCNJRPgKoVdbGRseCivrG8YLY5KVuyccqyUfbGHSOb1YcIMOKSWZPa/qympolfbt3YcMoyseMIoWQNwL8roftJtNsrTTzpW9dIz6klBABldxG72wtpGALzdxUJ2RVg7msP/g0vQvYHo2AcVW8dzaQK+YKhRV0l03kDxAQLyd+6UlZLjrLgo3sWww5KE+zJ2TPGQvwZjg==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TYCPR01MB8373.jpnprd01.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(346002)(136003)(396003)(39860400002)(376002)(451199015)(1590799012)(82960400001)(38100700002)(122000001)(85182001)(55016003)(1580799009)(38070700005)(52536014)(64756008)(66446008)(5660300002)(8676002)(41300700001)(8936002)(66946007)(66476007)(66556008)(76116006)(86362001)(6916009)(7416002)(4326008)(2906002)(966005)(478600001)(54906003)(53546011)(186003)(71200400001)(9686003)(7696005)(316002)(26005)(45080400002)(83380400001)(33656002)(6506007);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?iso-2022-jp?B?MDN6QlhxWUphLzgzUXRreXVxa1M5aW55d2VFcFdkM3FNVUlXamwvMys5?=
 =?iso-2022-jp?B?Qkl0Y2xKWXV3bmQ5eWRZUDNlSzhYNWVDVFE2aGlocnhIWWZvRWVONWps?=
 =?iso-2022-jp?B?MkEyTVBROXc1eUVyaWFUMHpVTlZrSTM5RmN5Y2l5czhWdE5zRDNmQ1V2?=
 =?iso-2022-jp?B?R1FvYUhVRGVSemZmQUZIMjUvT0YvRVo1VmtMbytjT25INEdBSjF0b0VY?=
 =?iso-2022-jp?B?ZzZzb25JWVIzbGMvLzZSdjVvR05UZGdYa2IxYTNNQ0Ixb0lmWWZ0Yk5C?=
 =?iso-2022-jp?B?RlJwVFRnOUhOT3FYbExlZGFOV203SkV3eFdGQlM5MFQ5bExOTkh2UTJX?=
 =?iso-2022-jp?B?eFBac01GdDU5QXZFcVZLMmp6dzNkakdvVHcrRVNhdmNEa3NhSzhYTDBz?=
 =?iso-2022-jp?B?aFVEK0NsaFVsdnprM1QwQU5NcW1ieXZLZ1VDUUFMSlhiNDg0cHpmajdw?=
 =?iso-2022-jp?B?MmpRSElqd1ljKytCNUlyQ3FZY1c5RVlpZ044RUl5d0RFM3N1WjFiRzls?=
 =?iso-2022-jp?B?VXZiR3ZuTmhoMVdLQ3FlZUN1VjZBQ05yTU1UaGlONmNUb0VQUTk4eWhG?=
 =?iso-2022-jp?B?Q0hiaFRVMVR4aGFISnBoeFZwaVFOQWdqdFkvblVFanhIY21Hc2dLSUl5?=
 =?iso-2022-jp?B?UXVtOVE4UllIbmU2K3RlK3FlTWlhL0RmcERwTlExdXNlNml5VVFNOTdy?=
 =?iso-2022-jp?B?OUNtTTZlL0Q1MWNiYmhQeUozdkIwVjZzdERYT2F2TFBKZGxqcUZneTB4?=
 =?iso-2022-jp?B?dVdadHFNbS9TelJEckoyaUhCb0pqeFk3TDcvMkxVMHV0ejNkWmhJODEr?=
 =?iso-2022-jp?B?bzFtSG5BVEc3Ukc3a3hMcE5TOWJ0MXR5N0grZm1qczNTNEpCRk4xMmpY?=
 =?iso-2022-jp?B?T3FZekc0NXNDYzZVYXJ1bG1rcU9GSzJWdVpLMFVvQWVURHM4RDRxcmF2?=
 =?iso-2022-jp?B?RktQOHl6ZU0wR3hWeGttR3FOZ0Rha09xV2xJL0QweExBWlgzZ3NhYk1Y?=
 =?iso-2022-jp?B?Nmt5bUhQVjgzMmdsRmtrN0p2NXU2d0x6eWFoZWhWYTRxZG9BQUhQbHox?=
 =?iso-2022-jp?B?Sm40ZmV0YWYvOGkwMDR5SkJJWWR0dDI2OTZxd3VnWnFiR290NGtjM1Qr?=
 =?iso-2022-jp?B?YlZNcytvZ1FzanN5UG1POWREUXJCeGt5cU9ySTVGWitJTzBMMXlpMyto?=
 =?iso-2022-jp?B?Q2ZZOExVTkJ1T3JNZGxIU1owbzRqTGN2WlhtRG5Dck81T1ErbTJEOVlT?=
 =?iso-2022-jp?B?dHJJWDk1THNPcndwTTJwdlpsOWI2K01JZnMyT05wQ1Z4aFdjdDd6QXZS?=
 =?iso-2022-jp?B?cXdYODdab0JkTHNpaXF6NHVPSm05SHR4aDZJejdkMDQxQXRWS3VIYTQ1?=
 =?iso-2022-jp?B?Y00zSTRCbjlMTVlYbjFwN2xVblMxRnAwYkQ2TTFlU2l4QXlvZTlYRUtG?=
 =?iso-2022-jp?B?azB5SmRjektuUVJ6RXpiS0wzOERsWjZRMVZjZzNXaVM0Z29JVnlGZHR6?=
 =?iso-2022-jp?B?RktmaDVZQWt1VnRCek5WSmxFVjc0TW8wNGsydEtUc0hKTG1YK0h1K1Vh?=
 =?iso-2022-jp?B?Zjl2b2w2dmJJTEQ2di96eHFtTGtoMm9qSHJIUmI0TGFRcnZDczA5N255?=
 =?iso-2022-jp?B?ZGFsN2kyQ0I5M0d3MGVTeURqRlZCaUFDZkpCU1BvTHRqQlg3ZmF4TnNx?=
 =?iso-2022-jp?B?T0duM01BRE9iODRjb1ozQ2l3b2VNdVR6TmxKb0pDMU0vd2RUbWZ3VTVS?=
 =?iso-2022-jp?B?QWE5anByamo2QWUyUGpIdHZJWVd1dHZRRUpMT0tBOVQ5UncydkF3ZnVt?=
 =?iso-2022-jp?B?SVlaRThkRTNRNXBBK0s1TEt4SE92MGsxdlgwc2hZclo0VysxaWI4OXRi?=
 =?iso-2022-jp?B?RExYOFNwUTVGSlBsQW9XSUx4SmFQc2JqWDZmUXpBV1B4OU1Ub2lwV0pS?=
 =?iso-2022-jp?B?QjBEU0dKSXJpNk1JM2ZmeXFPTkFPT0Nkb3pNSUNPb2NKU1ZuVlRTN2N2?=
 =?iso-2022-jp?B?ZW5FTFhFT2tBWkZ3NTBzaXhGbk04ejJIUDNPWE9EZlh1SW92LzJFT1U3?=
 =?iso-2022-jp?B?TmFjY0xaVTZ6ZW54UThWWWRrWTNaZ21IV3FmZDU3K00rWThNVXVYZU9D?=
 =?iso-2022-jp?B?VVg0dkNPcUNmQnVTTEZqUHhkVWRQaWdSeFRQSFg4L3R2U0RFekJFbTBt?=
 =?iso-2022-jp?B?d3pHY0did0EwUFRuSzRobTdZSE9rbDVEbEV0eFc1T2haYXlzMHcwTDBp?=
 =?iso-2022-jp?B?QVhqM2YremV2YzlTWkNvWmpjYXdZdDVQZGIySHh4TGMwcTBpcFFoYnNz?=
 =?iso-2022-jp?B?V0s3V2p1S0xYaFJkcEc4SFEyam82QUJxRkE9PQ==?=
Content-Type: text/plain; charset="iso-2022-jp"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0:
	vf9Xq8kcuXGPixWDRLTN74wIcCu5ODD3nIuUAKkY/ZKrUt07HJw/JJXyYtgnL+q/0K03QXzU5hnZHN4dDxnXRYzURXbE6upTvOkHPi9y9LckGZ/gbmZCk1bU2nuBbaVxqBx+uZGAEXtrXqeQbdRjz5G4wtMOxuQrL61Lc80RmDbf0NdklBKEbYNMrmVo88oYahG2JWurB2mQk7FMLKVVL9OpW+QX5TAOEZaMDr/fVF8ssTVUXsZ8oWa3PfqerQqYEb0aFUwsRcw/F1f9Wr5MVbBQxx0PZmbWpm4MBqIr2HOWtzGIUc1FSemy93T/QVMz5eYTJ0kVWNDhmQli3keeOBWzI4pT8EJsElo6CX2/5BFb7jEuCgIeZcvW5d/62JfrSpTNiuAr736bNxRLhrQBhqCvqxJ5hvAYHBtwUwOO6TLYzbrcKvym0Y4xKQEXNmp6fj6mPF2wUYjGwYkm9wIAJ+wEbZiWiVmvSXrw+/MGOjfEGhatd6oIZlSJCnbjoFfETJVi+XThnjgyVMkFvQK4Sc9YdhKt3VTxashYpSRevlFNQNrTcix1H98WbjpKae7RECDA+e8un04JVZKyMHqEkrf0ZnXasd9QhHVOgnYmMnreykAB7qCPbWEj3ZuhaRIXP2zOIdzpMljovKN2aqA/BK0RJEDvVMDShyNxczbIf4eaaXbeUKoRj+7HfflRjg0Gi97ogci//hHBVHTz06kujEBbminHqvWjuI5PtrOcgVHUlpHVLWoGV4kAcKb7FDLKazi6HV86dsxEFePMwM2EO5MMrm+e7TUmI77Wbp3VIYeQAlOCva1r+LuQXAVnAiPTJQQnhY9t32M2sikOhHLV+w27bGG6YQ/fF3vQZeszhidSIRlYE7frUgTYru6jjJSU0xOj8K1lJ7/jiHscUf1HWw==
X-OriginatorOrg: fujitsu.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: TYCPR01MB8373.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 944332a4-8e3f-460e-c8df-08daf9f56cda
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jan 2023 08:16:11.4771
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: a19f121d-81e1-4858-a9d8-736e267fd4c7
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: /hIMVj4NhyIRLdp7rG25r7NUgAOZ+UjXGfyU6EykbDmscPF1GERNmdPptuEn4+BdmJtAerax3Cf86cle5a7qCprq8/y8YVER6vONtwI1oHo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY3PR01MB9683
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/TYCPR01MB837334F4E55DA5ACCA5E128AEDC49%40TYCPR01MB8373.jpnprd01.prod.outlook.com>
Precedence: bulk

On Thursday, January 19, 2023 10:42 AM Peter Smith <smithpb2250@gmail.com> =
wrote:
> On Wed, Jan 18, 2023 at 6:06 PM Peter Smith <smithpb2250@gmail.com>
> wrote:
> >
> >  Here are my review comments for the latest patch v16-0001. (excluding
> > the test code)
> >
> ...
> >
> > 8. AlterSubscription (general)
> >
> > I observed during testing there are 3 different errors=1B$B!D=1B(B.
> >
> > At subscription CREATE time you can get this error:
> > ERROR:  min_apply_delay > 0 and streaming =3D parallel are mutually
> > exclusive options
> >
> > If you try to ALTER the min_apply_delay when already streaming =3D
> > parallel you can get this error:
> > ERROR:  cannot enable min_apply_delay for subscription in streaming =3D
> > parallel mode
> >
> > If you try to ALTER the streaming to be parallel if there is already a
> > min_apply_delay > 0 then you can get this error:
> > ERROR:  cannot enable streaming =3D parallel mode for subscription with
> > min_apply_delay
> >
> > ~
> >
> > IMO there is no need to have 3 different error message texts.  I think
> > all these cases are explained by just the first text (ERROR:
> > min_apply_delay > 0 and streaming =3D parallel are mutually exclusive
> > options)
> >
> >
>=20
> After checking the regression test output I can see the merit of your sep=
arate
> error messages like this, even if they are maybe not strictly necessary. =
So feel
> free to ignore my previous review comment.
Thank you for your notification.

I wrote another reason why we wrote those messages in [1].
So, please have a look at it.

[1] - https://www.postgresql.org/message-id/TYCPR01MB8373447440202B248BB638=
05EDC49%40TYCPR01MB8373.jpnprd01.prod.outlook.com


Best Regards,
	Takamichi Osumi