public inbox for [email protected]
help / color / mirror / Atom feedFrom: Hayato Kuroda (Fujitsu) <[email protected]>
To: 'Maxim Orlov' <[email protected]>
To: Heikki Linnakangas <[email protected]>
Cc: Alexander Lakhin <[email protected]>
Cc: Ashutosh Bapat <[email protected]>
Cc: Alvaro Herrera <[email protected]>
Cc: Alexander Korotkov <[email protected]>
Cc: wenhui qiu <[email protected]>
Cc: Postgres hackers <[email protected]>
Subject: RE: POC: make mxidoff 64 bits
Date: Tue, 17 Mar 2026 02:56:13 +0000
Message-ID: <TYRPR01MB121563A4DA8B2FE9A2ECB79F5F541A@TYRPR01MB12156.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <CACG=ezahxLVviavvs_+V7GW9EnOMhe+h0Szx501gS=x+DzjN_w@mail.gmail.com>
References: <CACG=ezaWg7_nt-8ey4aKv2w9LcuLthHknwCawmBgEeTnJrJTcw@mail.gmail.com>
<CACG=ezYbYO_KHWdeDedbDcY0tOS0JfaqBxG3=bG5+DdsDK4MpQ@mail.gmail.com>
<CACG=ezYpZRPwoRCz_h3Qerd3XJNdpTHCpwGbZphNdy26tA4_qQ@mail.gmail.com>
<[email protected]>
<[email protected]>
<CACG=ezYUJSvnuxntkURNWo_1vZ+AtmcQfqd_h6WgDzGaudfw+Q@mail.gmail.com>
<[email protected]>
<[email protected]>
<CAExHW5tUEkiQrvm9hgccjKUNkWBnJ5_HDUrAwiHBTxu+Vuj29Q@mail.gmail.com>
<[email protected]>
<CAExHW5t3kzJiVqmoqCLyGmfkTjD4Rwa27kXH-S_XvHWLkM2fzw@mail.gmail.com>
<CAExHW5ucnoyjd6p7UVVhQTeV7hc8-vX81ti8f7sU0COqfUWzQg@mail.gmail.com>
<[email protected]>
<CAExHW5s_uNeD_xYjdbSR8khMXwWJQOY9Qg=j4T+5KOfGz5-RsQ@mail.gmail.com>
<[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<CACG=ezbwy1zargXDNPeYXxZwRW3jXu_aD=rcG-7dc4fw7Y9Ojw@mail.gmail.com>
<CACG=ezbccQucKvp9a-3zKmoCFjsXo1RNkYVJ9i7ZBhJH+4hJDg@mail.gmail.com>
<CACG=ezYGvQbtuj_V9dGjBZEveTBW5dSMpcQ5mUWvxgYPw5cgdw@mail.gmail.com>
<CACG=ezYjGmkVO+J7T8uv37XxUaqkptvrkOuMf04E7MTpWPcY=A@mail.gmail.com>
<CACG=ezahxLVviavvs_+V7GW9EnOMhe+h0Szx501gS=x+DzjN_w@mail.gmail.com>
Hi hackers,
Thanks for working on the project.
While running 007_multixact_conversion.pl with the meson build system, I found
that delete_old_cluster.sh can be generated in the source tree.
IIUC, we must expressly change the current directory under the tmp_check.
Please see attached to fix the issue.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
Attachments:
[application/octet-stream] 0001-Fix-the-test-007_multixact_conversion.pl.patch (1.3K, 2-0001-Fix-the-test-007_multixact_conversion.pl.patch)
download | inline diff:
From 43ddbf8a933b8f9849a63f53733b3386db905ef3 Mon Sep 17 00:00:00 2001
From: Hayato Kuroda <[email protected]>
Date: Tue, 17 Mar 2026 11:52:59 +0900
Subject: [PATCH] Fix the test 007_multixact_conversion.pl
pg_upgrade test 007_multixact_conversion.pl was leaving files like
delete_old_cluster.sh in the source directory for VPATH and meson builds.
The fix is to change the directory to tmp_check before running the test as
is done in the similar test in 002_pg_upgrade.
---
src/bin/pg_upgrade/t/007_multixact_conversion.pl | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/src/bin/pg_upgrade/t/007_multixact_conversion.pl b/src/bin/pg_upgrade/t/007_multixact_conversion.pl
index d18c50830d5..867a0623153 100644
--- a/src/bin/pg_upgrade/t/007_multixact_conversion.pl
+++ b/src/bin/pg_upgrade/t/007_multixact_conversion.pl
@@ -357,6 +357,11 @@ sub upgrade_and_compare
'multixact members from original and upgraded clusters match');
}
+# In a VPATH build, we'll be started in the source directory, but we want
+# to run pg_upgrade in the build directory so that any files generated finish
+# in it, like delete_old_cluster.{sh,bat}.
+chdir ${PostgreSQL::Test::Utils::tmp_check};
+
my $old_version;
# Basic scenario: Create a cluster using old installation, run
--
2.47.3
view thread (79+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: RE: POC: make mxidoff 64 bits
In-Reply-To: <TYRPR01MB121563A4DA8B2FE9A2ECB79F5F541A@TYRPR01MB12156.jpnprd01.prod.outlook.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox