From: li carol <carol.li2025@outlook.com>
To: Michael Paquier <michael@paquier.xyz>, Kirill Reshke
	<reshkekirill@gmail.com>
CC: Roman Khapov <rkhapov@yandex-team.ru>, pgsql-hackers
	<pgsql-hackers@postgresql.org>
Subject: RE: Use correct macro for accessing offset numbers.
Thread-Topic: Use correct macro for accessing offset numbers.
Thread-Index: AQHcguyIPCF2UF12NEil8Kcqx/CaebVM2I6AgAAE2ICAAL9KAIAAZ1YA
Date: Mon, 12 Jan 2026 05:36:15 +0000
Message-ID:
 <TYSPR01MB6650128F7CCEBE1C809AE51E8181A@TYSPR01MB6650.apcprd01.prod.exchangelabs.com>
References:
 <CALdSSPidtC7j3MwhkqRj0K2hyp36ztnnjSt6qzGxQtiePR1dzw@mail.gmail.com>
 <F722FCB5-7790-4043-8F64-8D9676943726@yandex-team.ru>
 <CALdSSPgzLF8Vx7S0HpJo4rR3tc6Wqnr68JZ9LMOoVGPZSM0dTA@mail.gmail.com>
 <aWQw5ok9a3x5Pwhx@paquier.xyz>
In-Reply-To: <aWQw5ok9a3x5Pwhx@paquier.xyz>
Accept-Language: zh-CN, en-US
Content-Language: zh-CN
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?Z+sdD3SwTY4BaUpIJiyeCY0+ECztjEbGjBN3C250Bbv8ju0DZ4JBu+1G/HvD?=
 =?us-ascii?Q?U4jynnFdtKKdmhyzatw605pqVNqoy7HyH2j7HQbLjG55RzNAAVCJw/92Kelq?=
 =?us-ascii?Q?C8TNui4tIjJse9uoaFgzCIAeGinXfAtcPz52/ZQT4HKzEHCH0AWc3buNW1Fp?=
 =?us-ascii?Q?YBQMjBhiJBQ+rMW4ZdsV/Hv1z48BfPLuzpoulheIBuGuFLION+3j4542f8YK?=
 =?us-ascii?Q?BqRgzOZx9h+FyFjwNIYAPlbUlUZiUaf1Kv1SQHtjuFPkGlrL8uTCpgTvBgm5?=
 =?us-ascii?Q?+kr7LdPBjWYIbo/+G/oKWRTpUGnlIW/29HFtHJw1CmnldSEizZ+He/vDc7SL?=
 =?us-ascii?Q?5JLGovCCzY40XbqvanKNp32+fQ/XBAWX/UTLaUrKQ+6foeZhZiAeoxz70LLw?=
 =?us-ascii?Q?xqDyJvy6Lk4P3GSlzg0XvseDg1OfZewyj5aAMnDNoCStHmzhHsoKsn6PvAKE?=
 =?us-ascii?Q?UVGMPbtlXNEbfOB5EQYabJPIlFt8DIsbLI+IMtqddIwTXTPSUq+LakFSPQRo?=
 =?us-ascii?Q?HwScyBm4Rl1KgseBSG0XamFxYy4edtH2rdloTfS3wTV41xjD4FF2Wy7nl1W0?=
 =?us-ascii?Q?rhm1yycRBaI65ViCEW3ZUztsKrRfoIeRWraFqIcktAjoeItog0mnDidQ604R?=
 =?us-ascii?Q?0N5ldZLrm5cSjTgZ3ni8K+5frA4vqSqlkBj3pBxb1Aci5uMg/sI4IdT1rTPU?=
 =?us-ascii?Q?JQE+KvZzq/A1yGxpPc1ulmYCcftb8Qj8htm/fUMa+5lWJBA4luAk6SbjCJYz?=
 =?us-ascii?Q?w0GmlL4RBSmidAIaGVn/aSxZiNE42ZYuB3tgC0bTl0fnwsxjI4p8H+lc56pd?=
 =?us-ascii?Q?YkPiyl5/qLk2Hvg4WKp6ewXs5xurFyFNlr2fNQeGI/3TUM5x+fZCAwBFh5fT?=
 =?us-ascii?Q?OqXdUVnwFIbQa4dsVE2Zyd2AxSUV4Y3YDtea1QkdQhOfWZd71uxZhyvUuU7f?=
 =?us-ascii?Q?LqtG4o24bFC//qRRQbf/KqoKwSdFcJUTmG3BgpKhUfsP/pvrmYJBzjpdbRvF?=
 =?us-ascii?Q?Rb/ugxnPuGKQytrc10CqrUknCF635VnCEz5NruZf2qddy64fkLBYDyqYswIg?=
 =?us-ascii?Q?YW/Hm77afdG8CdXfUwQTeD/Bj/WzKU7+ASQlF9/VVKNEl+BCbim8uOZQ4vuG?=
 =?us-ascii?Q?nYGvglf1GwoKY2EGRqBjgkTL1ea42Oy2FAeagSz48KP9fiVWKJfnmLRhR75H?=
 =?us-ascii?Q?9JOxfY7apRD3i2G7BHDcQEank2q6wbU5olqsEEvJScXUqKgh8NUA0spK2ThJ?=
 =?us-ascii?Q?CoOXg5UxZc3KCWa33/prvr+uPO6WQ1lv6Cizgu4sGCjJ/rhKuHZLS+hECmsE?=
 =?us-ascii?Q?vJDs4/Ej61r5LAI02Fk0QCGPAWneRY+AVb/2IANU7/1+1ab9/n8aNIBLXMyc?=
 =?us-ascii?Q?1AnNsVUt0eGrt/R2p/S1MQe6CKPf?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: TYSPR01MB6650.apcprd01.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-Network-Message-Id: 26c1e279-997f-478a-d3b8-08de519c810a
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jan 2026 05:36:15.4711
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEL0PF16BCC7263
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/TYSPR01MB6650128F7CCEBE1C809AE51E8181A%40TYSPR01MB6650.apcprd01.prod.exchangelabs.com>
Precedence: bulk

>=20
> On Sun, Jan 11, 2026 at 04:58:39PM +0500, Kirill Reshke wrote:
> > Maybe, I have stopped some more cases, in v2-0001
>=20
> Right.  It's true that we could be more consistent for all these based on=
 their
> base type, some of them, particularly in the GIN code now, caring about u=
sing
> the correct macro.  It may be a good occasion to double-check the whole t=
ree
> for similar holes based on unsigned types.
> --
> Michael

Hi Kirill, Roman, and Michael,
While double-checking the tree for similar holes as Michael suggested, I no=
ticed a couple more inconsistencies in contrib/pageinspect/ginfuncs.c where=
 we are using signed macros for unsigned types.
Specifically, in gin_page_opaque_info, we use Int32GetDatum for maxoff:

values[1] =3D Int32GetDatum(opaq->maxoff);

Since maxoff is of type OffsetNumber (uint16), this seems to be the exact s=
ame pattern Kirill is addressing in other parts of the GIN code. Although i=
t is widened to int32 here, for the sake of consistency, it should probably=
 be using a 16-bit or unsigned macro.

Similarly, in gin_metapage_info, tailFreeSize (which is defined as uint32 i=
n GinMetaPageData) is also converted using Int32GetDatum:

values[2] =3D Int32GetDatum(metadata->tailFreeSize);

It might be better to include these cleanups in the next version of the pat=
ch to ensure all pageinspect GIN functions follow the same standard.

Best regards,
Yuan Li(carol)