From: <Masahiro.Ikeda@nttdata.com>
To: <lena.ribackina@yandex.ru>, <donghanglin@gmail.com>
CC: <geidav.pg@gmail.com>, <melanieplageman@gmail.com>,
        <tomas.vondra@enterprisedb.com>, <dilipbalaut@gmail.com>,
        <pgsql-hackers@lists.postgresql.org>, <hlinnaka@iki.fi>,
        <Masao.Fujii@nttdata.com>
Subject: RE: Parallel Bitmap Heap Scan reports per-worker stats in EXPLAIN
 ANALYZE
Thread-Topic: Parallel Bitmap Heap Scan reports per-worker stats in EXPLAIN
 ANALYZE
Thread-Index: AQHax60NXR0IDxex+UWSGrub4oLPeLHZ1lZA
Date: Wed, 26 Jun 2024 10:27:09 +0000
Message-ID: 
 <TYWPR01MB1098297D13C4841311F5344AFB1D62@TYWPR01MB10982.jpnprd01.prod.outlook.com>
References: <b3d80961-c2e5-38cc-6a32-61886cdf766d@gmail.com>
 <CAFiTN-v1yDvU=X+hwfJ+55=sbgDj=_kuvbduEG-F7=BjpWcnuw@mail.gmail.com>
 <efcb213c-c87c-41f0-85b7-7fa8079df807@enterprisedb.com>
 <CAA=D8a1ZGWTk0RDH-LyU==RsE-217T29eprS-NBhyj+eLHyRrQ@mail.gmail.com>
 <CAAKRu_YjBPfGp85ehY1t9NN=R9pB9k=6rztaeVkAm-OeTqUK4g@mail.gmail.com>
 <CAA=D8a1G5CgvdWLd5_VCEc5Sa3rgJftcGfTEvYqG1HnjMBQmpA@mail.gmail.com>
 <13bd913f-94b6-43cf-b849-4d762e5297d8@yandex.ru>
In-Reply-To: <13bd913f-94b6-43cf-b849-4d762e5297d8@yandex.ru>
Accept-Language: ja-JP, en-US
Content-Language: ja-JP
msip_labels: 
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: TYWPR01MB10982:EE_|OS3PR01MB9818:EE_
x-ms-office365-filtering-correlation-id: 220008db-288f-4b72-268c-08dc95ca8903
x-exo-sectionmanagercc: 1
x-exo-externalsending: 1
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;ARA:13230038|366014|376012|1800799022|38070700016;
x-microsoft-antispam-message-info: 
 =?iso-2022-jp?B?czFxNzlUbGN3cS9abjZSZ0ZxTFMxdFhGQjFnemozbm1uT05iTmRkQ3pt?=
 =?iso-2022-jp?B?QVpDS01EK3F4YyttUUJkMU9qT0dUWkJXWFdSWWkweFVybnNzaHF6VHhO?=
 =?iso-2022-jp?B?MTZVRTZRdTNBTURtUmF4S3dCWGdWWmg4eEVVc1dDRnc4N0lDR1d1Rys0?=
 =?iso-2022-jp?B?Wjl0SE9yRnlCUnhadGJZbXQrZGFGcFROcFdicm5IWmd1SkVsNnRQOHhy?=
 =?iso-2022-jp?B?Slo3VUdMTENadUZzZUJRamdsU2JPNEtkVy9LSEpCV3FHblFyeHZrY0Jq?=
 =?iso-2022-jp?B?Y2hIQi8yOTJXSklLTi9QaU0rcS9KbFRFaGNYVXRrMlR6SnVHRUV0czZz?=
 =?iso-2022-jp?B?Rm9ObnJqd3VQSjNmcW5uTDFDbGVqVUJyVE1FSUp0ZTE5VHdBNmpmS3Vp?=
 =?iso-2022-jp?B?SlA5NGoyUlZPaXhaZ3BsODhOR1JubW15TW9RWno5WXc3cWhwdHVIVkty?=
 =?iso-2022-jp?B?bE5RV0d1QXFSRTc5dk1QUks4eVYyRnZLNUR1K0dFdUNuU3NBU01EL1VJ?=
 =?iso-2022-jp?B?T3M1ckJnbFJQcWtIbmQ1Q3BOOXZvWTNwdEg5cDE3S3krVUVrMDNZazJI?=
 =?iso-2022-jp?B?aUNUUzNtSVB1SGJ6NVNSZ3lpTTFCZ0wzb2pFNnJvMUYvR2xQcEZwdzNR?=
 =?iso-2022-jp?B?RFdZTXdKeSs2T2RLRnEyeWtVZEVnS0V1R3hjZUZpNUxHWU9hT0xId3JW?=
 =?iso-2022-jp?B?MmFZUTZmdVphdzVOTGQ2aW52SFZMZ1BaTWZLRWpySG1xQWZwYTNLVE5j?=
 =?iso-2022-jp?B?WFJOZHJpTUpwczlQTHAyYzJmMmI4UlFFRStCZllZU2szb1hkbXRYbzQ1?=
 =?iso-2022-jp?B?SlBCMThtU2lOckxRbTBUOXViRjNYNDNLMzQ3Q1BlekNLdm5FbTNZbmc0?=
 =?iso-2022-jp?B?dGtCWThMWnlHYWllZVdpRU9DNFpmOWN4QWRoZHoyQ3paWndZN1FsWXc5?=
 =?iso-2022-jp?B?ZEE2ZDBYVnJ1b3dyS0wyQVBpc3ZrRmxkVis3K1JGbFYyL1F3NHFDWDNV?=
 =?iso-2022-jp?B?dzlDMkdmTVUxd2k4ZWN4OWtFV002ZUtYV0Y1Q056cFlLbndXUUlWRGUv?=
 =?iso-2022-jp?B?UlRvY0RVamtlRDVXT1gwL2IzWC8zeHpuem5raFBBWmdhcndseUlmbE1p?=
 =?iso-2022-jp?B?MWVVVytIUWtvdnBNeTdlL2Q1WXJVZFlZOEgrS09QNlVCYldCVThXQUFS?=
 =?iso-2022-jp?B?NndLWmxpM0Q4YzJYeThZZVpJV29VSFNTWVZmTVF3aGVNNW5QMzhFS2xJ?=
 =?iso-2022-jp?B?YmphY2lvMkptMXg0RnJ1TjZvMmV4RGF5aE5pRExzMkd1OWpPTmduUEQ3?=
 =?iso-2022-jp?B?Qk0yRmg3MFlXUUM3Nm9WRHVDRG5RRTJUaU5UamNSRGFCaEdaNDgreHR2?=
 =?iso-2022-jp?B?SkdmUDFEbzdVYlJqNXdrbWNWSnZNZlpKTWUxamthak5hS3dRWkJKNytD?=
 =?iso-2022-jp?B?Y3hubEh6alNMS2dDM1hZeU9qSDFDSXh1Z3M0QkpNSk5jSStDVDIrbXN4?=
 =?iso-2022-jp?B?bE5lMXZjTmdrbklkWTg1M3VYKzU2dzZ5SDk4QzVweFlaTk1GVFV2MHJq?=
 =?iso-2022-jp?B?NnpaeDUyN0NlNGk2UjBidzRONU5MS0kzWUhGL1RTaTA3YjdlZ2NMZDNz?=
 =?iso-2022-jp?B?TTduTDhDU2k2T1o0TjcyTm1lV0hDdkxXeG5sS051bHE0NzdlUzRPR2Jo?=
 =?iso-2022-jp?B?cFFYNmM2WkFyaWtxVFpKU0QxdzQwTGdLeURWOVQvSWtzRUllT3g5c0kz?=
 =?iso-2022-jp?B?eG9DZVhOUjRqWVNKaFlXcGhvNVpDcCtHOGE3Q2M1NjFvWnEycVBtSU5B?=
 =?iso-2022-jp?B?VUJlOEdKL1FvNnNBbXgzOTJFZkl2TlIySi9aaDhSdmlGUmV1WVhJNUIv?=
 =?iso-2022-jp?B?Mm9jMWFUblk4NXdscUNaczVxeFhCY2tjNStINFZmWmt3cU5iNzhaZzhL?=
 =?iso-2022-jp?B?djBCem1QK0IwSHRuZHhuSy8yK0FVOE51a2hXWk9SRnlRZjZFd3V3QzE1?=
 =?iso-2022-jp?B?bHlYV3Y3RzNxM0VKL1dmc0dvVjkweTdZdGFTbXBuTGtvaHI2aDY4eVo3?=
 =?iso-2022-jp?B?MkE9PQ==?=
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:ja;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TYWPR01MB10982.jpnprd01.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230038)(366014)(376012)(1800799022)(38070700016);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?iso-2022-jp?B?QjE0VU5GMW9MbEJRNGNtZkVPSWlXaGZ3YlQwVERXaHZGYkltQlNuMEdY?=
 =?iso-2022-jp?B?cENONFczdTU4ME5aSkcwMDV5SG9JaXdQYkNEYy9QT0lBVzFOclgrb3U4?=
 =?iso-2022-jp?B?WHZqdCtrS1BvUGdZT0lzd2FPeDN6UVZ3MUpPZGFJb3J2L0VXY1FucnFE?=
 =?iso-2022-jp?B?dndEdlVSTEdDcm1VUWoxR3BCU0ZnckdPME44eGZJdDhNVEdxRUFoMzgr?=
 =?iso-2022-jp?B?UlN3dXJ0YVZ1OGJLNFJMUFB6UVk3dHdFaUdaTHhML0UwTEdQSG9PeVAy?=
 =?iso-2022-jp?B?ZGJuTDd2SnQ4OFlTWjZPamFhT0lJSjZkTEtkeGNEU2pJbXVpMW8rWmZL?=
 =?iso-2022-jp?B?WCtIby9FSk9PZDJPNk42b3l5NFR0WVFnZ05mN2hsN2hxNVM0aGs3MnhF?=
 =?iso-2022-jp?B?NzltOHN1aG9jSTJkMVNoMkxzWlY0a2dGb3M5RnMxeHVBYmM5OE44NHFX?=
 =?iso-2022-jp?B?OW0rK1hlOWY5V2RJeXhHYlN0K3p4S01aNWVXa3gzcUdkUlJuZ1hMUXg5?=
 =?iso-2022-jp?B?aEVqQjhTOHpBcjB4bllBakt3UldiQmZNRURqc29kdEtzMlh6cFkxTE9P?=
 =?iso-2022-jp?B?b1Byd3RUcUdXSDNEUFYxM0hRSk5rSHVFeXNyelVqWWZCcUxLMlZhb0Ix?=
 =?iso-2022-jp?B?SE5Da0p1MGhOdWNoTlluV3NmZGdwZFdyY1FINVdpR2JGQUs2T016clVt?=
 =?iso-2022-jp?B?dU5Sb2NiVGFObUlIVkRCWEc4MmgvVEV6YmhPYmY5amhLVnhINDlpNHpR?=
 =?iso-2022-jp?B?azlLTjJHTmJlNUJ1NFRCVDgxUC9UK0xkMkdIaVI3ZjlLS0RlQmZoNDF1?=
 =?iso-2022-jp?B?cHZHNTR5eHI2UXRFbVRPSlFBN0JXc2Z3TEt5N0Nqblg5NE00c1NEd2NC?=
 =?iso-2022-jp?B?REpPZkVhaUYrRE83dzRSUDVqL0hVN1o1Q1Z0YVh2MEl0S3cxai9PRnR5?=
 =?iso-2022-jp?B?bFNWQVhYeTZIcWNxSXM1NHk1MCtTNVZTeEwreEtyY0lyWm93MURad2V5?=
 =?iso-2022-jp?B?b3NEdUZGOFVjcXNsNCszQzBpL1pFRnN1cE1wWVdUbmJReC80VXltWXpm?=
 =?iso-2022-jp?B?MDRlOEtHd001NUxuVWs1L1I2VkovTy80SEtabEl1SnBYQ1BJaVJ4Sjhr?=
 =?iso-2022-jp?B?YWNpb0VQd29JV3l0SWtqamNUb21OcWNvbjJYSU45UVR3cUh6UlpWMXlI?=
 =?iso-2022-jp?B?NVhRNkx6L0RlQzA5NXZLQkhzQmVZMGNiZ2lDemFsaThUbTZGcXBBTVZX?=
 =?iso-2022-jp?B?TkRoM0N4Q0F5b0xKcTVGYXpHNVVKbjljNmUyMm05NWNSV29VeWlzdHFy?=
 =?iso-2022-jp?B?UTlZUEdRLzR1SU1BS3JDL0FmZ3ZBMXM1SExpNVpXZlJ5WEhMdGpBWHlt?=
 =?iso-2022-jp?B?dlRtYVpGVmdlQkMyR1Q2eVhMS3lBSGlFTnB4OE9tVng4bXJUYVNHTUNk?=
 =?iso-2022-jp?B?QlFJTUR6Vmw2UWRuWDdrL2ljaW1UanVjdGhlQ1JHTHBpQS9pOUxMVmFR?=
 =?iso-2022-jp?B?d1podk5ZR0NsTzVKMEFoLzk0cVVoMnBwMk8xa0tQRTNUTXdIcVp3bWUy?=
 =?iso-2022-jp?B?bmpUZDk5cklacnJWeG9PZXZUV24zVEswVEpCbThqVTA4cjFXa1R4cEFy?=
 =?iso-2022-jp?B?dVFtdzl2Y1JKUWJMMStoT0lzYXk0UDFmY0Q5TTBBdWM1ck00VzJIYXYv?=
 =?iso-2022-jp?B?MXJxVFlpRGRnSjFXSm0wLzFaUDg3dlVjZHFqeUVxYnMyajNLQXp5dWpI?=
 =?iso-2022-jp?B?MXh2YTBObzc1Y1NjaXg1OTRzYzhNNzhhUmlqWmNRVGZGTjZVN3h3T3FM?=
 =?iso-2022-jp?B?TmhLZVlyUndNc3FraUNsMENBTDF6aE9YZTB0NGtkSEFtVWpKRUFSMHoz?=
 =?iso-2022-jp?B?WGRhdUV4SVlVdUhLZnZQc1hLUElzcnBtMWd5TFphMXZCdXpwTVJrNlRO?=
 =?iso-2022-jp?B?d2w3SGNDcllUSmZjNVRzYmRqN2hLR1Voc0xhNmxtNWgxNEJzUVlkUEJt?=
 =?iso-2022-jp?B?aUFCTUVsTGhZNnNkNU1sV0djc3dZMWlLLzAwdHNnMUxtRGxYdis2c0Z5?=
 =?iso-2022-jp?B?cWZISzFHNVRUcTV5Uy91R1R6WE5halJpYkVvSXRNNWlUaWZreU0yT0Zt?=
 =?iso-2022-jp?B?WTlIK1FsMC82YS9TNGE2aFdqaHpkc01NM3IvcVZOTnhaMkk2aWFqaXNB?=
 =?iso-2022-jp?B?NmRXWDVsdU5oMzZnOWxKOTcyZVpSb0UxVmFqZmhWWE9TQTZOOHJiN2Zv?=
 =?iso-2022-jp?B?NFY3OTRvV28reUZMbi9tUTArVDlRWnlKOTNLTitJTU9HdVdxTEtEK0I0?=
 =?iso-2022-jp?B?amViUkhib0pNeDdqTmxzRUJyWGx1Nzk0SEE9PQ==?=
Content-Type: text/plain; charset="iso-2022-jp"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: jp.nttdata.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: TYWPR01MB10982.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 220008db-288f-4b72-268c-08dc95ca8903
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jun 2024 10:27:09.4079
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 1fcf450d-bb71-4efd-ae5d-90c7be757e12
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: szzhT1M7ulxsgZ0vZ/3r2FaMgFg7LZnAC3j+UjfqeCX/DX22dK28C40SstZvH/2de96dt+AauSdLNYJ/jnz/L1TsiJXUKTuxZkDzO2/bwYY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS3PR01MB9818
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16
 definitions=2024-06-26_05,2024-06-25_01,2024-05-17_01
X-Proofpoint-Spam-spam_all_notspam: 1
X-Proofpoint-ORIG-GUID: aEAx9ymYYOAx3vQmtkx3-rYfF-jiMGKy
X-Proofpoint-GUID: aEAx9ymYYOAx3vQmtkx3-rYfF-jiMGKy
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16
 definitions=2024-06-26_05,2024-06-25_01,2024-05-17_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 priorityscore=1501
 impostorscore=0 malwarescore=0 suspectscore=0 phishscore=0 clxscore=1015
 lowpriorityscore=0 mlxscore=0 adultscore=0 spamscore=0 mlxlogscore=910
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2406140001
 definitions=main-2406260078
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/TYWPR01MB1098297D13C4841311F5344AFB1D62%40TYWPR01MB10982.jpnprd01.prod.outlook.com>
Precedence: bulk

Hi,=0A=
=0A=
Thanks for working it! I'm interested in this feature, so I'd like to parti=
cipate=0A=
in the patch review. Though I've just started looking at the patch, I have =
two=0A=
comments about the v6 patch. (And I want to confirm the thread active.)=0A=
=0A=
=0A=
1) Unify the print format of leader and worker=0A=
=0A=
In show_tidbitmap_info(), the number of exact/loosy blocks of the leader an=
d=0A=
workers are printed. I think the printed format should be same. Currently, =
the=0A=
leader does not print the blocks of exact/lossy with a value of 0, but the =
workers=0A=
could even if it is 0.=0A=
=0A=
IMHO, it's better to print both exact/lossy blocks if at least one of the n=
umbers of=0A=
exact/lossy blocks is greater than 0. After all, the print logic is redunda=
nt for leader=0A=
and workers, but I thought it would be better to make it a common function.=
=0A=
=0A=
=0A=
2) Move es->workers_state check=0A=
=0A=
In show_tidbitmap_info(), ExplainOpenWorker() and ExplainCloseWorker() are =
called=0A=
after checking es->worker_state is not NULL. However, es->workers_state see=
m to be=0A=
able to be NULL only for the Gather node (I see ExplainPrintPlan()). Also, =
reading the=0A=
comments, there is a description that each worker information needs to be h=
idden when=0A=
printing the plan.=0A=
=0A=
Even if es->workers_state becomes NULL in BitmapHeapScan node in the future=
, I think=0A=
that workers' information(Heap Blocks) should not be printed. Therefore, I =
think=0A=
es->workers_state check should be move to the place of "if (planstate->psta=
te !=3D NULL)"=0A=
like ExplainNode(), doesn't it?=0A=
=0A=
IIUC, we need to correct show_sort_info() and so on too=1B$B!D=1B(B=0A=
=0A=
Regards,=0A=
--=0A=
Masahiro Ikeda=0A=
NTT DATA CORPORATION=0A=