public inbox for [email protected]
help / color / mirror / Atom feedFrom: [email protected] <[email protected]>
To: 'Amit Kapila' <[email protected]>
Cc: Masahiko Sawada <[email protected]>
Cc: vignesh C <[email protected]>
Cc: Greg Nancarrow <[email protected]>
Cc: [email protected] <[email protected]>
Cc: [email protected] <[email protected]>
Subject: RE: Failed transaction statistics to measure the logical replication progress
Date: Wed, 17 Nov 2021 13:42:19 +0000
Message-ID: <TYWPR01MB8362FCFAAD8D90424BEA2300ED9A9@TYWPR01MB8362.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <CAA4eK1JCbhxuO8fEaAaw8e30=5kEDaFRXpV2+opAdMoEOH5LEg@mail.gmail.com>
References: <TYCPR01MB8373DC922E549FF3F031E9DAED8E9@TYCPR01MB8373.jpnprd01.prod.outlook.com>
<CAJcOf-cMU_1VJ1c+9fwEBgimkj+=hHcCjj_SUfbHvKTuN=1tuw@mail.gmail.com>
<TYCPR01MB8373B1614522B90BA96883E0ED929@TYCPR01MB8373.jpnprd01.prod.outlook.com>
<CALDaNm3-QTZnd4rxbrUfKMM4u_vgb23LO+KW3O9LX7X6b8mr8A@mail.gmail.com>
<CALDaNm130T4jr2RvpgY19SCY87UQ75wVbjrhjGj43bHV=9-LpQ@mail.gmail.com>
<TYCPR01MB8373FEB287F733C81C1E4D42ED989@TYCPR01MB8373.jpnprd01.prod.outlook.com>
<TYCPR01MB8373D7AE0B6C62E5CDB03C6CED989@TYCPR01MB8373.jpnprd01.prod.outlook.com>
<TYCPR01MB8373CFDCD60CCDB1C35CFA45ED999@TYCPR01MB8373.jpnprd01.prod.outlook.com>
<CAD21AoBAREVDtAM+JGR3DcnwnOi1Nw7E_5m68ZwFUGkOkfDn1Q@mail.gmail.com>
<TYCPR01MB8373271BE5D4619302C05B00ED9A9@TYCPR01MB8373.jpnprd01.prod.outlook.com>
<CAA4eK1JCbhxuO8fEaAaw8e30=5kEDaFRXpV2+opAdMoEOH5LEg@mail.gmail.com>
On Wednesday, November 17, 2021 10:00 PM Amit Kapila <[email protected]> wrote:
> On Wed, Nov 17, 2021 at 9:44 AM [email protected]
> <[email protected]> wrote:
> >
> > On Wednesday, November 17, 2021 12:19 PM Masahiko Sawada
> <[email protected]> wrote:
> > > On Tue, Nov 16, 2021 at 9:34 PM [email protected]
> > > <[email protected]> wrote:
> > > >
> > > > On Monday, November 15, 2021 9:14 PM I wrote:
> > > > > I've conducted some update for this.
> > > > > (The rebased part is only C code and checked by pgindent)
> > > > I'll update my patches since a new skip xid patch has been shared
> > > > in [1].
> > > >
> > > > This version includes some minor renames of functions that are
> > > > related to transaction sizes.
> > >
> > > I've looked at v12-0001 patch. Here are some comments:
> > Thank you for paying attention to this thread !
> >
> >
> > > - TupleDescInitEntry(tupdesc, (AttrNumber) 3, "relid",
> > > + TupleDescInitEntry(tupdesc, (AttrNumber) 3, "last_error_relid",
> > > OIDOID, -1, 0);
> > > - TupleDescInitEntry(tupdesc, (AttrNumber) 4, "command",
> > > + TupleDescInitEntry(tupdesc, (AttrNumber) 4,
> > > + "last_error_command",
> > > TEXTOID, -1, 0);
> > > - TupleDescInitEntry(tupdesc, (AttrNumber) 5, "xid",
> > > + TupleDescInitEntry(tupdesc, (AttrNumber) 5, "last_error_xid",
> > > XIDOID, -1, 0);
> > > - TupleDescInitEntry(tupdesc, (AttrNumber) 6, "error_count",
> > > + TupleDescInitEntry(tupdesc, (AttrNumber) 6, "last_error_count",
> > > INT8OID, -1, 0);
> > > - TupleDescInitEntry(tupdesc, (AttrNumber) 7, "error_message",
> > > + TupleDescInitEntry(tupdesc, (AttrNumber) 7,
> > > + "last_error_message",
> > >
> > > If renaming column names clarifies those meanings, the above changes
> > > should be included into my patch that introduces
> > > pg_stat_subscription_workers view?
>
> Right.
>
> > At first, your column names of pg_stat_subscription_workers look
> > totally OK to me by itself and I thought I should take care of those renaming at
> the commit timing of my stats patches.
> >
>
> Can you please tell us why you think the names in your proposed patch are
> better than the existing names proposed in Sawada-San's patch? Is it because
> those fields always contain the information of the last or latest error that
> occurred in the corresponding subscription worker?
This is one reason.
Another big reason comes from the final alignment when we list up all columns of both patches.
The patches in this thread is trying to introduce a column that indicates
cumulative count of error to show all error counts that the worker got in the past.
In this thread, after two or three improvements, this column name has reached to
a simple one 'error_count' (aligned with 'commit_count' and 'abort_count').
Then we need to differentiate what this thread's patch is trying to introduce and
what skip xid patch is introducing.
> If so, I am not very sure if that is a good reason to increase the length of most of
> the column names but if you and others feel that is helpful then it is better to do
> it as part of Sawada-San's patch.
Yes. On this point, it was a mistake that I handled that changes.
It'd be better that Sawada-san takes care of them once the names have been fixed.
Best Regards,
Takamichi Osumi
view thread (113+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: RE: Failed transaction statistics to measure the logical replication progress
In-Reply-To: <TYWPR01MB8362FCFAAD8D90424BEA2300ED9A9@TYWPR01MB8362.jpnprd01.prod.outlook.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox