Date: Wed, 22 Aug 2018 18:39:18 +0200 (CEST)
From: Andreas Joseph Krogh <andreas@visena.com>
To: Andres Freund <andres@anarazel.de>
Cc: Robert Haas <robertmhaas@gmail.com>,
	Alvaro Herrera <alvherre@2ndquadrant.com>,
	"Jonathan S. Katz" <jkatz@postgresql.org>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Message-ID: <VisenaEmail.27.cb06f4d2cef742ad.165627feef4@tc7-visena>
In-Reply-To: <20180822161241.je6nghzjsktbb57b@alap3.anarazel.de>
Subject: Sv: Re: Query is over 2x slower with jit=on
MIME-Version: 1.0
Content-Type: multipart/mixed;
	boundary="----=_Part_165_1349528865.1534955958375"
Precedence: bulk

------=_Part_165_1349528865.1534955958375
Content-Type: multipart/related;
	boundary="----=_Part_166_1251246492.1534955958376"

------=_Part_166_1251246492.1534955958376
Content-Type: multipart/alternative;
	boundary="----=_Part_167_1515651127.1534955958388"

------=_Part_167_1515651127.1534955958388
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

P=C3=A5 onsdag 22. august 2018 kl. 18:12:41, skrev Andres Freund <andres@an=
arazel.de=20
<mailto:andres@anarazel.de>>:
Hi,

 On 2018-04-18 18:37:30 -0400, Robert Haas wrote:
 > On Wed, Apr 18, 2018 at 3:29 PM, Andres Freund <andres@anarazel.de> wrot=
e:
 > > Not convinced that that is true - the issue is more likely that JIT wo=
rk=20
in workers is counted as execute time... Gotta add that somehow, not sure w=
hat=20
the best way would be.
 >
 > Oh, that does seem like something that should be fixed.=C2=A0 If that's
 > what is happening here, it's bound to confuse a lot of people.
 > Probably you need to add some code to
 > ExecParallelRetrieveInstrumentation.

 I had lost track of this, and we unfortunately hadn't added an open item
 back then.=C2=A0 I think we should add it now?

 RMT (with me recused), do you think we should accept the new code fixing
 this would entail? And thus that this should be an open item? It's
 arguably a new feature, although I don't find that a terribly convincing
 position.

 Greetings,

 Andres Freund
=C2=A0
Just to be clear; The query=C2=A0really=C2=A0runs slower (wall-clock time),=
 it's not=20
just the timing.
=C2=A0
--
 Andreas Joseph Krogh


------=_Part_167_1515651127.1534955958388
Content-Type: text/html;charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div>P=C3=A5 onsdag 22. august 2018 kl. 18:12:41, skrev Andres Freund &lt;<=
a href=3D"mailto:andres@anarazel.de">andres@anarazel.de</a>&gt;:</div>

<blockquote style=3D"border-left: 1px solid rgb(204, 204, 204); margin: 0pt=
 0pt 0pt 0.8ex; padding-left: 1ex;">
<div style=3D"display:inline; font-family: monospace; font-size: 12px;">Hi,=
<br>
<br>
On 2018-04-18 18:37:30 -0400, Robert Haas wrote:<br>
&gt; On Wed, Apr 18, 2018 at 3:29 PM, Andres Freund &lt;andres@anarazel.de&=
gt; wrote:<br>
&gt; &gt; Not convinced that that is true - the issue is more likely that J=
IT work in workers is counted as execute time... Gotta add that somehow, no=
t sure what the best way would be.<br>
&gt;<br>
&gt; Oh, that does seem like something that should be fixed.=C2=A0 If that'=
s<br>
&gt; what is happening here, it's bound to confuse a lot of people.<br>
&gt; Probably you need to add some code to<br>
&gt; ExecParallelRetrieveInstrumentation.<br>
<br>
I had lost track of this, and we unfortunately hadn't added an open item<br=
>
back then.=C2=A0 I think we should add it now?<br>
<br>
RMT (with me recused), do you think we should accept the new code fixing<br=
>
this would entail? And thus that this should be an open item? It's<br>
arguably a new feature, although I don't find that a terribly convincing<br=
>
position.<br>
<br>
Greetings,<br>
<br>
Andres Freund</div>
</blockquote>

<div>=C2=A0</div>

<div>Just to be clear; The query=C2=A0<em>really</em>=C2=A0runs slower (wal=
l-clock time), it's not just the timing.</div>

<div>=C2=A0</div>

<div class=3D"visena-email-signature" data-visena-message-id=3D"&lt;VisenaE=
mail.27.cb06f4d2cef742ad.165627feef4@tc7-visena>">
<div>--<br>
Andreas Joseph Krogh</div>
</div>
------=_Part_167_1515651127.1534955958388--

------=_Part_166_1251246492.1534955958376--

------=_Part_165_1349528865.1534955958375--