Date: Sun, 3 Jan 2021 21:05:09 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: pgsql-hackers@postgresql.org, Bruce Momjian <bruce@momjian.us>,
	Thomas Munro <thomas.munro@gmail.com>
Subject: Re: doc review for v14
Message-ID: <X/Gy9WIbyS3rnLyx@paquier.xyz>
References: <20201222041153.GK30237@telsasoft.com>
 <X+RNUu+zotOjfL7K@paquier.xyz>
 <20201227202604.GC26311@telsasoft.com>
 <X+r1YyXWE5obOazQ@paquier.xyz>
 <X/Ff7jfnvJUab013@paquier.xyz>
 <20210103063354.GI25152@telsasoft.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="fZmiZJJopuPs72lA"
Content-Disposition: inline
In-Reply-To: <20210103063354.GI25152@telsasoft.com>
Precedence: bulk


--fZmiZJJopuPs72lA
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Jan 03, 2021 at 12:33:54AM -0600, Justin Pryzby wrote:
>=20
> But actually, maybe we should just use the comment that exists everywhere=
 else
> for that.
>=20
>         /* Propagate context related error context to libxml2 */
>         xmlSetStructuredErrorFunc((void *) xtCxt->xmlerrcxt, xml_errorHan=
dler);

I quite like your suggestion to be a maximum simple here, and the docs
of upstream also give a lot of context:
http://xmlsoft.org/html/libxml-xmlerror.html#xmlSetStructuredErrorFunc

So let's use this version and call it a day for this part.
--
Michael

--fZmiZJJopuPs72lA
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl/xsvUACgkQnvQgOdby
QH00PA//Q8JvM+sBf/cXHkwzQ0kt7d1W0uw6ty6UPtFmwlBJ7TTHYU+flkNi9xo4
OEeoPswDMS25RzTB2xve9iAsBAmejwJS1P0aMQijECsgT1aV7oos6snAE/zC2ZAE
Qa1Et78CrjIcUrTFP+44jjpEpDESuKGvU0GrvgttLkh2fpaEsRy0lv4cFBxtRmq3
PjSK7eaoZeoTQS3jRg+vIQ/AAgwgjzfyjpUxb2Gr54oSypOtOalqvPsy+UQycHVX
78N8gKkhHlSevbuRrhwvQNayO6EkQZMlxkVMFiwivP2wjFZjI5+hpVfCjV18WTH1
LZ1dPXOVbIAK0hP3YIjmV7MYgrFhSyHf1sCFCn7mPtxSL0iTdCBZP8318XsQ37rv
t8wg9R1+xMQ3CDFoX3LwSYTYdiOTE8eTN3d0RYTpyQ96NIQQC5kpUUsK59SoHjY8
M2oH6783uPME59hGUQaREwtnrgmnoTUlzWY64TrMTxOfBSHHyp/q2wVPum7GnKvZ
8UuJK//J3T7okAqbGpuMUGl354Bj1BGqaUNebSBSDvxcisLQeGoKFXPhalbQiKLF
USojGFEw9PIqq3L5DOWBIUdlaTPtbt4jZrjpDW/T/1XaeIuP3a81rMTTlzBkvN/z
l3q2GttfS6d7zOnFnwjCUVSgyR2oyCprUk2+cOb9xpeeVwitttc=
=5zaS
-----END PGP SIGNATURE-----

--fZmiZJJopuPs72lA--