public inbox for [email protected]
help / color / mirror / Atom feedFrom: Michael Paquier <[email protected]>
To: Imseih (AWS), Sami <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Doc update for pg_stat_statements normalization
Date: Wed, 1 Mar 2023 09:09:57 +0900
Message-ID: <Y/[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
<Y/2JecAVDcD/[email protected]>
<[email protected]>
On Tue, Feb 28, 2023 at 11:11:30PM +0000, Imseih (AWS), Sami wrote:
> I agree. We introduce the concept of a plannable statement in a
> previous section and we can then make this distinction in the new
> paragraph.
>
> I also added a link to pg_stat_statements_info since that is introduced
> later on int the doc.
I have reworded the paragraph a bit to be more general so as it would
not need an update once more normalization is applied to utility
queries (I am going to fix the part where we mention that we use the
strings for utilities, which is not the case anymore now):
+ <para>
+ Queries on which normalization can be applied may be observed with constant
+ values in <structname>pg_stat_statements</structname>, especially when there
+ is a high rate of entry deallocations. To reduce the likelihood of this
+ happening, consider increasing <varname>pg_stat_statements.max</varname>.
+ The <structname>pg_stat_statements_info</structname> view, discussed below
+ in <xref linkend="pgstatstatements-pg-stat-statements-info"/>,
+ provides statistics about entry deallocations.
+ </para>
Are you OK with this text?
--
Michael
Attachments:
[text/x-diff] v3-0001-doc-update-regarding-pg_stat_statements-normaliza.patch (1.5K, ../Y%[email protected]/2-v3-0001-doc-update-regarding-pg_stat_statements-normaliza.patch)
download | inline diff:
From dd8938e4ba1b1f29d14b3fa2dc76301f42592cad Mon Sep 17 00:00:00 2001
From: Michael Paquier <[email protected]>
Date: Wed, 1 Mar 2023 09:05:08 +0900
Subject: [PATCH v3] doc update regarding pg_stat_statements normalization.
It is quite possible that a query text willl not normalize
(replace constants with $1, $2..) when there is a high rate
pgss_hash deallocation. This commit calls this out in docs.
---
doc/src/sgml/pgstatstatements.sgml | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/doc/src/sgml/pgstatstatements.sgml b/doc/src/sgml/pgstatstatements.sgml
index efc36da602..f1ba78c8cb 100644
--- a/doc/src/sgml/pgstatstatements.sgml
+++ b/doc/src/sgml/pgstatstatements.sgml
@@ -516,6 +516,16 @@
<structname>pg_stat_statements</structname> entry.
</para>
+ <para>
+ Queries on which normalization can be applied may be observed with constant
+ values in <structname>pg_stat_statements</structname>, especially when there
+ is a high rate of entry deallocations. To reduce the likelihood of this
+ happening, consider increasing <varname>pg_stat_statements.max</varname>.
+ The <structname>pg_stat_statements_info</structname> view, discussed below
+ in <xref linkend="pgstatstatements-pg-stat-statements-info"/>,
+ provides statistics about entry deallocations.
+ </para>
+
<para>
In some cases, queries with visibly different texts might get merged into a
single <structname>pg_stat_statements</structname> entry. Normally this will happen
--
2.39.2
[application/pgp-signature] signature.asc (833B, ../Y%[email protected]/3-signature.asc)
download
view thread (3+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: Doc update for pg_stat_statements normalization
In-Reply-To: <Y/[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox