Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pXGpy-0007bV-Vy for pgsql-hackers@arkaria.postgresql.org; Wed, 01 Mar 2023 07:25:18 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pXGpw-0003xH-MW for pgsql-hackers@arkaria.postgresql.org; Wed, 01 Mar 2023 07:25:16 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pXGpw-0003x1-Cs for pgsql-hackers@lists.postgresql.org; Wed, 01 Mar 2023 07:25:16 +0000 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pXGpu-0003nt-Qe for pgsql-hackers@lists.postgresql.org; Wed, 01 Mar 2023 07:25:15 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 1F5F132002E2; Wed, 1 Mar 2023 02:25:12 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 01 Mar 2023 02:25:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1677655511; x=1677741911; bh=jBWzMmolu/ KdowDkQeDxxmyFO7jXlnPFZmmqgLCvsrM=; b=S5N5IBKoznSfL8yVQqOutoyaBW 2iVtpPSOFqGDd1SaW6KZqQ8HP/krEYP5hL+zlOepabxmKkw/m3Nrk1AO6wavX0jV FGVAKxntHyrcKtrH2ZFxttK7+tTnRtf3oPnuxhGh3XAnz3MlNG/d06bcqYLQlemY nIecX+a/yyoezWLaEMqLtBj/hcWjDddbxJXsMWiCB0lqAjwd5Q5DCV/B+h68ZBDP ZE8lFN3BMFEEu81NQlFc6aiM3cG3OU/pLIN8Hur3CIU6S/Vb+3G6PoTVA5FCR7+2 HYL2uHunqeLtp6JIKeAa6EF90HouyuGd2pZZJmcYozKC3sNzHYvEonTUZX2w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1677655511; x=1677741911; bh=jBWzMmolu/KdowDkQeDxxmyFO7jX lnPFZmmqgLCvsrM=; b=oNYQ3JmMDgw7VvLK9A00gXHm1FLq4vM3Z8/AJ7rFBjr8 idF1wsan7iQ0dbwMw4aK3dZxHGqcc53/qyYgUBBhP15ku3uH54b3ijY1a6iRtgZp qdIoiiCXpWXUJTnE3FifFgNDtH386eZrKXpXauA5ST+O6pQr6zwwGyYYCmfb/I0d 06/uBDkYxm3iOKRdXDnRRsOgO4iaXzDcONNpL8Pu+Fs01ZoPOEZzXmDRZyebt0AA CoP0PHIhDSoqLK7TbTioKmK5M8E7Z0Tq6AGUkSBihs/LUdxwOw9GYtq/DSRmoMGc AvVu/QvwXBAu4eROFAZsNTTB7n7u2Bit/uxbJ7EpPQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudelgedguddtvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enfghrlhcuvffnffculdejtddmnecujfgurhepfffhvfevuffkfhggtggujgesghdtreer tddtvdenucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlse hprghquhhivghrrdighiiiqeenucggtffrrghtthgvrhhnpeetleeifedufffhhfdtteel geeggeffhfekueevteeigfduudevudetgfegiedvjeenucevlhhushhtvghrufhiiigvpe dtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmihgthhgrvghlsehprghquhhivghrrdig hiii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 1 Mar 2023 02:25:08 -0500 (EST) Date: Wed, 1 Mar 2023 16:24:59 +0900 From: Michael Paquier To: Justin Pryzby Cc: Tomas Vondra , gkokolatos@pm.me, shiy.fnst@fujitsu.com, pgsql-hackers@lists.postgresql.org, Rachel Heaton Subject: Re: Add LZ4 compression in pg_dump Message-ID: References: <6YZqN2HEE4yJxxxXWiMl4QWwKzLon0SdKETTGVkT9zjWnXMftGZjLKHHjGFuwC_5I6xL2s8nMXdLQGA4vEFveYXSHbfD9K9pDQvEJF2y99o=@pm.me> <535565cd-b69f-c064-a845-15c0fc44db4a@enterprisedb.com> <22cb80ed-ec87-54c7-fd5b-cdcf79766bb1@enterprisedb.com> <8421f53d-c9f7-c02e-3278-9f9522a8e8f3@enterprisedb.com> <20230228235834.GC30529@telsasoft.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="JQvC30Zh70AjskQI" Content-Disposition: inline In-Reply-To: <20230228235834.GC30529@telsasoft.com> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --JQvC30Zh70AjskQI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Feb 28, 2023 at 05:58:34PM -0600, Justin Pryzby wrote: > I found that e9960732a broke writing of empty gzip-compressed data, > specifically LOs. pg_dump succeeds, but then the restore fails: The number of issues you have been reporting here begins to worries me.. How many of them have you found? Is it right to assume that all of them have basically 03d02f5 as oldest origin point? -- Michael --JQvC30Zh70AjskQI Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmP+/csACgkQnvQgOdby QH1T5A/8Dq0dPRIxiI9lkRhD/u6EjtfCFzj403aMOLFuYHk+o6Ng/dSPIBaEqMdU 2mNawD2pMc1bQp6EuhR1SIfJZEuUpShcrzGSoCFipg9bTu4TltDuZPtPAJo2yTnl 6Fe008oxTXXQo2Pd1rDVxlbroVKt6LNZ2OkHI4ZF1bcJqV3jIdmg5EMPwmA7lbkc c4bdT67N/8IA7IMO60oElBgSZAZVGbMyk8pcKiGR34kHgQwnQcKYin9AeU5KmSUK Khli2WEtDiQJx0RfSFlz3ZEO+dnoO3ClCmwAF/uwc26RyR4fSudlUw6SvFYeBuFP gQiV5PFAUts7v6qRtgme2juPPrDsN7WC08l05h23doL5krUj0+73pYIXvPNwaqBf K9mZXMy8rQE2/+w2fI965CGG9jiSPNspiAhVjfHmfwpdDc/slzj2twU2akeg25de SvNJom3nNachbbPG0pRq9UnzHnitpkb/YiHhCEwDrvxpsGga9X09Y83nlxhBVu7+ eRHk9eT3jlzFXmtGQPlrnmrrHgm2LH0tOg3a3Wgprtnz9WdPne4Cgyd9qkE+/QQL v5wR7vmXd63FokaRu5250SfNRYnrsSLW0cspYs1E9Rsu0COvTRDDUJqeS5eNDf+T xLCFDWz67wJcsvfuQGDD5kdxkLvxjvYq1jaG/hrj7UPQZc88sa0= =Zgkx -----END PGP SIGNATURE----- --JQvC30Zh70AjskQI--