Date: Wed, 1 Mar 2023 10:00:49 -0500
From: Stephen Frost <sfrost@snowman.net>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Andres Freund <andres@anarazel.de>, Robert Haas <robertmhaas@gmail.com>,
	Tom Lane <tgl@sss.pgh.pa.us>, Michael Paquier <michael@paquier.xyz>,
	Thomas Munro <thomas.munro@gmail.com>,
	Fujii Masao <fujii@postgresql.org>,
	Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Weird failure with latches in curculio on v15
Message-ID: <Y/9ooVYNMH+FNE7M@tamriel.snowman.net>
References: <3907196.1675957889@sss.pgh.pa.us>
 <CA+TgmoY6xxDdZ1YJjMb27Ei7qgFcbu=__WtDX_cOd3GQ5uvxWw@mail.gmail.com>
 <20230209192952.jvx56yuutlxuvjjf@awork3.anarazel.de>
 <CA+TgmobQ5iWVCoPokW1jBrRb3V_x0PUXD05vvgS3FqQecvXHMw@mail.gmail.com>
 <20230216163254.nktnbbb2b7wlpzwy@awork3.anarazel.de>
 <CA+TgmoamQWK3JYkYtf7GPuzh9en2bDPTzw9c3BF+cHZDt0y7AQ@mail.gmail.com>
 <20230218211522.grbzg75vzjtqafzf@awork3.anarazel.de>
 <CA+TgmoaLCxrdHPSnRLD1j1FQQx4k7QSJq-ybVOYj2aEF34sQLQ@mail.gmail.com>
 <20230225190031.e3vesk22q5wpmmhc@awork3.anarazel.de>
 <20230301042919.GC1453450@nathanxps13>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="FPcMiwP9IjA70uFr"
Content-Disposition: inline
In-Reply-To: <20230301042919.GC1453450@nathanxps13>
User-Agent: Mutt/2.1.4 (2021-12-11)
Archived-At: <https://www.postgresql.org/message-id/Y/9ooVYNMH%2BFNE7M%40tamriel.snowman.net>
Precedence: bulk


--FPcMiwP9IjA70uFr
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Greetings,

* Nathan Bossart (nathandbossart@gmail.com) wrote:
> On Sat, Feb 25, 2023 at 11:00:31AM -0800, Andres Freund wrote:
> > TBH, I think the current archive and restore module APIs aren't useful.=
 I
> > think it was a mistake to add archive modules without having demonstrat=
ed that
> > one can do something useful with them that the restore_command didn't a=
lready
> > do. If anything, archive modules have made it harder to improve archivi=
ng
> > performance via concurrency.
>=20
> I must respectfully disagree that this work is useless.  Besides the
> performance and security benefits of not shelling out for every WAL file,
> I've found it very useful to be able to use the standard module framework
> to develop archive modules.  It's relatively easy to make use of GUCs,
> background workers, compression, etc.  Of course, there is room for
> improvement in areas like concurrency support as you rightly point out, b=
ut
> I don't think that makes the current state worthless.

Would be great to see these archive modules, perhaps it would help show
how this functionality is useful and what could be done in core to make
things easier for the archive module.

Thanks,

Stephen

--FPcMiwP9IjA70uFr
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEwf6gbxKhD863zrx/7WyKOINHZFUFAmP/aJ4ACgkQ7WyKOINH
ZFWZdQ//aLLeYnKknnFT1xx3WzqZBUPqjyDjCHiKsAErOvD7ot2A9kV2rvFnlvFl
8agr+Ic9k9U0SeWPu9U+++3APXAzHXIHAh+mvLk0BnlcezrZS3Ps6zq8og6peF2u
9P4jtyjy0Pb8CjNQ/+/hGYl6gvKjXPG23uPiUb4/JBAtID8WwRD+6+aR7O6X2eLm
ZrA/KThFxkwQTTtStD6eV8nR/1IvcS5xrRO3k6W0nYHa2NYb6260RQvfD4NjYjdz
HOQyhk6d5ewvRj0oPUnT/Cn5UvWOUaAu8aSONO2OdBVJ7w5/fuZnASegzdcqyf/P
zfVj/J+9SgdQtCnfEn2V6+F06avPm3fxF0Gb3AMCu0tFat+dVkONp7bsHahuIxwk
ww2lV2kNu0pvrYcfILfGh0JLSgFiWtp5aJEYlrr/iufnI+vHY/Drdfax4EaJad11
zoYsLC7HfYJG0tjVg2/p/SrEs4CGrxLnG40/YqARcx6BPYtl+M9lLWrUEgAptzEa
LajMXS7xJjwx2qY096Ma0YRvY92riNFfya0vpNKmqBXxxbKPlu/2H4eCz9KY0v7p
HwZT1khZpSzmGgy1gx9QXONK2sOPQYjgzvaJF4VQwbeb61ncL4DhyS3qnAtswlHb
DuubplaXTdrzsWWCRnmCCfJz8DSnPk/koOnoL3OfYoDTxVr1xXY=
=7aYC
-----END PGP SIGNATURE-----

--FPcMiwP9IjA70uFr--