Feedback-ID: i0fe9450f:Fastmail
Date: Mon, 20 Feb 2023 11:32:23 +0900
From: Michael Paquier <michael@paquier.xyz>
To: "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Normalization of utility queries in pg_stat_statements
Message-ID: <Y/Lbt12YUHSU2fYl@paquier.xyz>
References: <Y+MRdEq9W9XVa2AB@paquier.xyz>
 <Y+16K+q9L0yjV3zA@paquier.xyz>
 <0e067034-e92c-302b-24ed-492bca228e26@gmail.com>
 <Y+7n+uz6XkzJpB7z@paquier.xyz>
 <14965f63-6d78-45ff-d029-daafe8eddb40@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="yszgarbqNF/zRg62"
Content-Disposition: inline
In-Reply-To: <14965f63-6d78-45ff-d029-daafe8eddb40@gmail.com>
Archived-At: <https://www.postgresql.org/message-id/Y/Lbt12YUHSU2fYl%40paquier.xyz>
Precedence: bulk


--yszgarbqNF/zRg62
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Feb 17, 2023 at 09:36:27AM +0100, Drouvot, Bertrand wrote:
> On 2/17/23 3:35 AM, Michael Paquier wrote:
>> 0001 looks quite committable at this stage, and that's independent on
>> the rest.  At the end this patch creates four new test files that are
>> extended in the next patches: utility, planning, track and cleanup.
>=20
> Thanks! LGTM.

Thanks.  I have applied the set of regression tests in 0001 and 0002.
Note that I have changed the order of the attributes when querying
pg_stat_statements, to make easier to follow the diffs generated by
the normalization.  The unaligned mode would be another option, but
it makes not much sense as long as there are no more than two fields
with variable lengths.  Some extra notes about that:
- Should the test for the validation WAL generation metrics be moved
out?  I am not sure that it makes much sense to separate it as it has
a short purpose.
- Same issue with user activity, which creates a few roles and makes
sure that their activity is tracked?  We don't look at the userid in
this case, which does not make much sense to me.
- Same issue with locking clauses, worth a file of their own?

The main file is still named pg_stat_statements.sql, perhaps it should
be renamed to something more generic, like general.sql?  Or perhaps we
could just split the main file with a select.sql (with locking
clauses) and a dml.sql?

>> I am wondering if others have an opinion to share about that, but,
>> yes, 0004 seems enough to begin with.  We could always study more
>> normalization areas in future releases, taking it slowly.
>=20
> Agree.

These last ones are staying around for a few more weeks, until the
middle of the next CF, I guess.  After all this is done, the final
changes are very short, showing the effects of the normalization, as
of:
 6 files changed, 45 insertions(+), 35 deletions(-)
--
Michael

--yszgarbqNF/zRg62
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmPy27cACgkQnvQgOdby
QH3nWA//Ys/Tdja1FJBkbeftRzHPIIPJuawHcCoG7ptyIWc35MzZI3h0N/U8Nx+u
dyn07y57k2IO4hXHjqDHyaJVMzId+qKSdmxJt2oDfIxgMxvR2kP2ErV+LQJB2npg
nLGq1BZa4Mwn5QNZrjyx9Su7GzxejAlrkg7QJ+lp/g1I0dFY2y0uxjw1c9k69oce
IHJiSA+GPdQLz5eBa2Z//cOEafN77qB50mxwmtov+XxLA2dgfY/4pDUM2VjVXsBF
TWL2VILJU0tG+TudyBXy+UmJEnWNF9IZjn2g9yVoJGzC6KdzU40ijEjI7OsWStfK
ES/NG+FcbHYmbqAyqY3Hv3ZAiD0JJH+pEL9LX6UqaRIMW2iMT4YN538xoEFFgYzI
mZwA5fFdzmHgZEiUoxh/aLjsSQViVdPNQ4vgL/Vn3eK+gw7lzFns+H2dkt/HTm8n
gWEYAdcdfOjZhj5Bg+1BUGv1xrgoDwX+vYF9PoyWx1YBUAMvl+5mHQhJSonNp5OD
kixfsOFlfcuvS89xDrBlagkmSwwKOW8Q7mdQ9iXx5MEsQWSBC6DsVGvwYCNuUNSZ
M/Rv7FUeNRZl9N11dLNAorfjwIAXyFHC5LxQxf++Q+ABd0LjgP9Wd7eVE5akPmkD
RiXjfmvpM/965sIkGVS3uDkkbADKKzLY9epcmAgQKcqZb3oTdK8=
=ejMC
-----END PGP SIGNATURE-----

--yszgarbqNF/zRg62--