Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ohKzC-0001o4-Gp for pgsql-hackers@arkaria.postgresql.org; Sun, 09 Oct 2022 01:20:11 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1ohKz9-0002nV-VG for pgsql-hackers@arkaria.postgresql.org; Sun, 09 Oct 2022 01:20:07 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ohKz8-0002j1-7i for pgsql-hackers@lists.postgresql.org; Sun, 09 Oct 2022 01:20:07 +0000 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ohKz5-0005Qu-8L for pgsql-hackers@postgresql.org; Sun, 09 Oct 2022 01:20:05 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id A20BF3200564; Sat, 8 Oct 2022 21:19:58 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Sat, 08 Oct 2022 21:19:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1665278398; x=1665364798; bh=D8xa6jQN47 NMLiPp9sTJ5NE/Zluqn6p5Ebr8rrk8imw=; b=UNs/N6DMVnNogP2pvStBRFG2vU VQRL4ZV4jSDwCzpzNWY/wW0vdm4bGT+h3AMdafLppSFR2eIFVUBWF6igUmG4eoZ8 1xzshmVdDBtTC3gQ+9m5P7LfnJhhbW6dfh6u63Ylcx1rCv5mwss9hMh2xSk5G1/K yGG3hwy20BRutUppwRxKDKZqfln7OORxr6ofSGyl8FOr2Np4Q6bNhP0PbO+BW4vu xglt6QcdRljIw0lOE+hVghjDlGBayGvO2DUi3in6YXevA1Rz+vhm0atvnklL1NKl 9VR05hTOPoSkibaqYAwXP0Hd+j3S6/y6Fth5i5iwolgjRDEDSvNx7c7dSfxA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1665278398; x=1665364798; bh=D8xa6jQN47NMLiPp9sTJ5NE/Zluq n6p5Ebr8rrk8imw=; b=tm3j/DvlMhFi6QKLW11yMll9kGb3+Xa5/XH1dGzjv9r4 3nyXCeCWdTnptsYawuRxc77tRko1Xu/vBjqadbgySHhaNtZKhiQKGgo/TqIGQ4nh KNKQz7HZsTaUAEcC03PpprjPYx42gqiCcRIl2ISN2J4qyivB83rSusoLVE3lOdIN NKbvo7Sp/ontlmIC6gOho0GP95sW0y4u6ixko+Oy5enhotS2ZC68mouZTNERy/hC c7wjQZes2OvXDaCSdjwDSg1eGvk2yh0CueckiCaWwJr1vL0pRyqLh2eKzGflwrvQ VCElEo5lbpS+4YrKN8cMGVSxi2xbAJJaYUkoRJprEg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeejtddggeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvvefukfhfgggtuggjsehgtderredt tddvnecuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesph grqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepteelieefudffhffhtdetleeg geegfffhkeeuveetiefgudduvedutefggeeivdejnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiih ii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 8 Oct 2022 21:19:55 -0400 (EDT) Date: Sun, 9 Oct 2022 10:19:51 +0900 From: Michael Paquier To: Nathan Bossart Cc: "David G. Johnston" , Robert Haas , Tom Lane , Joe Conway , Joshua Brindle , PostgreSQL-development Subject: Re: use has_privs_of_role() for pg_hba.conf Message-ID: References: <20221007032711.GA499771@nathanxps13> <20221007194430.GA550749@nathanxps13> <3347532.1665173939@sss.pgh.pa.us> <20221007215836.GB814385@nathanxps13> <87994809-5b2c-08f0-0ab3-3c76c49afada@joeconway.com> <3574712.1665242046@sss.pgh.pa.us> <20221008171222.GB825354@nathanxps13> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="uPqUP9OaSq+I54iP" Content-Disposition: inline In-Reply-To: <20221008171222.GB825354@nathanxps13> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --uPqUP9OaSq+I54iP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, Oct 08, 2022 at 10:12:22AM -0700, Nathan Bossart wrote: > Okay, I think there are sufficient votes against this change to simply mark > it Rejected. Thanks for the discussion! Even if the patch is at the end rejected, I think that the test is still useful once you switch its logic to use membership and not inherited privileges for the roles created, and there is zero coverage for "samplegroup" and its kind currently. -- Michael --uPqUP9OaSq+I54iP Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmNCIbcACgkQnvQgOdby QH0nIw//YDh1gaSI4Gt/dWgEL3CSWSzxJi3CwcyAsAPcOs0AOw+FyoO/hrSyHvmd NdCp2dauTQuB6W1DYoQv+9kfOayMcJVeJVkEnAtqHpzM5Y5ni1mk+KYq+ISzqjQd oM7ZcK1j6F4RZxPN1sKiiPLc69EdJinwQO/tVaD3/Rq1XbxiaWtbZqwQR3HjRJcZ IWcZqnRbR9dGGFnmzKzj+P8V6gWADFw0ZZBBy9L4pzp20k1gWDmPThWwxJkLYFQw nQ5rN3/OdKb7wxLRWCFhcJt4ENlcPEWEYffe7fjZGuwIC7KSWLmmU5cRbVEe9g+g 4zHyQjcMiFWpEexY6Q3l+ukF3yf9nIA0hrF+BaHvQZoq7ciHG3r0bIdby8gjG1JW 3p/sFkdzWpOj5nZBQxbvVWi25qE7stvBvHOoUyWVMMfJbriK26BL2pcfpvfqV5JV bMDY/TSoYVKp9luXTcLEsJg3aQw+K2Cq9PH7nqTZDuw1bHYd5LZC8wtfOdw7g+9s 0gAPrx3YiI1EdFJxcDllGuwrEnnVpkj+DyFQEpGnlKu7kTFt8mCGAXMaIDZqzs2c svuxGolvZFWv6wYnJ4QNun7sSF+gRPJujrnUs3Eb8DBgtEyYyXsnxCGpwATyd6T4 FWRs3t92wS664BVEjJYcdkV9c1t++l7EhUJBAHpEpNMJCObW20w= =ueSa -----END PGP SIGNATURE----- --uPqUP9OaSq+I54iP--