Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 12 Oct 2022 10:18:50 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Allow tests to pass in OpenSSL FIPS mode
Message-ID: <Y0YV+lQNQFRIdvGJ@paquier.xyz>
References: <dbbd927f-ef1f-c9a1-4ec6-c759778ac852@enterprisedb.com>
 <647f6cc1-473d-f788-ade0-c09201e5ab6a@enterprisedb.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="9vlvu+p0NOulAZDl"
Content-Disposition: inline
In-Reply-To: <647f6cc1-473d-f788-ade0-c09201e5ab6a@enterprisedb.com>
Archived-At: 
 <https://www.postgresql.org/message-id/Y0YV%2BlQNQFRIdvGJ%40paquier.xyz>
Precedence: bulk


--9vlvu+p0NOulAZDl
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Oct 11, 2022 at 01:51:50PM +0200, Peter Eisentraut wrote:
> Let's make a small start on this.  The attached patch moves the tests of the
> md5() function to a separate test file.  That would ultimately make it
> easier to maintain a variant expected file for FIPS mode where that function
> will fail (similar to how we have done it for the pgcrypto tests).

Makes sense to me.  This slice looks fine.

I think that the other md5() computations done in the main regression
test suite could just be switched to use one of the sha*() functions
as they just want to put their hands on text values.  It looks like a
few of them have some expections with the output size and
generate_series(), though, but this could be tweaked by making the
series shorter, for example.
--
Michael

--9vlvu+p0NOulAZDl
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmNGFfoACgkQnvQgOdby
QH1c/A/9EWB26dhQ3H7y5VlNbfJRzRzVcP7CaWfRLaMptv/arvAkNJ5cwX6eT8Rs
7GRqaqfnJmaxA+/4LiRxU/LknFoib7xeJPc4fb/NmUxuZgUAX6LLnijZMWJ09v2r
Q8+E2J/y+bGW+28i/0+MP1+4tS2S0FgwThFKjUNRlfIdM1abOQDpBmtJAaurKkW3
E0QoHLXn3EK5ybyeHS757pjFP9sINiDTuosi6/WBnl/RJsX89YBup1F4I+JFF9Ej
d9wXCyk0PEzS2m4iYvnhRYbPDRcCnGk1Ai9gvIYV7dyyQ2YEyswiySZc95iRUEDU
dl+iMo/6xxoA3IrLrSYbIFa72809Uk6hPI64xHkNlV2QHDtY8KlX4ZtbQJ/4JZwe
Ov986PVG6HbgaS49uHZjBFu7lWq4Wh3EXkF4JO6sn9W4OUUR2Bi7zTl2yPs7j1Vg
IvRteJ4F7yh0KybtX51rFaehOXPK/jC+/++9lbBmM8/sZHLwpjTldzUzIbO3K3/x
sIVcfDAKEkHcXVZC4aGSPeJMm+mwhPmain7GS8PI/dIdlGaH7W3mdMS+pByVmsX+
tpNHRftA0v36dfLU+G7GcGZmIUThBqmEiBGLRyfbHl0qdMydVRrQqSeMAWej4cGp
5ETX4Kw40+Mbi3c9/0Xki7cmp7ISSE1TkLwmXif0oljWZ/kmls4=
=XF7q
-----END PGP SIGNATURE-----

--9vlvu+p0NOulAZDl--