Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 12 Oct 2022 14:10:15 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: andres@anarazel.de, jchampion@timescale.com, y.sokolov@postgrespro.ru,
	dilipbalaut@gmail.com, rjuju123@gmail.com,
	pgsql-hackers@lists.postgresql.org
Subject: Re: Error "initial slot snapshot too large" in create replication
 slot
Message-ID: <Y0ZMN2ntvHW8mwgp@paquier.xyz>
References: <20220912215156.zi52zu6n7od3k3v3@awork3.anarazel.de>
 <20220913.154507.1031550660908356731.horikyota.ntt@gmail.com>
 <20220913.161534.1763577367544098635.horikyota.ntt@gmail.com>
 <20220913.173105.1366509818461708829.horikyota.ntt@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="GCiYkmPM1sA5/Ovk"
Content-Disposition: inline
In-Reply-To: <20220913.173105.1366509818461708829.horikyota.ntt@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/Y0ZMN2ntvHW8mwgp%40paquier.xyz>
Precedence: bulk


--GCiYkmPM1sA5/Ovk
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Sep 13, 2022 at 05:31:05PM +0900, Kyotaro Horiguchi wrote:
> And ExportSnapshot repalces oversized subxip with overflowed.
>=20
> So even when GetSnapshotData() returns a snapshot with oversized
> subxip, it is saved as just "overflowed" on exporting. I don't think
> this is the expected behavior since such (no xip and overflowed)
> snapshot no longer works.
>=20
> On the other hand, it seems to me that snapbuild doesn't like
> takenDuringRecovery snapshots.
>=20
> So snapshot needs additional flag signals that xip is oversized and
> all xid are holded there. And also need to let takenDuringRecovery
> suggest subxip is oversized.

The discussion seems to have stopped here.  As this is classified as a
bug fix, I have moved this patch to next CF, waiting on author for the
moment.
--
Michael

--GCiYkmPM1sA5/Ovk
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmNGTDcACgkQnvQgOdby
QH0czA//VhPRRrXFSab1mjtl9i/FBZfrH5qkuAEe6wG3b5geNY4L3+H7iiFOK+Kv
qZb+GNIfGNDB3+2qkWSajxV7JnsImSBBlHI+35UbmxXAXxzJ4pWVlSeWApVwzBWb
eKPAmee5oAaB11v94NAlgiKSTVLY0X9ZQSuZjPD7X7igQvw75rNzE+LAywt9fEAe
NTxCLxL2RHu5vsFkEN7+DdpmJW0AjZWTAJwoBqVBebm/XD56Vscjav/hMefvKflC
hf09o1dLKvB+czdruI0Ir3+PLZHbpPK7OHU71S4rOYGiBmu19Yi8iRWOm/iah3fI
J5dI0FhQTimhwNJ2rcvoDw95OK9CSrkSC5P6h4EuKB8LBuecMDSOMFb1PhXnOnJp
ee3jM/GgoweWk2EMEW90vM5jq3jhLTkRC4/klgbKqD5kF/RzlpmXVDf8JXJeP+Q3
Y2oKz7APwr4jFTq1K2jNy1n55qIz43SUXsq2eUIoLhFMpo8NmQ8rA+/vIIPBTt8S
gpNTOBeTsgu7IofcXHTleiLseUZn2AiQEYCt45M2xp6+sfeb1mJZk9fpKuUb650/
4DeNCQAxee+nTs1gqybRVh6bLsM8o28aFEWqu1m89cLrESaUfLooVn7UpMuNQy2j
5x7kxxiNUJG1byHwAV8xATq3J1GDxRhNeM0wuxLvoH6fje8El0c=
=4Z4m
-----END PGP SIGNATURE-----

--GCiYkmPM1sA5/Ovk--